Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp9982911ybi; Wed, 24 Jul 2019 13:31:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqzatUWl+nOH1Sd98AQAJ7dcn+VKK7Xf2zKvK9uFvbPIBdwptXsFwns4q4s8dFsQMgNwlrG7 X-Received: by 2002:a17:90a:c588:: with SMTP id l8mr88054986pjt.16.1564000267097; Wed, 24 Jul 2019 13:31:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564000267; cv=none; d=google.com; s=arc-20160816; b=X8uEjGeQ/XmGfJNfIwyWTlSKNONVEjjQVg8E2p0YRPSDXNvctB8Muwgo8o8dEh56qX 3xArTCWIxnlpcfQMxxkXgRU4YDRANeoIf1rwzeNOwcec+PhYMsMgNrCs44tqNE6ij9SL deZnRVoP61cjFcPGHAB8SzBWEHcQrOPigNPss8Rtsj175lHqsEbUsBcm1BOjEetLhoza 7XDXlkJW/RuiGOr5gx+d9nNeQVDQOOBWaUEkZfNZzLybKPUN5RlxqNFMJFyHaKCavBn/ yyiN1RHCl9T8QiII+DO5zjh+5qEerqHqGNUiEImtpAWlNyb97+PvwPkmuCtxKGhNioaX IchA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=WrZhF6mHwYanHx5NCHrW2TtZATHFneNkP/8SZLCH4Bs=; b=DJNIqWloAIgtSFv3fXoJMfieWzRUfbi0KrZEMDFxh/YJ0B3J9F5XmfPVELVtCBKBM0 gq3DGfg6sG4SMV4RYiam5gdTD/M3ntAIL1I2aqPnzTO2QU8w9Ku2voqAzgN8zUZs405S qRSTGH090RSP15PSuiA6/x2r/TghbV9Eos5CNTKIBzCcCH/Bn9d/HvKm2G1mFXuf+VG/ HxGz9d7T/kU8V/UPyiLFmRggPTJQCg/XBby/iSafo/l339JL2UB9uIAwqPV2wF4NkBWa wm++QvIu9DAzG4pY5bKdd4ntxLG2AJf4Q0sLSL6CU22lOLAVeyAsJYDFnUKmAufPbR6f dMyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LiLc3CBb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s21si15965804pfe.204.2019.07.24.13.30.52; Wed, 24 Jul 2019 13:31:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=LiLc3CBb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389393AbfGXU3H (ORCPT + 99 others); Wed, 24 Jul 2019 16:29:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:55544 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387685AbfGXTdj (ORCPT ); Wed, 24 Jul 2019 15:33:39 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B930120659; Wed, 24 Jul 2019 19:33:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563996818; bh=1UxkEgMDGesnIPbV3F1ENZaDuBaggGu38f6L0zhjtCM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LiLc3CBb8W6abkTNBRYltzCMfUmt2dNQPHetchdS8z6zbX35vNEwqcYlOnbAVNbWZ Tu/F/0PFwJV44Ca7PGZUQSGLvfe0HVcy1ut4ZJRGRGkTTk55QQ0pQry+d4Qj76TqUb mSh4jVvnx2Z/qxQHU2DsxglRJyTgM0GuIcJoDPOw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jian Shen , Peng Li , Huazhong Tan , "David S. Miller" , Sasha Levin Subject: [PATCH 5.2 227/413] net: hns3: fix port capbility updating issue Date: Wed, 24 Jul 2019 21:18:38 +0200 Message-Id: <20190724191751.215518732@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190724191735.096702571@linuxfoundation.org> References: <20190724191735.096702571@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 49b1255603de5183c5e377200be3b3afe0dcdb86 ] Currently, the driver queries the media port information, and updates the port capability periodically. But it sets an error mac->speed_type value, which stops update port capability. Fixes: 88d10bd6f730 ("net: hns3: add support for multiple media type") Signed-off-by: Jian Shen Signed-off-by: Peng Li Signed-off-by: Huazhong Tan Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c index bab04d2d674a..f2bffc05e902 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c @@ -2592,6 +2592,7 @@ static int hclge_get_sfp_info(struct hclge_dev *hdev, struct hclge_mac *mac) mac->speed_ability = le32_to_cpu(resp->speed_ability); mac->autoneg = resp->autoneg; mac->support_autoneg = resp->autoneg_ability; + mac->speed_type = QUERY_ACTIVE_SPEED; if (!resp->active_fec) mac->fec_mode = 0; else -- 2.20.1