Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp10044190ybi; Wed, 24 Jul 2019 14:51:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqyLUbegTZVIrYZ9xdkzvUXOo6HReLSVRcsqGF/+fUpyPwv2s7Nx+9J/cU3tNsI0Z0mAnRHA X-Received: by 2002:a62:2a4d:: with SMTP id q74mr13373924pfq.86.1564005066548; Wed, 24 Jul 2019 14:51:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564005066; cv=none; d=google.com; s=arc-20160816; b=cO56/OtLw+/D4aUiCB2vvwzXIMzpJkqQWqIKviDBVtWJypIz5ZSWST4Vrhz73e4zob 8T1r+6RtF81QjHgspZmBDoLxUg4RTiXLpDSH2pRphCkatOhv+3Dekl77vPp8yDpVBO5w mzNyZlHlnR2BXVeQ1jFG9sWAypj54IzxnDqdHldU0QB7vSzfrUbic1GFV0tP5fXHUgi0 sb4g23mFM26FhEnuLArCCkSEaj2fLoATSk0/I448AAK1dl8Iz7Vaj+sHML9QSXJU9yaj FDpQqKNE2mFvI0S/n/DpdOIt6KQQ6LwkjGMSPtaodgfBYx90VJCK0G45QDp3l2AUWe6g teBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=dBgTyUUwUbm/th+a3nJeTDSGhpdTf5NasSnr4oIDxdM=; b=etnpvgoj2SNrqLQP9aX79Zm1iZPIpfY8ykLPh5MrEU60bm313p3p4vCf0JJ/F6+MQl 8K5kNhZ3WCFdZJVPqisRAXx/0hgWlwiX6F3Tgs3ehlTQ1djSltDHTH0iTsJIkQJL0Xxy TRP7xx4iIlHIKAV51z+D9azmuX21cllhgwBwsscKR1Ja7gOhED9P3o76CYVk1J5OrRgm bxa6GOVkZjc90N0g2fYigOMMexfQwT24tRek/ZGqHocBM1v1YMbIYHCUiYY2yaSDoaKb V0tDMJgcj9Nzd2jLjPM3CHAIc0tuUbwxz7LhLBhLrlHDc9XYOXMszLNme4RHAHIFR3nB hzFg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y14si21152091pfr.82.2019.07.24.14.50.51; Wed, 24 Jul 2019 14:51:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387653AbfGXSaK (ORCPT + 99 others); Wed, 24 Jul 2019 14:30:10 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:49584 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727083AbfGXSaK (ORCPT ); Wed, 24 Jul 2019 14:30:10 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 890CD15408838; Wed, 24 Jul 2019 11:30:09 -0700 (PDT) Date: Wed, 24 Jul 2019 11:30:08 -0700 (PDT) Message-Id: <20190724.113008.1837834250766825392.davem@davemloft.net> To: skunberg.kelsey@gmail.com Cc: iyappan@os.amperecomputing.com, keyur@os.amperecomputing.com, quan@os.amperecomputing.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [PATCH v3] drivers: net: xgene: Remove acpi_has_method() calls From: David Miller In-Reply-To: <20190724060659.105292-1-skunberg.kelsey@gmail.com> References: <20190723185811.8548-1-skunberg.kelsey@gmail.com> <20190724060659.105292-1-skunberg.kelsey@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 24 Jul 2019 11:30:09 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kelsey Skunberg Date: Wed, 24 Jul 2019 00:06:59 -0600 > acpi_evaluate_object will already return an error if the needed method > does not exist. Remove unnecessary acpi_has_method() calls and check the > returned acpi_status for failure instead. > > Signed-off-by: Kelsey Skunberg > --- > Changes in v2: > - Fixed white space warnings and errors > > Changes in v3: > - Resolved build errors caused by missing bracket Applied, will push out after build testing :)