Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 24 Jul 2019 19:12:33 -0700
User-Agent: K-9 Mail for Android
In-Reply-To: <20190724231528.32381-2-jhubbard@nvidia.com>
References: <20190724231528.32381-1-jhubbard@nvidia.com> <20190724231528.32381-2-jhubbard@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH 1/1] x86/boot: clear some fields explicitly
To:     john.hubbard@gmail.com
CC:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, LKML <linux-kernel@vger.kernel.org>,
        John Hubbard <jhubbard@nvidia.com>
From:   hpa@zytor.com
Message-ID: <B7DC31CA-E378-445A-A937-1B99490C77B4@zytor.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On July 24, 2019 4:15:28 PM PDT, john=2Ehubbard@gmail=2Ecom wrote:
>From: John Hubbard <jhubbard@nvidia=2Ecom>
>
>Recent gcc compilers (gcc 9=2E1) generate warnings about an
>out of bounds memset, if you trying memset across several fields
>of a struct=2E This generated a couple of warnings on x86_64 builds=2E
>
>Because struct boot_params is __packed__, normal variable
>variable assignment will work just as well as a memset here=2E
>Change three u32 fields to be cleared to zero that way, and
>just memset the _pad4 field=2E
>
>This clears up the build warnings for me=2E
>
>Signed-off-by: John Hubbard <jhubbard@nvidia=2Ecom>
>---
> arch/x86/include/asm/bootparam_utils=2Eh | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
>diff --git a/arch/x86/include/asm/bootparam_utils=2Eh
>b/arch/x86/include/asm/bootparam_utils=2Eh
>index 101eb944f13c=2E=2E4df87d4a043b 100644
>--- a/arch/x86/include/asm/bootparam_utils=2Eh
>+++ b/arch/x86/include/asm/bootparam_utils=2Eh
>@@ -37,12 +37,11 @@ static void sanitize_boot_params(struct boot_params
>*boot_params)
> 	if (boot_params->sentinel) {
> 		/* fields in boot_params are left uninitialized, clear them */
> 		boot_params->acpi_rsdp_addr =3D 0;
>-		memset(&boot_params->ext_ramdisk_image, 0,
>-		       (char *)&boot_params->efi_info -
>-			(char *)&boot_params->ext_ramdisk_image);
>-		memset(&boot_params->kbd_status, 0,
>-		       (char *)&boot_params->hdr -
>-		       (char *)&boot_params->kbd_status);
>+		boot_params->ext_ramdisk_image =3D 0;
>+		boot_params->ext_ramdisk_size =3D 0;
>+		boot_params->ext_cmd_line_ptr =3D 0;
>+
>+		memset(&boot_params->_pad4, 0, sizeof(boot_params->_pad4));
> 		memset(&boot_params->_pad7[0], 0,
> 		       (char *)&boot_params->edd_mbr_sig_buffer[0] -
> 			(char *)&boot_params->_pad7[0]);

The problem with this is that it will break silently when changes are made=
 to this structure=2E

So, that is a NAK from me=2E
--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E