Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp10421803ybi; Wed, 24 Jul 2019 22:56:32 -0700 (PDT) X-Google-Smtp-Source: APXvYqyMozGdP7m3KxcmZkhNO3RU5nqzRUv/wLxT8ZoWckBZy/yJ8oSw1yRPWkWsipz3fbKfBh+L X-Received: by 2002:a63:3387:: with SMTP id z129mr69518255pgz.177.1564034192174; Wed, 24 Jul 2019 22:56:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564034192; cv=none; d=google.com; s=arc-20160816; b=CiCJi+HovXpR7hxusKL51rrWWHbDRSlJKl3V0rL4+/kO6FHj8rgvMXliDrjpysdbWy kx+/TzwcVnp2xiYRI6pXBxmYU3PK15h7sbUHHiEdJDAogmXAOsQ2zC1/0fQl/AcU3WR2 d8bnxMGKkH+iL6SWzl9pacE4raJdLS4OpY5ShCS/Zni0aIIJD9Bhm+b/d/Ujvb5g7wn8 NQ+WKrXujCtq/cmm9bypzpR25HlDbYw7wxvqW1hv7VqpfLG1MlbpKb11nWIMm9lMJVU4 IHPH0bIkXSYavK0sSfspVgMiqsEbTtovlr6gwHEwjq0k4sxDx7ngytbNJSL7r4+B+0mR K+LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=IWA7Wo7GzZVK0/9J4vf7jS8SVLfy42qNg9pqCCOlSfE=; b=F0JeUl3ReWV89dSWdHIEok8MkshypNWVTrc2D+a39uEb0q2oi3XveF79hrUS4IeFzH FmT4RA/WAelcuMEAQCFHQvoRWhlsZnoJVf3hOtmzt/9IyBxqJMt5h5M0/SRQhauciqeO Z2L//vLluttniLraynJMMgIPYfvsIXm9AidpucVDdR8YKtET/Hh1oqSx+nRwTXwphIqH sv+bjLPtgfTYR7rppXPoVbbcoRlz9qLQ6lwG9akPHBnBgpkNhjJOs/eXF/OG/xTa++V9 5+J63/L+7eOgbFoFi3OyFMFaU8mkWeYQkXggMcF/HvDx3QopdYYvhPiN94uZeY9N6d0n jfMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2dZlolsh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z12si9766258pfc.99.2019.07.24.22.56.17; Wed, 24 Jul 2019 22:56:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2dZlolsh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403990AbfGYFjJ (ORCPT + 99 others); Thu, 25 Jul 2019 01:39:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:53262 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403967AbfGYFjH (ORCPT ); Thu, 25 Jul 2019 01:39:07 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 04EB322C7B; Thu, 25 Jul 2019 05:39:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564033146; bh=zH0OPT1fvPg9KVf3AJA47iF403EQgtr6HZTBNzn0//o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2dZlolshFnrPJAtOiUP9Hc50pMp70N8RJxcE1eY7tNP01q57W3HjjgHWHmlQ4u89e 6wQh9DUcjdLwTzLBUtg05UHH7dxZrUj0gvHe2qa0n/WSOdwgzZrSYBNbtiLhWv1LOg E5PfIcRGmkAtaRdiWWySPJVGPVkZ59EEYRCoaBXo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jason Wang , "Michael S. Tsirkin" , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 081/271] vhost_net: disable zerocopy by default Date: Wed, 24 Jul 2019 21:19:10 +0200 Message-Id: <20190724191702.128646931@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190724191655.268628197@linuxfoundation.org> References: <20190724191655.268628197@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 098eadce3c622c07b328d0a43dda379b38cf7c5e ] Vhost_net was known to suffer from HOL[1] issues which is not easy to fix. Several downstream disable the feature by default. What's more, the datapath was split and datacopy path got the support of batching and XDP support recently which makes it faster than zerocopy part for small packets transmission. It looks to me that disable zerocopy by default is more appropriate. It cold be enabled by default again in the future if we fix the above issues. [1] https://patchwork.kernel.org/patch/3787671/ Signed-off-by: Jason Wang Acked-by: Michael S. Tsirkin Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/vhost/net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c index 39155d7cc894..ae704658b528 100644 --- a/drivers/vhost/net.c +++ b/drivers/vhost/net.c @@ -36,7 +36,7 @@ #include "vhost.h" -static int experimental_zcopytx = 1; +static int experimental_zcopytx = 0; module_param(experimental_zcopytx, int, 0444); MODULE_PARM_DESC(experimental_zcopytx, "Enable Zero Copy TX;" " 1 -Enable; 0 - Disable"); -- 2.20.1