Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp10427141ybi; Wed, 24 Jul 2019 23:02:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqw7FWGyl/5TkJbP6IrOl5N+p7tbsAXCpBw76URM6x4dgdG2W5aHjWFIDvoEb/kzJD8kVVJE X-Received: by 2002:a17:902:a514:: with SMTP id s20mr84666435plq.162.1564034525537; Wed, 24 Jul 2019 23:02:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564034525; cv=none; d=google.com; s=arc-20160816; b=yLD6+3lMQIZVKXv+MP66chneB09vCVRLtE4ZUN6EqfAs/Wj9s7jnxB8MuHnq+DkOfT fxg4q7CdXDUYJ8ac/pTTE3pxLUWMEkrKAnNVUtVrWA/uklWYM7M94pY/n2AXsnizLZao rK9JUCQ45ZgbWNDl78leY/Fs76MhypzeEiP9OtcWs+0608UzWGh48Uyii06M/Yf0/4af mbZ4k7/KP+Peix9VA7juTFooVsjFtz4Nn8NTaZRwYPyBTU/b2YeSH8+qootwhBCS9plU CQDLgNPbsadPzlK4D3PCLFNB4CILe+B1s7vdaCPhJWIGmcO8TEcCRnsg/hxNU2S5TV1a 7zWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=F4lr2lt/DmsZxa1VjS7cAGfiETbXCOAEB4Hq2IewKq0=; b=J3Yrb4iU9rdj+2lgrVm96UpMKcTETeGimjDQv45E0wORO9Qfjyp/YF8plrJ0R0bE52 Pe+zzz2hDfBLO51X3eMAFeqc78CM657T/c5CSTK9Nmu/sLV5PixKjO402W93DApFa0dq BgcSG5nOcTAnC7gXSL80nlzGHbUFAqDU5VzSocgOKatjtEjMtnGfby8X3uuFaIw0DNev htvpnPLE0k5eH3ponmP/TPVDIHvTUBe5h3T4mh8BEPdpnM2xpwYm+0GKDsXqawd/opEk kJwwZT/lH8y8PA9C5FMWqD/Mq6QCasF5k+BS+wdx9176j2X609mEZtvZjHwsPs8r5OQH 4eGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=SbfjDmGi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r17si16679443pgj.259.2019.07.24.23.01.50; Wed, 24 Jul 2019 23:02:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=SbfjDmGi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405006AbfGYFom (ORCPT + 99 others); Thu, 25 Jul 2019 01:44:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:59782 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404976AbfGYFoh (ORCPT ); Thu, 25 Jul 2019 01:44:37 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C0ED421880; Thu, 25 Jul 2019 05:44:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564033476; bh=SGBSeKOUMG6UmYCPLHcS2N/HhSIKphdf3/Qhqbseroo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SbfjDmGi7jxRGyoVcOlrYZb2qyZS25OKw9qX1A8lxCbxCUyRHKtfDgbZ/lyXDM5wt YYtSu4jAo7lFE7E2tsSDqKOrLEBGgQW7d3Oz+eSTVbXFAXgMq6lhgUbODHRuulxSi/ Smetrb8Nq/5shaI4b8Hx61/HfNFdCbA1g/e0LyJw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , YueHaibing , Dominique Martinet Subject: [PATCH 4.19 222/271] 9p/virtio: Add cleanup path in p9_virtio_init Date: Wed, 24 Jul 2019 21:21:31 +0200 Message-Id: <20190724191714.161234197@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190724191655.268628197@linuxfoundation.org> References: <20190724191655.268628197@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YueHaibing commit d4548543fc4ece56c6f04b8586f435fb4fd84c20 upstream. KASAN report this: BUG: unable to handle kernel paging request at ffffffffa0097000 PGD 3870067 P4D 3870067 PUD 3871063 PMD 2326e2067 PTE 0 Oops: 0000 [#1 CPU: 0 PID: 5340 Comm: modprobe Not tainted 5.1.0-rc7+ #25 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.9.3-0-ge2fc41e-prebuilt.qemu-project.org 04/01/2014 RIP: 0010:__list_add_valid+0x10/0x70 Code: c3 48 8b 06 55 48 89 e5 5d 48 39 07 0f 94 c0 0f b6 c0 c3 90 90 90 90 90 90 90 55 48 89 d0 48 8b 52 08 48 89 e5 48 39 f2 75 19 <48> 8b 32 48 39 f0 75 3a RSP: 0018:ffffc90000e23c68 EFLAGS: 00010246 RAX: ffffffffa00ad000 RBX: ffffffffa009d000 RCX: 0000000000000000 RDX: ffffffffa0097000 RSI: ffffffffa0097000 RDI: ffffffffa009d000 RBP: ffffc90000e23c68 R08: 0000000000000001 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000000 R12: ffffffffa0097000 R13: ffff888231797180 R14: 0000000000000000 R15: ffffc90000e23e78 FS: 00007fb215285540(0000) GS:ffff888237a00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: ffffffffa0097000 CR3: 000000022f144000 CR4: 00000000000006f0 Call Trace: v9fs_register_trans+0x2f/0x60 [9pnet ? 0xffffffffa0087000 p9_virtio_init+0x25/0x1000 [9pnet_virtio do_one_initcall+0x6c/0x3cc ? kmem_cache_alloc_trace+0x248/0x3b0 do_init_module+0x5b/0x1f1 load_module+0x1db1/0x2690 ? m_show+0x1d0/0x1d0 __do_sys_finit_module+0xc5/0xd0 __x64_sys_finit_module+0x15/0x20 do_syscall_64+0x6b/0x1d0 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x7fb214d8e839 Code: 00 f3 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 RSP: 002b:00007ffc96554278 EFLAGS: 00000246 ORIG_RAX: 0000000000000139 RAX: ffffffffffffffda RBX: 000055e67eed2aa0 RCX: 00007fb214d8e839 RDX: 0000000000000000 RSI: 000055e67ce95c2e RDI: 0000000000000003 RBP: 000055e67ce95c2e R08: 0000000000000000 R09: 000055e67eed2aa0 R10: 0000000000000003 R11: 0000000000000246 R12: 0000000000000000 R13: 000055e67eeda500 R14: 0000000000040000 R15: 000055e67eed2aa0 Modules linked in: 9pnet_virtio(+) 9pnet gre rfkill vmw_vsock_virtio_transport_common vsock [last unloaded: 9pnet_virtio CR2: ffffffffa0097000 ---[ end trace 4a52bb13ff07b761 If register_virtio_driver() fails in p9_virtio_init, we should call v9fs_unregister_trans() to do cleanup. Link: http://lkml.kernel.org/r/20190430115942.41840-1-yuehaibing@huawei.com Cc: stable@vger.kernel.org Reported-by: Hulk Robot Fixes: b530cc794024 ("9p: add virtio transport") Signed-off-by: YueHaibing Signed-off-by: Dominique Martinet Signed-off-by: Greg Kroah-Hartman --- net/9p/trans_virtio.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) --- a/net/9p/trans_virtio.c +++ b/net/9p/trans_virtio.c @@ -782,10 +782,16 @@ static struct p9_trans_module p9_virtio_ /* The standard init function */ static int __init p9_virtio_init(void) { + int rc; + INIT_LIST_HEAD(&virtio_chan_list); v9fs_register_trans(&p9_virtio_trans); - return register_virtio_driver(&p9_virtio_drv); + rc = register_virtio_driver(&p9_virtio_drv); + if (rc) + v9fs_unregister_trans(&p9_virtio_trans); + + return rc; } static void __exit p9_virtio_cleanup(void)