Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp10439784ybi; Wed, 24 Jul 2019 23:14:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqwwAGoHAn0OacJOGKOymMW4UJHnVA3Okx97oW3FP2BbVGe0G6ZcPzvI1nPLgDhWJAs0rKVY X-Received: by 2002:a17:902:467:: with SMTP id 94mr88646201ple.131.1564035296582; Wed, 24 Jul 2019 23:14:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564035296; cv=none; d=google.com; s=arc-20160816; b=F+FB84jCdBVDLQ/9UrkZKclXmTA8F/rNgN1KFhxBNhDrvcbJkmzh+jrdG24t72T4eS NrhJM8J16fZm8QLWHPR/iWnQve2wyZaohzUBnxgjpl0czKzV5T48k4DMRsaf9jcgzREO AURQapPFERCSXRq3jlL73ZA8LaXLW8pC8aOP1wazu92G+vXCE9XWFw+q2w30DiBiC+r+ 6AjoAmXM3XYXHHYudqkP6y/XhdkKqsiMmTb67LIXTH5Xk9EK1le2OlKW6TgRqFo0AqHt atS/KL+HpH8NM3U8+Zx6sHnfn7skSvk8E7Z/2fZAzIobLx9vRaG+IH8wumxIjr4ZXsK4 Hm9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=VPfC7XBstZZI6t5tJl6V7gjlfNXNjvd4/x59oGSBeiI=; b=xsGe4s2UB7yt3vGbzKWP3MjFmzwTQO/bZV4hAWg3U2RhWUUOQ7cx9B8ZbQF0A6334h zpW3oU7uzXk4u/iw3abCaWto4GNXLoCUlr8xNIoQ8CNSJ5vkGbcbtKWJs0R2PZiQmpK6 3S3fLsdNvDsLnl0cG7seUnVWgvg+n3tloztei+OHl+SKVZavygaCL/rONCh9DR6Og3g8 Co618e20K11Kv9+zGmWUhnnxQZXjX/KAm8aMuXIFyNKTHIlXD8dMzHIuJbYPQ/CCB+Je yFEFzBNY8e3wZwt+2Xpv+3Ya8kkaqQOhpSdnENY9dOjWJFSTq/D+LCYEhY73ykhPb7c6 MYTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=izzzv+Bd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w18si14033322pll.132.2019.07.24.23.14.41; Wed, 24 Jul 2019 23:14:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=izzzv+Bd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404343AbfGYFkU (ORCPT + 99 others); Thu, 25 Jul 2019 01:40:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:54624 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404290AbfGYFkK (ORCPT ); Thu, 25 Jul 2019 01:40:10 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B448122BEF; Thu, 25 Jul 2019 05:40:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564033210; bh=3uSsuCn2bC+5Qh9r6pduaLyAIwG48pGXscbTNLwVHPE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=izzzv+BdPzXAqrLFMwqBNt34YETviqYuqXSLIZcAUwvNLjSTUHpYVHLfJpcp6nnYv TWISXjIoBx33hTT0RL40lHco62hWOdY7dDoZpvkMq2KHq70Gh5hgVuC+PsVLxDQ/sl vajno1JoL8wbYYN9PKGqm71Yt5rJBfvDbRppe+AI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wen Gong , Kalle Valo , Sasha Levin Subject: [PATCH 4.19 131/271] ath10k: destroy sdio workqueue while remove sdio module Date: Wed, 24 Jul 2019 21:20:00 +0200 Message-Id: <20190724191706.461853085@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190724191655.268628197@linuxfoundation.org> References: <20190724191655.268628197@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 3ed39f8e747a7aafeec07bb244f2c3a1bdca5730 ] The workqueue need to flush and destory while remove sdio module, otherwise it will have thread which is not destory after remove sdio modules. Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00007-QCARMSWP-1. Signed-off-by: Wen Gong Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- drivers/net/wireless/ath/ath10k/sdio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/sdio.c b/drivers/net/wireless/ath/ath10k/sdio.c index cb527a21f1ac..686759b5613f 100644 --- a/drivers/net/wireless/ath/ath10k/sdio.c +++ b/drivers/net/wireless/ath/ath10k/sdio.c @@ -2073,6 +2073,9 @@ static void ath10k_sdio_remove(struct sdio_func *func) cancel_work_sync(&ar_sdio->wr_async_work); ath10k_core_unregister(ar); ath10k_core_destroy(ar); + + flush_workqueue(ar_sdio->workqueue); + destroy_workqueue(ar_sdio->workqueue); } static const struct sdio_device_id ath10k_sdio_devices[] = { -- 2.20.1