Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp10644490ybi; Thu, 25 Jul 2019 02:59:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqwURfh5Ttgd0ZVrn5LBN90whLWu2JmzRsWe556tCuLTIKWvuiWAOTlOOtfX4jYFFBIPvTtR X-Received: by 2002:a17:90a:c391:: with SMTP id h17mr92688558pjt.131.1564048785276; Thu, 25 Jul 2019 02:59:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564048785; cv=none; d=google.com; s=arc-20160816; b=FHleWM+7DYyym9kYdrbslW21qg88d1YrDEaOD20NkfjIOdyOnAvkFrp9EeVDUv25N5 +pqNE6bC5fJRbd7yWkYxKdVCwn+h3IbtwOgO1O57nluCtjrRVI9tM2cOrW8TkeVZJG1p nBgHbrZOaRb7IykuuMsY5caP0j1Yx25lQ9YNIdpDomhqYvyOtp0ohUULDvr8EHJML7em y3Bs0D6B+KpiSfkM/dmQh10WUy0k6//SAYduD0+Q6i4C69tBC3VjsNDTXoHfpsHciGUr 85hMcADp/5ouL5taLsdMJj1kcv3X1vxSePz/iAxksuYvzmaG2y/Nmf8WG2N5rtyFeJkr eklQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=CB5Z8nr1WZSSNnI22cPzZ5y4y81aFkRUJTfJZecdvYA=; b=jLZOqyc1YTqUYu8ySeMDR/HCjG67KjbO2KufwUih/ceHcj48VI8RxCmtOqxprCr+Di nkZEQKTqofzxCfent5CsdccO/JKixYzAFVwDviJgRtN4F7TJ/Sn4L5MOSthwDS2Th8zU C8WrrM1ZCrafH+00Isd5CEEpjHgfNscLuzUeP4/vb+jYlEwy5UCPmGue8XWQ6uLNKZNi SxXjBJZOZAARxMnEnhpemOysDBu5Bkn2GMAMMixBxX6kXKGh1NXFCQofpgGeBB83XzkK oos9Dl0FoxJ3ocFfhS5eiScITQqhfNGAljVreLhnT0JKraCH5Oi2QuKD6F5BSZgUP/u6 MNzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=i0fC83yp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y23si15303496pjp.5.2019.07.25.02.59.26; Thu, 25 Jul 2019 02:59:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=i0fC83yp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389214AbfGYCgj (ORCPT + 99 others); Wed, 24 Jul 2019 22:36:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:40740 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387562AbfGYCgj (ORCPT ); Wed, 24 Jul 2019 22:36:39 -0400 Received: from localhost.localdomain (c-73-223-200-170.hsd1.ca.comcast.net [73.223.200.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0EA0B21852; Thu, 25 Jul 2019 02:36:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564022198; bh=D1/XAZeml+GaFLf+eOsik3qb0TT1TCoXAkWbdZi4Uk0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=i0fC83ypNVUKB9EVai4LXo+v9ARw5Eyade7UDcE4YL+6sCTYavtEvzFa0Tykazaz+ SsLvMemZaTAs++xQk83lBYn2Grm5YGG3xvnbO7/nLnU1R+78CB5s67GOwvl1L5kqIO uj/fRVIsKke3L1aYxS/VQVMNN28hRjeKuFm2wTWM= Date: Wed, 24 Jul 2019 19:36:37 -0700 From: Andrew Morton To: Pengfei Li Cc: willy@infradead.org, urezki@gmail.com, rpenyaev@suse.de, peterz@infradead.org, guro@fb.com, rick.p.edgecombe@intel.com, rppt@linux.ibm.com, aryabinin@virtuozzo.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 1/2] mm/vmalloc: do not keep unpurged areas in the busy tree Message-Id: <20190724193637.44ced3b82dd76649df28ecf5@linux-foundation.org> In-Reply-To: <20190716152656.12255-2-lpf.vector@gmail.com> References: <20190716152656.12255-1-lpf.vector@gmail.com> <20190716152656.12255-2-lpf.vector@gmail.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 16 Jul 2019 23:26:55 +0800 Pengfei Li wrote: > From: "Uladzislau Rezki (Sony)" > > The busy tree can be quite big, even though the area is freed > or unmapped it still stays there until "purge" logic removes > it. > > 1) Optimize and reduce the size of "busy" tree by removing a > node from it right away as soon as user triggers free paths. > It is possible to do so, because the allocation is done using > another augmented tree. > > The vmalloc test driver shows the difference, for example the > "fix_size_alloc_test" is ~11% better comparing with default > configuration: > > sudo ./test_vmalloc.sh performance > > > Summary: fix_size_alloc_test loops: 1000000 avg: 993985 usec > Summary: full_fit_alloc_test loops: 1000000 avg: 973554 usec > Summary: long_busy_list_alloc_test loops: 1000000 avg: 12617652 usec > > > > Summary: fix_size_alloc_test loops: 1000000 avg: 882263 usec > Summary: full_fit_alloc_test loops: 1000000 avg: 973407 usec > Summary: long_busy_list_alloc_test loops: 1000000 avg: 12593929 usec > > > 2) Since the busy tree now contains allocated areas only and does > not interfere with lazily free nodes, introduce the new function > show_purge_info() that dumps "unpurged" areas that is propagated > through "/proc/vmallocinfo". > > 3) Eliminate VM_LAZY_FREE flag. > > Signed-off-by: Uladzislau Rezki (Sony) This should have included your signed-off-by, since you were on the patch delivery path. (Documentation/process/submitting-patches.rst, section 11). Please send along your signed-off-by?