Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 2/2] powercap/rapl: Add Ice Lake NNPI support to RAPL
 driver
To:     "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc:     linux-kernel@vger.kernel.org, len.brown@intel.com,
        rafael.j.wysocki@intel.com, linux-pm@vger.kernel.org
References: <20190614080523.13464-1-rajneesh.bhardwaj@linux.intel.com>
 <2359736.lHFMKXy7DL@kreacher>
 <52eaefed-8f94-8cb0-0cfa-c0c16a34bd0b@linux.intel.com>
 <3695289.DUDsO16Ie3@kreacher>
From:   "Bhardwaj, Rajneesh" <rajneesh.bhardwaj@linux.intel.com>
Message-ID: <ec3be69b-5728-9d5a-b580-83e98c1c41ae@linux.intel.com>
Date:   Thu, 25 Jul 2019 13:31:04 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <3695289.DUDsO16Ie3@kreacher>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Rafael,

On 05-Jul-19 3:43 PM, Rafael J. Wysocki wrote:
> On Friday, June 28, 2019 10:21:41 AM CEST Bhardwaj, Rajneesh wrote:
>> On 28-Jun-19 3:32 AM, Rafael J. Wysocki wrote:
>>> On Friday, June 14, 2019 10:05:23 AM CEST Rajneesh Bhardwaj wrote:
>>>> Enables support for ICL-NNPI, which is a neural network processor for deep
>>>> learning inference. From RAPL point of view it is same as Ice Lake Mobile
>>>> processor.
>>>>
>>>> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
>>>> Cc: linux-pm@vger.kernel.org
>>>> Link: https://lkml.org/lkml/2019/6/5/1034
>>>> Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@linux.intel.com>
>>>> ---
>>>>    drivers/powercap/intel_rapl.c | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
>>>> index 4347f15165f8..431c8c8bdf07 100644
>>>> --- a/drivers/powercap/intel_rapl.c
>>>> +++ b/drivers/powercap/intel_rapl.c
>>>> @@ -1157,6 +1157,7 @@ static const struct x86_cpu_id rapl_ids[] __initconst = {
>>>>    	INTEL_CPU_FAM6(KABYLAKE_DESKTOP,	rapl_defaults_core),
>>>>    	INTEL_CPU_FAM6(CANNONLAKE_MOBILE,	rapl_defaults_core),
>>>>    	INTEL_CPU_FAM6(ICELAKE_MOBILE,		rapl_defaults_core),
>>>> +	INTEL_CPU_FAM6(ICELAKE_NNPI,		rapl_defaults_core),
>>>>    
>>>>    	INTEL_CPU_FAM6(ATOM_SILVERMONT,		rapl_defaults_byt),
>>>>    	INTEL_CPU_FAM6(ATOM_AIRMONT,		rapl_defaults_cht),
>>>>
>>> It is in my queue, but I get build errors when I try to apply it.
>>>
>>> I guess the definition of ICELAKE_NNPI is not there in the Linus' tree yet.
>> Yes, though
>> https://www.spinics.net/lists/linux-tip-commits/msg48978.html is
>> accepted by Thomas already.
> It is not in 5.2-rc7, though, AFAICS.
>
> The patch is still in my queue and waiting.


The CPUID patch on which this change depends is upstream now. 
https://github.com/torvalds/linux/blob/bed38c3e2dca01b358a62b5e73b46e875742fd75/arch/x86/include/asm/intel-family.h#L59 


Thank you

Rajneesh

>
>
>