Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1563811560-29589-1-git-send-email-olivier.moysan@st.com> <1563811560-29589-4-git-send-email-olivier.moysan@st.com>
In-Reply-To: <1563811560-29589-4-git-send-email-olivier.moysan@st.com>
From:   Benjamin Gaignard <benjamin.gaignard@linaro.org>
Date:   Thu, 25 Jul 2019 12:06:10 +0200
Message-ID: <CA+M3ks6ZRrLAa=xMPi5UfdLEzMCBCjeovUei2O9m8V4PW3bh-Q@mail.gmail.com>
Subject: Re: [PATCH v2 3/3] drm/bridge: sii902x: make audio mclk optional
To:     Olivier Moysan <olivier.moysan@st.com>
Cc:     Andrzej Hajda <a.hajda@samsung.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>, jernej.skrabec@siol.net,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        ML dri-devel <dri-devel@lists.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Benjamin GAIGNARD <benjamin.gaignard@st.com>,
        Alexandre Torgue <alexandre.torgue@st.com>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        linux-stm32@st-md-mailman.stormreply.com,
        Jyri Sarha <jsarha@ti.com>, Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Le lun. 22 juil. 2019 =C3=A0 18:06, Olivier Moysan <olivier.moysan@st.com> =
a =C3=A9crit :
>
> The master clock on i2s bus is not mandatory,
> as sii902X internal PLL can be used instead.
> Make use of mclk optional.

Applied on drm-misc-next.
Thanks,
Benjamin

>
> Signed-off-by: Olivier Moysan <olivier.moysan@st.com>
> Reviewed-by: Jyri Sarha <jsarha@ti.com>
> Acked-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
>  drivers/gpu/drm/bridge/sii902x.c | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/si=
i902x.c
> index 962931c20efe..a323815aa9b6 100644
> --- a/drivers/gpu/drm/bridge/sii902x.c
> +++ b/drivers/gpu/drm/bridge/sii902x.c
> @@ -568,13 +568,14 @@ static int sii902x_audio_hw_params(struct device *d=
ev, void *data,
>                 return ret;
>         }
>
> -       mclk_rate =3D clk_get_rate(sii902x->audio.mclk);
> -
> -       ret =3D sii902x_select_mclk_div(&i2s_config_reg, params->sample_r=
ate,
> -                                     mclk_rate);
> -       if (mclk_rate !=3D ret * params->sample_rate)
> -               dev_dbg(dev, "Inaccurate reference clock (%ld/%d !=3D %u)=
\n",
> -                       mclk_rate, ret, params->sample_rate);
> +       if (sii902x->audio.mclk) {
> +               mclk_rate =3D clk_get_rate(sii902x->audio.mclk);
> +               ret =3D sii902x_select_mclk_div(&i2s_config_reg,
> +                                             params->sample_rate, mclk_r=
ate);
> +               if (mclk_rate !=3D ret * params->sample_rate)
> +                       dev_dbg(dev, "Inaccurate reference clock (%ld/%d =
!=3D %u)\n",
> +                               mclk_rate, ret, params->sample_rate);
> +       }
>
>         mutex_lock(&sii902x->mutex);
>
> @@ -751,11 +752,11 @@ static int sii902x_audio_codec_init(struct sii902x =
*sii902x,
>                 sii902x->audio.i2s_fifo_sequence[i] |=3D audio_fifo_id[i]=
 |
>                         i2s_lane_id[lanes[i]] | SII902X_TPI_I2S_FIFO_ENAB=
LE;
>
> -       sii902x->audio.mclk =3D devm_clk_get(dev, "mclk");
> +       sii902x->audio.mclk =3D devm_clk_get_optional(dev, "mclk");
>         if (IS_ERR(sii902x->audio.mclk)) {
>                 dev_err(dev, "%s: No clock (audio mclk) found: %ld\n",
>                         __func__, PTR_ERR(sii902x->audio.mclk));
> -               return 0;
> +               return PTR_ERR(sii902x->audio.mclk);
>         }
>
>         sii902x->audio.pdev =3D platform_device_register_data(
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel