Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <CALjTZvbrS3dGrTrMMkGRkk=hRL38rrGiYTZ4REX9rJ0T+wcGoQ@mail.gmail.com>
 <alpine.DEB.2.21.1907241257240.1791@nanos.tec.linutronix.de>
 <CALjTZvZtu8sSycu2soSXCEP1yZiVNFKkxs4JY_puFahwFuuRcQ@mail.gmail.com>
 <alpine.DEB.2.21.1907250810530.1791@nanos.tec.linutronix.de>
 <CALjTZvb6aiUEgLN9BxOxBZCBXHoFxOx4TpBxkRQbZjgCna4WUA@mail.gmail.com> <alpine.DEB.2.21.1907251127430.1791@nanos.tec.linutronix.de>
In-Reply-To: <alpine.DEB.2.21.1907251127430.1791@nanos.tec.linutronix.de>
From:   Rui Salvaterra <rsalvaterra@gmail.com>
Date:   Thu, 25 Jul 2019 10:51:13 +0100
Message-ID: <CALjTZvY6b3C4EnKCDfqN2HUje45sh0uojYRRuyO=Jiuzz8uauw@mail.gmail.com>
Subject: Re: [BUG] Linux 5.3-rc1: timer problem on x86-64 (Pentium D)
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
        Daniel Drake <drake@endlessm.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi, Thomas,

On Thu, 25 Jul 2019 at 10:37, Thomas Gleixner <tglx@linutronix.de> wrote:
>
> Duh. Yes, this explains it nicely.
>
> > [    1.123548] clocksource: timekeeping watchdog on CPU1: Marking
> > clocksource 'tsc-early' as unstable because the skew is too large:
> > [    1.123552] clocksource:                       'hpet' wd_now: 33
> > wd_last: 33 mask: ffffffff
>
> The HPET counter check succeeded, but the early enable and the following
> reconfiguration confused it completely. So the HPET is not counting:
>
>         'hpet' wd_now: 33 wd_last: 33 mask: ffffffff
>
> Which is a full explanation for the boot fail because if the counter is not
> working then the HPET timer is not expiring and the early boot is waiting
> for HPET to fire forever.

Interesting. Thanks for the detailed explanation!

> That's consistent with the above. 5.3-rc1 unpatched would of course boot as
> well with hpet=disable now that we know the root cause.

I guess that's the only thing I hadn't tried, hindsight is 20/20. :)

> I'll write a changelog and route it to Linus for -rc2.
>
> Thanks a lot for debugging this and providing all the information!

My pleasure! I'm glad to have this old workhorse chugging along again.

Thanks,
Rui