Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1562141052-26221-1-git-send-email-olivier.moysan@st.com> <129ffc9a-0bfc-354e-c4a1-9043260832c0@ti.com>
In-Reply-To: <129ffc9a-0bfc-354e-c4a1-9043260832c0@ti.com>
From:   Benjamin Gaignard <benjamin.gaignard@linaro.org>
Date:   Thu, 25 Jul 2019 14:31:24 +0200
Message-ID: <CA+M3ks6H4OC0SUUj=34OxCq-chA-W_YxO_xs_0hkJAuxQv12JQ@mail.gmail.com>
Subject: Re: [PATCH] drm/bridge: sii902x: add audio graph card support
To:     Jyri Sarha <jsarha@ti.com>
Cc:     Olivier Moysan <olivier.moysan@st.com>,
        Andrzej Hajda <a.hajda@samsung.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>, jernej.skrabec@siol.net,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        ML dri-devel <dri-devel@lists.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Benjamin GAIGNARD <benjamin.gaignard@st.com>,
        Alexandre Torgue <alexandre.torgue@st.com>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        linux-stm32@st-md-mailman.stormreply.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Le jeu. 11 juil. 2019 =C3=A0 13:09, Jyri Sarha <jsarha@ti.com> a =C3=A9crit=
 :
>
> On 03/07/2019 11:04, Olivier Moysan wrote:
> > Implement get_dai_id callback of audio HDMI codec
> > to support ASoC audio graph card.
> > HDMI audio output has to be connected to sii902x port 3.
> > get_dai_id callback maps this port to ASoC DAI index 0.
> >
> > Signed-off-by: Olivier Moysan <olivier.moysan@st.com>
>
> I have not used audio graph binding, but compared to the other
> get_dai_id() implementations, this looks identical. So:
>
> Reviewed-by: Jyri Sarha <jsarha@ti.com>

Applied on drm-misc-next,
Thanks,
Benjamin

>
> > ---
> >  drivers/gpu/drm/bridge/sii902x.c | 23 +++++++++++++++++++++++
> >  1 file changed, 23 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/=
sii902x.c
> > index dd7aa466b280..daf9ef3cd817 100644
> > --- a/drivers/gpu/drm/bridge/sii902x.c
> > +++ b/drivers/gpu/drm/bridge/sii902x.c
> > @@ -158,6 +158,8 @@
> >
> >  #define SII902X_I2C_BUS_ACQUISITION_TIMEOUT_MS       500
> >
> > +#define SII902X_AUDIO_PORT_INDEX             3
> > +
> >  struct sii902x {
> >       struct i2c_client *i2c;
> >       struct regmap *regmap;
> > @@ -690,11 +692,32 @@ static int sii902x_audio_get_eld(struct device *d=
ev, void *data,
> >       return 0;
> >  }
> >
> > +static int sii902x_audio_get_dai_id(struct snd_soc_component *componen=
t,
> > +                                 struct device_node *endpoint)
> > +{
> > +     struct of_endpoint of_ep;
> > +     int ret;
> > +
> > +     ret =3D of_graph_parse_endpoint(endpoint, &of_ep);
> > +     if (ret < 0)
> > +             return ret;
> > +
> > +     /*
> > +      * HDMI sound should be located at reg =3D <3>
> > +      * Return expected DAI index 0.
> > +      */
> > +     if (of_ep.port =3D=3D SII902X_AUDIO_PORT_INDEX)
> > +             return 0;
> > +
> > +     return -EINVAL;
> > +}
> > +
> >  static const struct hdmi_codec_ops sii902x_audio_codec_ops =3D {
> >       .hw_params =3D sii902x_audio_hw_params,
> >       .audio_shutdown =3D sii902x_audio_shutdown,
> >       .digital_mute =3D sii902x_audio_digital_mute,
> >       .get_eld =3D sii902x_audio_get_eld,
> > +     .get_dai_id =3D sii902x_audio_get_dai_id,
> >  };
> >
> >  static int sii902x_audio_codec_init(struct sii902x *sii902x,
> >
>
>
> --
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel