Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp11152503ybi; Thu, 25 Jul 2019 10:54:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqwAjMDoDMGzL7VIXHwV7xbfUhMKt4utS5TMJolUDZyXN6y0Bdb/afIBMi820RQzKBQ3krVL X-Received: by 2002:a17:902:9b94:: with SMTP id y20mr91889686plp.260.1564077279544; Thu, 25 Jul 2019 10:54:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564077279; cv=none; d=google.com; s=arc-20160816; b=ghB7gUaiL1rLyUBc/xcYocfSk/cizeJrqroRgpg2DQUPy49EBMDMNwPyxlP14WJlpd Oitw5RWB3+xflR4oSLMraRJzQbDxrIMcgGdkAdBGG243MbdFGjAMvnIq4QA8mjhiQWT4 6NG0YaEgKB/QwABSzJB0GlCoGdRX5S8jCCrgO2fvkvTaaKTeQLJGPWiPQnkSs1ssls/H NMmf5WzQtD+LMHM7k+16/1m/+dayeH2TiJm/pR5363faMJeMLGB9ZXC/GNSp267E5tus idNEn0AKwcuzjGwPX9yW63gRXQYJe90j/t3faBaZDmT9ZELCspgG3bYGh/XiUrOlj7pu gc7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ijKb9xkNQpLXP3ePyMDNd5C2fEcHsiRFSZbSc5IKwxM=; b=GwfhT+uZQYALcLqb19OviQ60hRge6UILeaT2quQtjnzCDqUOf8W7DgX6Ocz0YImoK3 GRpafa14j0nwY4NKfum0WiBFyL4Ny/GWGokXalkGfcYIBFdpfFw2P6wgRvrHDEVJkA+Q lfogqjI9Xa7ifF2EUYPLjF23ND5EDLnO6Q+oWu8cHkLxR55MQn9Utwl7HEbzveIAM+jM yMTf+l1CX9f+K1zPLIz3Gt+KdTVvt3hQ8FACnudzQ845Y2n/iLCHlsJW8seAQQQBL45b anm20Z6qk8BhfEzcGt91uXzuc9qO6jVENhRvoYA1Uuq5G7YXvJCVSAlcX0EvQvV9CAJO 4acA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=TsCFOLaz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f139si47738304pfa.2.2019.07.25.10.54.23; Thu, 25 Jul 2019 10:54:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=TsCFOLaz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727772AbfGYN4V (ORCPT + 99 others); Thu, 25 Jul 2019 09:56:21 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:52820 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726894AbfGYN4U (ORCPT ); Thu, 25 Jul 2019 09:56:20 -0400 Received: by mail-wm1-f68.google.com with SMTP id s3so45087451wms.2; Thu, 25 Jul 2019 06:56:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ijKb9xkNQpLXP3ePyMDNd5C2fEcHsiRFSZbSc5IKwxM=; b=TsCFOLazPPC9sGh202Kobh/yPQrBmnaqShEAsYKLqQO3VNfmeJJYk/TywMrrUGJ0NL +YJy1nGykJKnieNuddH32ahJFUEhWfLPbcxWIj71+1L1N/b9DHGkLQTdDheQJUdmhhfh /qfiS0UapR+mySo3aXeazFrZjACw20RBjdfWEsvGKEgLv6MZBAfwFN+my8tD46Y4i4E1 NS4U2Q4xG6REuvi31RMpEpeH5tMyKBWU76pjsxHozO6iLXS7pcrms3mnb49CfN8ApVtM 5nNF3gcqjM3ArdyE1bjXeiFo2dNYTfKkO9qfZ/eQ0FPq3CVPXR+9rhMQ1+ZeX35QCSFp ZA8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=ijKb9xkNQpLXP3ePyMDNd5C2fEcHsiRFSZbSc5IKwxM=; b=JuQQxBQBlHq04YhizdYD7+WXkU1kXlnfIRUBEqTzVkBHg3e7KiArfG1F6zZqACCKoM rK46yOGrV99GDNhxC+5SEFgFs0fNseCErITzOxfFvVQAda9omzolNjUDoPy9kErJGgLI ZbFN2pi02v+8+IwMGkkkUg1fp2zfgsHpLIEbOIs4s+SXfDzMiRX0Qw/9sm24uJipYkhe JzwdJ1TPZtX1RfCkh8xAsqQ+0LiBAuPI3o3DNwJ6Q3OuTT50Lo9nImON8tr8Ojf602cn 8pMwGvkI9NbX+EYGKctl8+3GBvMLP6UPfSaZHIwfthn0bdb9+K167TFDzHrEoXulizZD bNxQ== X-Gm-Message-State: APjAAAUqN/MtUcYAp/EzyNI6n2P1j4dMCpzR7caO3ecSspiQwgQTzwn6 F09JQeKUoJXkdeDEiaBtPKQ= X-Received: by 2002:a1c:5453:: with SMTP id p19mr74461459wmi.148.1564062978247; Thu, 25 Jul 2019 06:56:18 -0700 (PDT) Received: from gmail.com (2E8B0CD5.catv.pool.telekom.hu. [46.139.12.213]) by smtp.gmail.com with ESMTPSA id u186sm84400263wmu.26.2019.07.25.06.56.16 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 25 Jul 2019 06:56:17 -0700 (PDT) Date: Thu, 25 Jul 2019 15:56:15 +0200 From: Ingo Molnar To: Juri Lelli Cc: peterz@infradead.org, mingo@redhat.com, rostedt@goodmis.org, tj@kernel.org, linux-kernel@vger.kernel.org, luca.abeni@santannapisa.it, claudio@evidence.eu.com, tommaso.cucinotta@santannapisa.it, bristot@redhat.com, mathieu.poirier@linaro.org, lizefan@huawei.com, longman@redhat.com, dietmar.eggemann@arm.com, cgroups@vger.kernel.org Subject: Re: [PATCH v9 3/8] cpuset: Rebuild root domain deadline accounting information Message-ID: <20190725135615.GB108579@gmail.com> References: <20190719140000.31694-1-juri.lelli@redhat.com> <20190719140000.31694-4-juri.lelli@redhat.com> <20190725135351.GA108579@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190725135351.GA108579@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Ingo Molnar wrote: > > * Juri Lelli wrote: > > > When the topology of root domains is modified by CPUset or CPUhotplug > > operations information about the current deadline bandwidth held in the > > root domain is lost. > > > > This patch addresses the issue by recalculating the lost deadline > > bandwidth information by circling through the deadline tasks held in > > CPUsets and adding their current load to the root domain they are > > associated with. > > > > Signed-off-by: Mathieu Poirier > > Signed-off-by: Juri Lelli > > Was this commit written by Mathieu? If yes then it's missing a From line. > If not then the Signed-off-by should probably be changed to Acked-by or > Reviewed-by? So for now I'm assuming that the original patch was written by Mathieu, with modifications by you. So I added his From line and extended the SOB chain with the additional information that you modified the patch: Tested-by: Dietmar Eggemann Signed-off-by: Mathieu Poirier Signed-off-by: Juri Lelli [ Various additional modifications. ] Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Ingo Molnar Let me know if that's not accurate! Thanks, Ingo