Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750895AbVLGLdX (ORCPT ); Wed, 7 Dec 2005 06:33:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750891AbVLGLdX (ORCPT ); Wed, 7 Dec 2005 06:33:23 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:15266 "EHLO mx3.mail.elte.hu") by vger.kernel.org with ESMTP id S1750705AbVLGLdW (ORCPT ); Wed, 7 Dec 2005 06:33:22 -0500 Date: Wed, 7 Dec 2005 12:33:24 +0100 From: Ingo Molnar To: Nick Piggin Cc: Andrew Morton , tglx@linutronix.de, zippel@linux-m68k.org, linux-kernel@vger.kernel.org, rostedt@goodmis.org, johnstul@us.ibm.com Subject: Re: [patch 00/21] hrtimer - High-resolution timer subsystem Message-ID: <20051207113324.GA28646@elte.hu> References: <20051206000126.589223000@tglx.tec.linutronix.de> <1133908082.16302.93.camel@tglx.tec.linutronix.de> <20051207013122.3f514718.akpm@osdl.org> <20051207101137.GA25796@elte.hu> <4396B81E.4030605@yahoo.com.au> <20051207104900.GA26877@elte.hu> <4396C2EB.1000203@yahoo.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4396C2EB.1000203@yahoo.com.au> User-Agent: Mutt/1.4.2.1i X-ELTE-SpamScore: 0.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=0.0 required=5.9 tests=AWL autolearn=no SpamAssassin version=3.0.3 0.0 AWL AWL: From: address is in the auto white-list X-ELTE-VirusStatus: clean Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1639 Lines: 43 * Nick Piggin wrote: > >>Just curious -- why the "k" thing? > > > > > >yeah. 'struct timer' and 'struct timeout' is even better. I tried it on > > Oh good, glad you think so :) > > >real code and sometimes it looked a bit funny: often we have a 'timeout' > >parameter somewhere that is a scalar or a timeval/timespec. So at least > > Sure... hmm, the names timeout and timer themselves have something > vagely wrong about them, but I can't quite place my finger on it, not > a real worry though... > > Maybe it is that timeout is an end result, but timer is a mechanism. hm, i think you are right. > So maybe it should be 'struct interval', 'struct timeout'; or 'struct > timer', 'struct timeout_timer'. maybe 'struct timer' and 'struct hrtimer' is the right solution after all, and our latest queue doing 'struct timer_list' + 'struct hrtimer' is actually quite close to it. 'struct ptimer' does have a bit of vagueness in it at first sight, do you agree with that? (does it mean 'process'? 'posix'? 'precision'?) also, hrtimers on low-res clocks do have high internal resolution, but they are not precise timing mechanisms in the end, due to the low-res clock. So the more generic name would be 'high-resolution timers', not 'precision timers'. (also, the name 'precision timers' sounds a bit funny too, but i dont really know why.) Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/