Date: Wed, 7 Dec 2005 13:18:04 +0100
From: Pavel Machek <pavel@suse.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Andy Isaacson <adi@hexapodia.org>, linux-kernel@vger.kernel.org
Subject: Re: swsusp: how much memory to free? [was Re: swsusp performance problems in 2.6.15-rc3-mm1]
Message-ID: <20051207121804.GH2563@elf.ucw.cz>
References: <20051205081935.GI22168@hexapodia.org> <200512071253.54055.rjw@sisk.pl> <20051207115952.GF2563@elf.ucw.cz> <200512071316.58351.rjw@sisk.pl>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200512071316.58351.rjw@sisk.pl>
User-Agent: Mutt/1.5.9i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 915
Lines: 31

Hi!

> > Looks good to me.
> > 
> > > Index: linux-2.6.15-rc5-mm1/kernel/power/swsusp.c
> > > ===================================================================
> > > --- linux-2.6.15-rc5-mm1.orig/kernel/power/swsusp.c	2005-12-05 22:07:12.000000000 +0100
> > > +++ linux-2.6.15-rc5-mm1/kernel/power/swsusp.c	2005-12-07 12:40:27.000000000 +0100
> > > @@ -626,6 +626,7 @@
> > >  
> > >  int swsusp_shrink_memory(void)
> > >  {
> > > +	unsigned long size;
> > >  	long tmp;
> > 
> > Perhaps both should be long, or both unsigned long?
> 
> tmp has to be signed.  Both can be long, though.
> 
> Should I test it and post for merging?

Yes..
							Pavel

-- 
Thanks, Sharp!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/