Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp11169182ybi; Thu, 25 Jul 2019 11:10:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqwT1s4kw/z1N8EtSReF+nf/NbHUwHUIPU95M51XkyEaM0y53IKm6mo6fTcSBKt6KnY6x7m7 X-Received: by 2002:aa7:86c6:: with SMTP id h6mr18248268pfo.51.1564078236343; Thu, 25 Jul 2019 11:10:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564078236; cv=none; d=google.com; s=arc-20160816; b=F5Odoapr2qVO36rgx4UIQd/GRFgL7E4P2p52zugxc6Dm5KBtmiHMZULG4pec8K289x 8PYmBTBteVHoT/cpyekKYpOUDT74gSjJhM38VUZAG0f2WIo7onlx+gdUFithjcFoNGWz 48MRf6PAEqtX/jer39HSX7+JBI7y0QP2AHnPWYR5LJhoE4hGngL5ZqYL4H/OhZ9+Q48i kLWqdxd5jVG/4bY3xQT5UfRc58EEJ564BPJOjadoZ+W02U7ICrojRaEVZd967arnsFt+ m0xbpu/lPZStvrGH4HAunrEsaM8vAYJ4meC7zyatU2qiLwtdqNE+E9W5EwUc8wKAp/eH 77pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=jGAg9NbrZM4/REnf890+otF98/BlAirM2URndXQWC28=; b=Fi8YwIzYcAK4CUSV1SuMTOtM9orVnsQSYnAdQRrc+I4D2coKTs4GOrzwOaTYqrO8hA KXDR0OysATXNNyEw9u1vx4+LcktZsXBTnrwDYphoYQ9RCDFza4mBOYbAusirTKreGN4n PqCi53Fym04H0DSXXF3BHk8X2syPBVbwQ8UtiHb+jTGJqBz0arn120haJsaefggFK8k8 VwOKsIdrEeAtM6/q4yaqg8aVtD0zj2GaOE4WZEnmgAlrdVslJPA7hQDs/hf/dZgug7PW UfLMOV3qWgxni+YwUYaxzkno6Zf4TmuiZUW/F/l0vi4EPiHAxn8FcAXaDS1CrH4hP/33 R1mg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=J199Kf3X; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j1si18760998pgb.482.2019.07.25.11.10.21; Thu, 25 Jul 2019 11:10:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=J199Kf3X; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729519AbfGYQtf (ORCPT + 99 others); Thu, 25 Jul 2019 12:49:35 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:36735 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728842AbfGYQte (ORCPT ); Thu, 25 Jul 2019 12:49:34 -0400 Received: by mail-pl1-f195.google.com with SMTP id k8so23647883plt.3 for ; Thu, 25 Jul 2019 09:49:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jGAg9NbrZM4/REnf890+otF98/BlAirM2URndXQWC28=; b=J199Kf3X84tFgsqCefIPoNnYl8hkA6n/odyUSb9ydiH8DNHy8xGdJRB1sFlQu5Sw01 vKFepLLC8e7340FrTVX5BmanPQIzpH4Gonaq8d4qz7KPOEHCIbfCz4howJkkrxj6teXd Th65YJvcp5T+OU4B8dN9J1BK70WkDrKLyy1ClVk/L8NDn6q3jjrjMIcgdSNtC6crWcw0 juuuBl2fjvbLZNPM20KroT9zXspb+MM306NILvy5wi5LCQJfGGPvJXpRaBLbFaGfgD6N WqlXAql907zZGIHTHCjw53A/CkT0caxA8i2/9Hl3T0LPHHDEgsBKUxadCoO8IbF1IKUn dCGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jGAg9NbrZM4/REnf890+otF98/BlAirM2URndXQWC28=; b=Apbev5JPIvp9g7bU2cXOMf50JX2q2j1kTsy2mzxehS+Rr6QNSlF3jBrn8KCTuYO//D h884Vwu8SjXPBbts8dH1z3HSOnpaT6LCWgSeMaHELX9fv5JaNkUBsuyWWCuH4aLZUVGV nQzrmJ5QNu1XtlL+PVlU1cyO62VDO4yrpLEY6HnIRMLH9OfYWziOJb69LXrCiiRXFoTi 7HA1crxsLAdmGkCi5m8d0l96xxTF30wk13PAhvC3BOIJBGs2xaLR66+AhfdzF1XnEpwH MnnRgsVDsj7crnYG0yWigpL3Hlasq8wZn2hXkrWMoyRG7Oq39nSGRv93/R8TefsRQAPP XzCw== X-Gm-Message-State: APjAAAWf2gx/gcTW7xEgxjJB5FPFo43K+EeM/9q6zpWhanhhc/7XF0G8 +D77RU56MwCrZE14nfRxJfA= X-Received: by 2002:a17:902:6a2:: with SMTP id 31mr87214469plh.296.1564073373059; Thu, 25 Jul 2019 09:49:33 -0700 (PDT) Received: from Asurada-Nvidia.nvidia.com (thunderhill.nvidia.com. [216.228.112.22]) by smtp.gmail.com with ESMTPSA id l31sm88186182pgm.63.2019.07.25.09.49.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Jul 2019 09:49:32 -0700 (PDT) Date: Thu, 25 Jul 2019 09:50:15 -0700 From: Nicolin Chen To: Ezequiel Garcia Cc: hch@lst.de, robin.murphy@arm.com, Marek Szyprowski , vdumpa@nvidia.com, Russell King , Catalin Marinas , Will Deacon , chris@zankel.net, jcmvbkbc@gmail.com, joro@8bytes.org, David Woodhouse , Tony Lindgren , Andrew Morton , sfr@canb.auug.org.au, treding@nvidia.com, keescook@chromium.org, iamjoonsoo.kim@lge.com, wsa+renesas@sang-engineering.com, linux-arm-kernel , Linux Kernel Mailing List , linux-xtensa@linux-xtensa.org, iommu@lists.linux-foundation.org, dann.frazier@canonical.com, dafna.hirschfeld@collabora.com Subject: Re: [PATCH v3 1/2] dma-contiguous: Abstract dma_{alloc,free}_contiguous() Message-ID: <20190725165015.GA31961@Asurada-Nvidia.nvidia.com> References: <20190524040633.16854-1-nicoleotsuka@gmail.com> <20190524040633.16854-2-nicoleotsuka@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 25, 2019 at 01:06:42PM -0300, Ezequiel Garcia wrote: > I can't find a way to forward-redirect from Gmail, so I'm Ccing Dafna > who found a regression caused by this commit. Dafna, can you give all > the details, including the log and how you are reproducing it? I saw the conversation there. Sorry for not replying yet. May we discuss there since there are full logs available? Thanks Nicolin > > > On Fri, 24 May 2019 at 01:08, Nicolin Chen wrote: > > > > Both dma_alloc_from_contiguous() and dma_release_from_contiguous() > > are very simply implemented, but requiring callers to pass certain > > parameters like count and align, and taking a boolean parameter to > > check __GFP_NOWARN in the allocation flags. So every function call > > duplicates similar work: > > /* A piece of example */ > > unsigned long order = get_order(size); > > size_t count = size >> PAGE_SHIFT; > > page = dma_alloc_from_contiguous(dev, count, order, gfp & __GFP_NOWARN); > > [...] > > dma_release_from_contiguous(dev, page, size >> PAGE_SHIFT); > > > > Additionally, as CMA can be used only in the context which permits > > sleeping, most of callers do a gfpflags_allow_blocking() check and > > a corresponding fallback allocation of normal pages upon any false > > result: > > /* A piece of example */ > > if (gfpflags_allow_blocking(flag)) > > page = dma_alloc_from_contiguous(); > > if (!page) > > page = alloc_pages(); > > [...] > > if (!dma_release_from_contiguous(dev, page, count)) > > __free_pages(page, get_order(size)); > > > > So this patch simplifies those function calls by abstracting these > > operations into the two new functions: dma_{alloc,free}_contiguous. > > > > As some callers of dma_{alloc,release}_from_contiguous() might be > > complicated, this patch just implements these two new functions to > > kernel/dma/direct.c only as an initial step. > > > > Suggested-by: Christoph Hellwig > > Signed-off-by: Nicolin Chen > > --- > > Changelog > > v2->v3: > > * Added missing "static inline" in header file to fix build error. > > v1->v2: > > * Added new functions beside the old ones so we can replace callers > > one by one later. > > * Applied new functions to dma/direct.c only, because it's the best > > example caller to apply and should be safe with the new functions. > > > > include/linux/dma-contiguous.h | 11 ++++++++ > > kernel/dma/contiguous.c | 48 ++++++++++++++++++++++++++++++++++ > > kernel/dma/direct.c | 24 +++-------------- > > 3 files changed, 63 insertions(+), 20 deletions(-) > > > > diff --git a/include/linux/dma-contiguous.h b/include/linux/dma-contiguous.h > > index f247e8aa5e3d..00a370c1c140 100644 > > --- a/include/linux/dma-contiguous.h > > +++ b/include/linux/dma-contiguous.h > > @@ -115,6 +115,8 @@ struct page *dma_alloc_from_contiguous(struct device *dev, size_t count, > > unsigned int order, bool no_warn); > > bool dma_release_from_contiguous(struct device *dev, struct page *pages, > > int count); > > +struct page *dma_alloc_contiguous(struct device *dev, size_t size, gfp_t gfp); > > +void dma_free_contiguous(struct device *dev, struct page *page, size_t size); > > > > #else > > > > @@ -157,6 +159,15 @@ bool dma_release_from_contiguous(struct device *dev, struct page *pages, > > return false; > > } > > > > +static inline > > +struct page *dma_alloc_contiguous(struct device *dev, size_t size, gfp_t gfp) > > +{ > > + return NULL; > > +} > > + > > +static inline > > +void dma_free_contiguous(struct device *dev, struct page *page, size_t size) { } > > + > > #endif > > > > #endif > > diff --git a/kernel/dma/contiguous.c b/kernel/dma/contiguous.c > > index b2a87905846d..21f39a6cb04f 100644 > > --- a/kernel/dma/contiguous.c > > +++ b/kernel/dma/contiguous.c > > @@ -214,6 +214,54 @@ bool dma_release_from_contiguous(struct device *dev, struct page *pages, > > return cma_release(dev_get_cma_area(dev), pages, count); > > } > > > > +/** > > + * dma_alloc_contiguous() - allocate contiguous pages > > + * @dev: Pointer to device for which the allocation is performed. > > + * @size: Requested allocation size. > > + * @gfp: Allocation flags. > > + * > > + * This function allocates contiguous memory buffer for specified device. It > > + * first tries to use device specific contiguous memory area if available or > > + * the default global one, then tries a fallback allocation of normal pages. > > + */ > > +struct page *dma_alloc_contiguous(struct device *dev, size_t size, gfp_t gfp) > > +{ > > + int node = dev ? dev_to_node(dev) : NUMA_NO_NODE; > > + size_t count = PAGE_ALIGN(size) >> PAGE_SHIFT; > > + size_t align = get_order(PAGE_ALIGN(size)); > > + struct cma *cma = dev_get_cma_area(dev); > > + struct page *page = NULL; > > + > > + /* CMA can be used only in the context which permits sleeping */ > > + if (cma && gfpflags_allow_blocking(gfp)) { > > + align = min_t(size_t, align, CONFIG_CMA_ALIGNMENT); > > + page = cma_alloc(cma, count, align, gfp & __GFP_NOWARN); > > + } > > + > > + /* Fallback allocation of normal pages */ > > + if (!page) > > + page = alloc_pages_node(node, gfp, align); > > + > > + return page; > > +} > > + > > +/** > > + * dma_free_contiguous() - release allocated pages > > + * @dev: Pointer to device for which the pages were allocated. > > + * @page: Pointer to the allocated pages. > > + * @size: Size of allocated pages. > > + * > > + * This function releases memory allocated by dma_alloc_contiguous(). As the > > + * cma_release returns false when provided pages do not belong to contiguous > > + * area and true otherwise, this function then does a fallback __free_pages() > > + * upon a false-return. > > + */ > > +void dma_free_contiguous(struct device *dev, struct page *page, size_t size) > > +{ > > + if (!cma_release(dev_get_cma_area(dev), page, size >> PAGE_SHIFT)) > > + __free_pages(page, get_order(size)); > > +} > > + > > /* > > * Support for reserved memory regions defined in device tree > > */ > > diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c > > index 2c2772e9702a..0816c1e8b05a 100644 > > --- a/kernel/dma/direct.c > > +++ b/kernel/dma/direct.c > > @@ -96,8 +96,6 @@ static bool dma_coherent_ok(struct device *dev, phys_addr_t phys, size_t size) > > struct page *__dma_direct_alloc_pages(struct device *dev, size_t size, > > dma_addr_t *dma_handle, gfp_t gfp, unsigned long attrs) > > { > > - unsigned int count = PAGE_ALIGN(size) >> PAGE_SHIFT; > > - int page_order = get_order(size); > > struct page *page = NULL; > > u64 phys_mask; > > > > @@ -109,20 +107,9 @@ struct page *__dma_direct_alloc_pages(struct device *dev, size_t size, > > gfp |= __dma_direct_optimal_gfp_mask(dev, dev->coherent_dma_mask, > > &phys_mask); > > again: > > - /* CMA can be used only in the context which permits sleeping */ > > - if (gfpflags_allow_blocking(gfp)) { > > - page = dma_alloc_from_contiguous(dev, count, page_order, > > - gfp & __GFP_NOWARN); > > - if (page && !dma_coherent_ok(dev, page_to_phys(page), size)) { > > - dma_release_from_contiguous(dev, page, count); > > - page = NULL; > > - } > > - } > > - if (!page) > > - page = alloc_pages_node(dev_to_node(dev), gfp, page_order); > > - > > + page = dma_alloc_contiguous(dev, size, gfp); > > if (page && !dma_coherent_ok(dev, page_to_phys(page), size)) { > > - __free_pages(page, page_order); > > + dma_free_contiguous(dev, page, size); > > page = NULL; > > > > if (IS_ENABLED(CONFIG_ZONE_DMA32) && > > @@ -154,7 +141,7 @@ void *dma_direct_alloc_pages(struct device *dev, size_t size, > > if (PageHighMem(page)) { > > /* > > * Depending on the cma= arguments and per-arch setup > > - * dma_alloc_from_contiguous could return highmem pages. > > + * dma_alloc_contiguous could return highmem pages. > > * Without remapping there is no way to return them here, > > * so log an error and fail. > > */ > > @@ -176,10 +163,7 @@ void *dma_direct_alloc_pages(struct device *dev, size_t size, > > > > void __dma_direct_free_pages(struct device *dev, size_t size, struct page *page) > > { > > - unsigned int count = PAGE_ALIGN(size) >> PAGE_SHIFT; > > - > > - if (!dma_release_from_contiguous(dev, page, count)) > > - __free_pages(page, get_order(size)); > > + dma_free_contiguous(dev, page, size); > > } > > > > void dma_direct_free_pages(struct device *dev, size_t size, void *cpu_addr, > > -- > > 2.17.1 > >