Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190722095425.14193-1-amergnat@baylibre.com> <20190722095425.14193-4-amergnat@baylibre.com>
 <1j5znqxj74.fsf@starbuckisacylon.baylibre.com>
In-Reply-To: <1j5znqxj74.fsf@starbuckisacylon.baylibre.com>
From:   Chen-Yu Tsai <wens@kernel.org>
Date:   Fri, 26 Jul 2019 01:09:20 +0800
Message-ID: <CAGb2v64AJFMkZQaytYMN+EsLT0sS-3VwzWUfb3g7SdL7kCfu+g@mail.gmail.com>
Subject: Re: [PATCH 3/8] clk: meson: gxbb: migrate to the new parent
 description method
To:     Jerome Brunet <jbrunet@baylibre.com>,
        Alexandre Mergnat <amergnat@baylibre.com>
Cc:     Neil Armstrong <narmstrong@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Kevin Hilman <khilman@baylibre.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        baylibre-upstreaming@groups.io,
        "open list:ARM/Amlogic Meson..." <linux-amlogic@lists.infradead.org>,
        linux-clk <linux-clk@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jul 25, 2019 at 10:50 PM Jerome Brunet <jbrunet@baylibre.com> wrote:
>
> On Mon 22 Jul 2019 at 11:54, Alexandre Mergnat <amergnat@baylibre.com> wrote:
>
>
> > @@ -1592,13 +1737,29 @@ static struct clk_regmap gxbb_vid_pll_div = {
> >       .hw.init = &(struct clk_init_data) {
> >               .name = "vid_pll_div",
> >               .ops = &meson_vid_pll_div_ro_ops,
> > -             .parent_names = (const char *[]){ "hdmi_pll" },
> > +             .parent_data = &(const struct clk_parent_data) {
> > +                     /*
> > +                      * This clock is declared here for GXL and GXBB SoC, so
> > +                      * we must use string name to set this parent to avoid
> > +                      * pointer issue.
> > +                      */
>
> I don't really get the issue with this comment.
>
> How about:
>
> /*
>  * Note:
>  * gxl and gxbb have different hdmi_plls (with different struct clk_hw).
>  * We fallback to the global naming string mechanism so vid_pll_div picks
>  * up the appropriate one.
>  */

If you're sticking to global names for now, you could just skip converting
this clock altogether. I suspect .parent_names will be around for some time.

On the other hand, if you really want to get rid of global clock name based
parenting, you could use clk_hw pointers, and have the probe function fix
up this one based on the compatible string. That's what I did.

Just my two cents.

ChenYu

> > +                     .name = "hdmi_pll",
> > +                     .index = -1,
> > +             },
> >               .num_parents = 1,
> >               .flags = CLK_SET_RATE_PARENT | CLK_GET_RATE_NOCACHE,
> >       },
> >  };
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel