Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp11175028ybi; Thu, 25 Jul 2019 11:16:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqxAE1wjsDxwoDfKr0Ap4nlfHYu9forMRXTj+3OfZamFvrosxiD4IbYkQBGvxB/0kJKH8itz X-Received: by 2002:aa7:90c9:: with SMTP id k9mr17427341pfk.171.1564078581158; Thu, 25 Jul 2019 11:16:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564078581; cv=none; d=google.com; s=arc-20160816; b=OLf6HtLw+iDXzZcnaApjATdSoeIUrwbLUZ7KJJCCnxT5SsPMO7LTF+N3VgmTzmOZEJ rOBfDzrTGUM2T7I3cMsLhMsNIM9uK703artbAx4f/ZZCZPD5Xmeh2IB+A09rhoG5Rmu1 iFQnJNqwddGrAqZUj1pBy0loPe58Ka5I1RYhdH5iwkzPtGvoid8atFZ3dEVT1yJaZFzJ fLKfb/aP2QQ9jIlu5d0UBNqxYiTY74CrwDpBRvxSamUZmHws4u6CRKyS1oafjXptrbBj akEv9h3Mbqj/7HcCyUpMYlFqvjy2OMLusMtrwgN3yqhp6IbZ3ouG90pl6dgHxgxifZZc jKGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=C/3jo0jsE8wFgw2iplq9k3+bvhgHMroF2GYfUpuZsE0=; b=PZxaGhPaO6dlsmWof3uwttbx1D+vnLYivNECx1qUFcLP18JhwuJ3P7jOoLtV9qPwN2 cuyuGDDng7azH3wbgPCugMFLjplXf1SDevN00gBn8ersFzXpK9VXRlxU2ikWqCOQmgYJ W4kK6FbiF6teRVLs+xVG4ATKSbXRFlll84gMOCLiXBpp9AO1fNQMbKbfRh82yIxbCCfI /jMyDOQdcfODMufQUk2QQlBopvO9L0rhf55srHzIZ7jm9JVsPgK13O/Qp0kG9KcEHIhx +qvHn+Py3dU/wYh5YXT2LlpbC5APw16Hk1BGbHh7Z/fS+/xhM05pGZorNjU5JxEwDrhB SZqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=DhAx15tD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cj12si16624319plb.237.2019.07.25.11.16.05; Thu, 25 Jul 2019 11:16:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=DhAx15tD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730113AbfGYRx6 (ORCPT + 99 others); Thu, 25 Jul 2019 13:53:58 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:8008 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729911AbfGYRxz (ORCPT ); Thu, 25 Jul 2019 13:53:55 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 25 Jul 2019 10:53:52 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Thu, 25 Jul 2019 10:53:54 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 25 Jul 2019 10:53:54 -0700 Received: from rcampbell-dev.nvidia.com (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 25 Jul 2019 17:53:54 +0000 Subject: Re: [PATCH] mm/hmm: replace hmm_update with mmu_notifier_range To: Jason Gunthorpe CC: , , , , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Christoph Hellwig , Ben Skeggs References: <20190723210506.25127-1-rcampbell@nvidia.com> <20190725011424.GA377@ziepe.ca> X-Nvconfidentiality: public From: Ralph Campbell Message-ID: Date: Thu, 25 Jul 2019 10:53:54 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190725011424.GA377@ziepe.ca> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL104.nvidia.com (172.18.146.11) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1564077232; bh=C/3jo0jsE8wFgw2iplq9k3+bvhgHMroF2GYfUpuZsE0=; h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=DhAx15tDao86fNlJyG41mGVLdRS4/AWdLS624zZoNmWkk3D7BjMR5xCzjLZBoVLLx afryURRZB/swcEevPYzWOT4IVLi5ZgHxsDCQxxQZNU6w1WG01nZ+jnybjiYlec0vWp K6uyYQSPu7IuTdfmgboDdwx9/ORVCRuDPSJ/c/qeHQ3cU5SCDV+AE/nkHy+jt4ovLk pQSLsmpMP9fnSGq/ZjIzvO2xYXfrRtfQD5SL0e1xKeJ9tGrj4h282I5a4ENoccpPue GlSEJMxOnjXGYBZawJUxgLm5FITum1dRyJQiJGTyd/6mJ251nH2dme/+hCCQk3hiuA UmXZ1fHXQ2LkQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/24/19 6:14 PM, Jason Gunthorpe wrote: > On Tue, Jul 23, 2019 at 02:05:06PM -0700, Ralph Campbell wrote: >> The hmm_mirror_ops callback function sync_cpu_device_pagetables() passes >> a struct hmm_update which is a simplified version of struct >> mmu_notifier_range. This is unnecessary so replace hmm_update with >> mmu_notifier_range directly. >> >> Signed-off-by: Ralph Campbell >> Cc: "J=C3=A9r=C3=B4me Glisse" >> Cc: Jason Gunthorpe >> Cc: Christoph Hellwig >> Cc: Ben Skeggs >> >> This is based on 5.3.0-rc1 plus Christoph Hellwig's 6 patches >> ("hmm_range_fault related fixes and legacy API removal v2"). >> Jason, I believe this is the patch you were requesting. >=20 > Doesn't this need revision to include amgpu? >=20 > drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c: .sync_cpu_device_pagetabl= es =3D amdgpu_mn_sync_pagetables_gfx, > drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c: .sync_cpu_device_pagetabl= es =3D amdgpu_mn_sync_pagetables_hsa, >=20 > Thanks, > Jason >=20 Yes. I have added this to v2 which I'll send out with Christoph's 2=20 patches and the hmm_range.vma removal patch you suggested.