Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp11200852ybi; Thu, 25 Jul 2019 11:46:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqzRbc9EEg6fFp8+Qq5TH6kx+9+ziaBh5URI+CnrJkkQYjxUd6vbARKmFKDjY2ONQBEGbrHY X-Received: by 2002:a63:4041:: with SMTP id n62mr16480805pga.312.1564080394459; Thu, 25 Jul 2019 11:46:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564080394; cv=none; d=google.com; s=arc-20160816; b=OA4nE4zLUOKSvrvnJENk4S/tPqp5R4m7lqHBaJN24ehmDor5Vs1JgQFyKB8OH44Pen WdfpEt9LGljnKSY1GXT1POYGIN+kRcyrDXH1ZS/UMgj7ceauNkGgL2Sy1Q2/2upbsjpq UJMKMgWaniqTw4vb/NxuzrOGMuu/7fmB+mxsYcmXXu6DpCm8LWO7pQFepEelcFimAoi8 LZsdEEg+y0oE5Tp4qJWcktGvTS0gNPr09Gaa0vhGsvrhffJ5oRz86HgF7dFYQ0MFTdpN RH3EJFq4du79VMsAEs1tEgkz1zy3L5Tsa0+xKbpkXHM6wbKD5n6hq+5e8LlpCK8SiN+U SKvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=bPDs9aZTbcVy9P5At/6nzEj0xAhZgvBWq0iu1KF/hyM=; b=IUwmo04c2KtZBH+nWMn8JfpNjWg8HnP3aEAhlJUwZQrJrTQLiYhXmZKpoz/ZLxnrLi ERLfk/qMcN19k8cIvsrFwWP2YyeJy9SZvtHC82nPzLiBpyNk/4pbM96Gm193y6VPhzBZ gUmdK/XjY26NGohTOZ25f3JCD2b6q3wrPOr+GBlIV854oDK8Nz4Eg2luUvEQ9FlO7Rzg I3APYIdG5lwwxbPbsNiFGFXYRJUs/LhkexydM5+qPMjdxjZp15xD4+Lpn8zAzVs3zfQI d1PUV56pZY4HFMJNl0XzKme5Y2fwJ555161DuI9tTjbRV8Yq3uqaR/8zqXNlkeCSwUJv PL2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=eJM1DtC5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t18si15531458plo.328.2019.07.25.11.46.19; Thu, 25 Jul 2019 11:46:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=eJM1DtC5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726400AbfGYSoE (ORCPT + 99 others); Thu, 25 Jul 2019 14:44:04 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:33048 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726086AbfGYSoE (ORCPT ); Thu, 25 Jul 2019 14:44:04 -0400 Received: by mail-pf1-f195.google.com with SMTP id g2so23195268pfq.0 for ; Thu, 25 Jul 2019 11:44:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bPDs9aZTbcVy9P5At/6nzEj0xAhZgvBWq0iu1KF/hyM=; b=eJM1DtC5tc7N+x3bUDdfU3a6aCPNIKs5Ea/Z/fUOdrJjaLs5VmctkQkOfWa5ycQmWy T5eFh5Pv2d56b42dZkAQcWzM/FzmI6m7UaLTTYpXxUJOE1+rTja/64NwSq+YXHDtkVhj UoDfaFAKiw0bjo8MjuKksMwuHF6M1UgGh6b4OyJFpU/RGI7iV6615GCVMwt+fzzREu+q F0x/mjJzP3lhCGVKSOcsUzuZMTn3ZbHwy9xR6IjoO9VTr2CUPe9CEu3D+nWk8iwRAWbP 43C4KdlQ8/ROPCjSjhtS41Jp0XOnZKjzAHMrAVWtaOzkiLvj7kzrci0zbLlYjWwWycJJ wfYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bPDs9aZTbcVy9P5At/6nzEj0xAhZgvBWq0iu1KF/hyM=; b=FkrF/QAha587nG1K50Q1Et9ffyTxjH319Fk1K/Tk+bVQsUScCtzHGT7giFY3kMmAaV wfhQNNv85PfYgwuV0p/P9JeY/t5C8UVtPCjB1qbhzgmn7dZHsP6bsC6lBMQlTN2+IDuI RuZRMmw8Kfg+KaPjwe/OZdt9HTI9gAqevjdRe8TZxFY3mHFIssEvQe9hsf/rRTVGYK9b J5WcLej8eW0T3t/EAAVUqoH0Rui3mW/aitOmg1QLHYk9bHYapiVBe6KloVCVF/xN3OJO l4ObojkScQQyJq/aUjbxm9EaQqR9C4MHP9BMU2XiPHYIqZWsp0vSCyW+l7xTQH6JJxnp mlhw== X-Gm-Message-State: APjAAAV9fGxDp+WXBOViD/3fbXGeMbQiJHsig5HzG05/N8XMMkpII5YG Mv5TP+VpEcgDkak7WlliRjY= X-Received: by 2002:a63:4522:: with SMTP id s34mr86869675pga.362.1564080243954; Thu, 25 Jul 2019 11:44:03 -0700 (PDT) Received: from localhost.localdomain.localdomain ([2408:823c:c11:624:b8c3:8577:bf2f:3]) by smtp.gmail.com with ESMTPSA id w3sm43818257pgl.31.2019.07.25.11.43.56 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 25 Jul 2019 11:44:03 -0700 (PDT) From: Pengfei Li To: akpm@linux-foundation.org Cc: mgorman@techsingularity.net, mhocko@suse.com, vbabka@suse.cz, cai@lca.pw, aryabinin@virtuozzo.com, osalvador@suse.de, rostedt@goodmis.org, mingo@redhat.com, pavel.tatashin@microsoft.com, rppt@linux.ibm.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Pengfei Li Subject: [PATCH 04/10] mm/page_alloc: remove never used "order" in alloc_contig_range() Date: Fri, 26 Jul 2019 02:42:47 +0800 Message-Id: <20190725184253.21160-5-lpf.vector@gmail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190725184253.21160-1-lpf.vector@gmail.com> References: <20190725184253.21160-1-lpf.vector@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The "order" will never be used in alloc_contig_range(), and "order" is a negative number is very strange. So just remove it. Signed-off-by: Pengfei Li --- mm/page_alloc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 7d47af09461f..6208ebfac980 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -8347,7 +8347,6 @@ int alloc_contig_range(unsigned long start, unsigned long end, struct compact_control cc = { .nr_migratepages = 0, - .order = -1, .zone = page_zone(pfn_to_page(start)), .mode = MIGRATE_SYNC, .ignore_skip_hint = true, -- 2.21.0