Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp11475734ybi; Thu, 25 Jul 2019 17:24:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqydKbK68VmXC3ZqF/1PScpysqTVWioDO/DyANz8kAaE/x7MvmxXLoiOqlNri9su75UZ0+k5 X-Received: by 2002:a65:64cf:: with SMTP id t15mr85917897pgv.88.1564100651392; Thu, 25 Jul 2019 17:24:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564100651; cv=none; d=google.com; s=arc-20160816; b=gEeG6W2epyfl4PBMJC/XBEHzOy6DRhJIJOUqd25PYNQ6ifeWm+0/Jj1GS0SHPn0FgQ /Hf2mT7XIQ6mrPzZKDpqDt9lJgSB1othZz/p+gz4YSGG/RG9tbZrtjuP8uQJ0GWsrfh3 xVJg+52vSIoFeBulZf7sPpVs0PjyBPMf0VMaxDEveOouvcJfwm8x9ybRhK9fukeAESa7 Ikj14GELplDf6O62JvjE+uBnxMUttFPFwIpV+4xWQylMiZ1WU9lfQYzeb5y6uJHz3PQJ p1Ybz9HYL1n6fYFXYe4Twm4IqXWNUXy5S+B/2D/kgXP8BtikmhB/dNlo/Vixo4bZwRU7 iROg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=koM9R1X60Uky8CY3lDy73x9/oBDuC0U0y+hjPBDv3B8=; b=t2wAKtgjAh+JwxcZ3BFaHmbFCx7edXByNJvJj8+TA5K4II3Yw+exkrfF0u9/DC4Lx3 gDjjWRuICSgVkfB80MoQgy8dTvf6fy0HgR26EsmxPtz0ygtl7/P/LHWsPXJc6D1CVs25 /RTjdFy9PnfxvUr+48pcukDSu+b6VUeNryufEns8vUKWsLups0r0uovMVY2fy7k0OIWR UedWKyXFzt8MjpK3SQjVHE04TqIuAMSCJPXzokSpOFXZ9R4rC9654dEXB/t3/h0BRHTB H/ElecCCEE/3CvCSUmckXDNn3K8NM6+edGyoBOTKinst5XQ2dx5YGe+r0aQGeNwumao2 U2Nw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JXUuKhtG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 66si18950700pld.6.2019.07.25.17.23.56; Thu, 25 Jul 2019 17:24:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JXUuKhtG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727171AbfGZAWG (ORCPT + 99 others); Thu, 25 Jul 2019 20:22:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:46646 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726942AbfGZAWG (ORCPT ); Thu, 25 Jul 2019 20:22:06 -0400 Received: from localhost.localdomain (c-73-223-200-170.hsd1.ca.comcast.net [73.223.200.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A24C1218DA; Fri, 26 Jul 2019 00:22:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564100525; bh=qbBj7OK+JBPLYP01N8KWTpFy7N4FUHl1S5D2xuDD1KQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JXUuKhtGgGtb669YOp2QBlD7LmIXEQ/hub49Erq+Aqc6px2gPik+lP5Mhna2fbDsd 8DaDglRcUJDAE+XHGuLXgtEZjs/EEJ4FAtz/+ZdQGPGGxNrIKNXZDrVEY0FZhPIdIp bymJetball5a78cnNGqvFLbWjmZcxo+JR+tG4MBY= Date: Thu, 25 Jul 2019 17:22:05 -0700 From: Andrew Morton To: Matteo Croce Cc: Joe Perches , LKML , Andy Whitcroft Subject: Re: [PATCH v2] checkpatch.pl: warn on invalid commit id Message-Id: <20190725172205.6d5a3b5896e64f88116c0b21@linux-foundation.org> In-Reply-To: References: <20190711001640.13398-1-mcroce@redhat.com> <20190724200707.2ba88e3affd73de1ce64fab6@linux-foundation.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 Jul 2019 11:26:04 +0200 Matteo Croce wrote: > On Thu, Jul 25, 2019 at 5:07 AM Andrew Morton wrote: > > What does it do if we're not operating in a git directory? For example, > > I work in /usr/src/25 and my git repo is in ../git26. > > > > If .git is not found, the check is disabled We could permit user to set an environment variable to tell checkpatch where the kernel git tree resides. > > Also, what happens relatively often is that someone quotes a linux-next > > or long-term-stable hash. If the user has those trees in the git repo, > > I assume they won't be informed of the inappropriate hash? > > > > In this case it won't warn, but this should not be a problem, as the > hash doesn't change following a merge. > The problem is just if the other tree gets rebased, or if the other > tree gets never merged, e.g. stable/linux-* linux-next patches get rebased quite often. I guess this is acceptable - failing to warn about an error is better than warning about not-an-error.