Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp11501461ybi; Thu, 25 Jul 2019 17:58:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqzy8PuyaZ1xG/ItCNFLttBZ4VfWcRq1KdB3uB0oVQyXn0AvmvPx+Tm9nAp54U6M8ggqmyUF X-Received: by 2002:a62:ae02:: with SMTP id q2mr18925569pff.1.1564102717283; Thu, 25 Jul 2019 17:58:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564102717; cv=none; d=google.com; s=arc-20160816; b=py58kA8EpixgHBGa0SjpVTXcRvuf+tCIOGrz5SCIps+aA8c75o6ptEVDrqE7HB/jYz mVuj8lv6mmkz5LZIWrP1cwggTwo8XDQgsoBg9UIUclzHn0xgfdDVzowlkwPCWFxolRMV GVoRsJkTWcYPMv1wBGx6yF7Fq4HrAyKdy9aSTeF/9AhGYDJFLrRkN/2EMcF4bSPK+t1u sgMCK3xYsQo6KjAoy3L1lw+0t5aRJh+5xWUR1cH2XwuFDuYr/ZXR8iGczjXyyxvYEUs9 GbZeCx4R06Lei6SuHBLmdc83eDteZEd4imxsjqyYqa8SrHPL2EMN+f81U0Fn64OOSdDm mykA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=lqUzAiwpe+982ZtFxY47KqhZ67cib6rgfM9SitBt2Vw=; b=VmtFlpY5fY+9un5UOm1rMtAjtQMCfmDXMuWQrHmeBTLmvPflQ1d8Ebz51HG2a4Kylj Wa56SDeZuegqKkXN01R0GtpWaXh50vM5N2l2dnoJ0w2wE6uOB0WVLWsaioraof3q9K0L gEzJ1j8K2chHbNiSdGikrn0mwgHcYiTJBqbpBQzlPttzejPeXUrK5SPYBgBaETKCVgbT 8VMvLiMjcA6Q1SUPMQVdn79pI4xjyeaK/7TZB5jvA6TGQ3JpVyXOPKz6OSuHyOvqcckI wDJkjkd9rluMLEvI5102rZcZ9gS/Clla6MZNKBkDDSA6KgHNNHZZgkx/fKpH1PqjqpGU vgXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=L5uUd3Gh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v13si19745662pfe.217.2019.07.25.17.58.21; Thu, 25 Jul 2019 17:58:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=L5uUd3Gh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727101AbfGZAzg (ORCPT + 99 others); Thu, 25 Jul 2019 20:55:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:49872 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725819AbfGZAzg (ORCPT ); Thu, 25 Jul 2019 20:55:36 -0400 Received: from localhost.localdomain (c-73-223-200-170.hsd1.ca.comcast.net [73.223.200.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DC8ED2238C; Fri, 26 Jul 2019 00:55:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564102535; bh=o4hVED1DnXPhi52FO0wtBGwbvoqHLkWraSNdRFbEhmA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=L5uUd3GhpWzXG8NZ5VAfPLAogGQnqmrSDtJ2WoGzo4kODsjexGjl2plEX8UF4CwuW oU0gaoBumTXP+a5Fx+/RYg+bzmTeV7Qn9p0BT20Auw6fp70moUvLzgdHDbXgB4eoWy x3mw2X6mVGMx2Db5jEYPWqqxyerg3w7sEzNMLtn4= Date: Thu, 25 Jul 2019 17:55:33 -0700 From: Andrew Morton To: Kees Cook Cc: Alexandre Ghiti , Albert Ou , Catalin Marinas , Palmer Dabbelt , Will Deacon , Russell King , Ralf Baechle , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Paul Burton , Alexander Viro , James Hogan , linux-fsdevel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-mips@vger.kernel.org, Christoph Hellwig , linux-arm-kernel@lists.infradead.org, Luis Chamberlain Subject: Re: [PATCH REBASE v4 11/14] mips: Adjust brk randomization offset to fit generic version Message-Id: <20190725175533.f9fcc5139a9575560be7f679@linux-foundation.org> In-Reply-To: <201907251259.09E0101@keescook> References: <20190724055850.6232-1-alex@ghiti.fr> <20190724055850.6232-12-alex@ghiti.fr> <1ba4061a-c026-3b9e-cd91-3ed3a26fce1b@ghiti.fr> <201907251259.09E0101@keescook> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 Jul 2019 13:00:33 -0700 Kees Cook wrote: > > I have just noticed that this patch is wrong, do you want me to send > > another version of the entire series or is the following diff enough ? > > This mistake gets fixed anyway in patch 13/14 when it gets merged with the > > generic version. > > While I can't speak for Andrew, I'd say, since you've got Paul and > Luis's Acks to add now, I'd say go ahead and respin with the fix and the > Acks added. Yes please. After attending to Paul's questions on [14/14].