Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp11533808ybi; Thu, 25 Jul 2019 18:39:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqz1aKvDfQ6HhALOQUUUH0C1PmEeaQbNLn2Nvo2iE/e8K/p7Ve1MLSU/aoXii171VHyIHgB5 X-Received: by 2002:a17:90a:380d:: with SMTP id w13mr93719874pjb.138.1564105144712; Thu, 25 Jul 2019 18:39:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564105144; cv=none; d=google.com; s=arc-20160816; b=DRojpcLwPOqwTBRS1Y0kDK7WNCZuL43dGD0CYfzFurYqMPxS++FsS9PRCc/5VduYc8 bP6fA5wJ3H1rz73pitSrL2fY1P61upjvLsLjgo7tozjefTaTf73hE+WR0hK1HyomT7Uv HpTHMoAsCQeYzjcIZDhKFqNhyAbSNKbla0O7AN4hung1xG7FF9+g7lzo+TYnuJG+QEB3 U/IwXfCRYzeIC+NOyatu+K8jvwDpjAjRdoFzQsnbEFyx1SnZ+8jMrvURcCtERE/RC96w 71hW5I0NLPHlGcWU/hcg2/QQ2FpRuTJtEnlabARVx5tS1RbmrlABHB99kBeMOwSOYKCB qL1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=+AlgjhwapGchy054D+vEOYsYVmY52iPTbbo6aBHZN3s=; b=0oIApd9axAGYyD52/v5kF2Tw/wnQ90tt7wmvaE5u3Dsz/PjGu2QvYb54RK1AZkbp8b YtrDeVPh7YpD4x0NX+v6eXEyqcDFenNpE7yPEevyv6P38pwjHXndntGcXfsreLQ+ZanP 0BRf3pe8BLXC1x4uIdc3b4wz9ccjfEPXaT1M27JvvgD5PDfsa7ytEk2WtfcfZKK0bx09 m6IafkoAx7X4zbON+Hj/ijCmOy4yyQrN5NzmGbY5JoniAVhxqhox55OflKSgPL5j6Tce nLfblpBGYYnP6DGabqVEKpoaRimklgWqNGNOu+/BHxApkyMTk7OqAktjsOG24K+wGhoZ 8v7g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m71si16609733pjb.26.2019.07.25.18.38.47; Thu, 25 Jul 2019 18:39:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725945AbfGZBiM (ORCPT + 99 others); Thu, 25 Jul 2019 21:38:12 -0400 Received: from mga05.intel.com ([192.55.52.43]:45676 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725852AbfGZBiM (ORCPT ); Thu, 25 Jul 2019 21:38:12 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jul 2019 18:38:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,308,1559545200"; d="scan'208";a="254171936" Received: from chenyu-office.sh.intel.com ([10.239.158.163]) by orsmga001.jf.intel.com with ESMTP; 25 Jul 2019 18:38:09 -0700 Date: Fri, 26 Jul 2019 09:48:52 +0800 From: Yu Chen To: Maximilian Luz Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, platform-driver-x86@vger.kernel.org, Dmitry Torokhov , Hans de Goede , Darren Hart , Andy Shevchenko , Benjamin Tissoires Subject: Re: [PATCH v3 1/2] platform/x86: surfacepro3_button: Fix device check Message-ID: <20190726014851.GA15416@chenyu-office.sh.intel.com> References: <20190720150511.95076-1-luzmaximilian@gmail.com> <20190720150511.95076-2-luzmaximilian@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190720150511.95076-2-luzmaximilian@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 20, 2019 at 05:05:10PM +0200, Maximilian Luz wrote: > Do not use the surfacepro3_button driver on newer Microsoft Surface > models, only use it on the Surface Pro 3 and 4. Newer models (5th, 6th > and possibly future generations) use the same device as the Surface Pro > 4 to represent their volume and power buttons (MSHW0040), but their > actual implementation is significantly different. This patch ensures > that the surfacepro3_button driver is only used on the Pro 3 and 4 > models, allowing a different driver to bind on other models. > > Signed-off-by: Maximilian Luz > --- Acked-by: Chen Yu Thanks, Chenyu