Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp11586534ybi; Thu, 25 Jul 2019 19:49:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqwrpXUCHWlfAwJQUgrfHIVtr8wp4q+pdH+xgcFLrXD1EKPYBa7JkD/M7ctAhORQOMstmQJZ X-Received: by 2002:a17:902:724a:: with SMTP id c10mr87743420pll.298.1564109398097; Thu, 25 Jul 2019 19:49:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564109398; cv=none; d=google.com; s=arc-20160816; b=c0wr4kGccdr7o+qN6oU6XUirHg7Ny8MvKhb8K814KtZ+RRpNPGRwNYsc9YdTHnLLy8 gHj8iL27QdhO+R0+9adIQ37rD7BtYHNdloV84uUEqKesN3nd+Du0+3o1QtPSpeWx6xGZ lU/4ZCIcjgOnAe6kmM7g4SPbsrIYT036T6c/Ho4028vvxi0aX8gmDdsrTuMdlTM3xH1o 1THk6P8peFOA+2YS4+dMLUe9zvQcggoflEgo9CDTDkxLWKar4ONgO9QCdNsNpg22hJ8L ARwOdIRqjBio5rtbZBcSTJ4cSfg3hTGOCUHZ2YqOLzRMA51rHqQ3gj7d2FcfTNlh6IBy tvTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject; bh=p8yp6HK/fgXLsYd0J7q8bCMd264Q+/kD5hozam/cVz4=; b=ckNg9UQuoD0Y10FLwRxozV8AK7y72pcu+qgRZWOyt0FNB2MB4TfJq5Sth3FIROxTsM gXcahDJDN5NQOrFZ0wXaVYug1+itxQn5AdoaNhlvwBsn+zM/WD0RlVARA0NrLYff2Noj uJPwVzhbELntm/5MaZkIyGvsfKx8IMSHgUydfYxbOb4lFNg1SV+mhKbWXAdV1p2irDKo 8cPVFDFvzDFQGhh0Uth2bZouBtNDuPKOzrROomsXYpf02ebgpsH9IRsl0Ib6t3N6uIU4 o5QPtBdkVPCqgH8jZN65rsKPsS14j/wht4BCZMxQanLY0N/6PvFrhWrVmgX/Kgfmy1Sr H7kA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a13si18277615pgt.217.2019.07.25.19.49.43; Thu, 25 Jul 2019 19:49:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726312AbfGZCrQ (ORCPT + 99 others); Thu, 25 Jul 2019 22:47:16 -0400 Received: from anchovy1.45ru.net.au ([203.30.46.145]:53621 "EHLO anchovy1.45ru.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726283AbfGZCrQ (ORCPT ); Thu, 25 Jul 2019 22:47:16 -0400 Received: (qmail 20528 invoked by uid 5089); 26 Jul 2019 02:40:33 -0000 Received: by simscan 1.2.0 ppid: 20427, pid: 20428, t: 0.2285s scanners: regex: 1.2.0 attach: 1.2.0 clamav: 0.88.3/m:40/d:1950 spam: 3.1.4 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on anchovy1 X-Spam-Level: X-Spam-Status: No, score=-0.4 required=6.0 tests=ALL_TRUSTED,AWL autolearn=disabled version=3.4.1 Received: from unknown (HELO ?192.168.0.34?) (rtresidd@electromag.com.au@203.59.235.95) by anchovy1.45ru.net.au with ESMTPA; 26 Jul 2019 02:40:32 -0000 Subject: Re: [PATCH 1/1] power/supply/powersupply_sysfs: Add of_node name to uevent message if available To: David Lechner , sre@kernel.org, enric.balletbo@collabora.com, ncrews@chromium.org, andrew.smirnov@gmail.com, groeck@chromium.org, tglx@linutronix.de, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <1564040858-24202-1-git-send-email-rtresidd@electromag.com.au> <9a10b934-e7f3-c95f-6250-8a857bdfa912@lechnology.com> From: Richard Tresidder Message-ID: <3c372ca4-373d-9c03-8636-a9f065eed577@electromag.com.au> Date: Fri, 26 Jul 2019 10:40:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <9a10b934-e7f3-c95f-6250-8a857bdfa912@lechnology.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-AU Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi David   That it would be. I wasn't aware of that call. I'll give it a crack and send in a new version of the patch. Cheers   Richard Tresidder Richard Tresidder On 25/07/2019 10:08 pm, David Lechner wrote: > On 7/25/19 2:47 AM, Richard Tresidder wrote: >> If the of_node name of the supply is available from the devicetree >> binding >> then include it under the var POWER_SUPPLY_OF_NODE_NAME. >> This helps where a consistent name is known via the device tree binding >> but it is hard to identify based on the usual enumeration process. >> > > Would it be possible to use of_device_uevent() instead of introducing > a new > property? > > >