Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [BUG] fs: f2fs: Possible null-pointer dereferences in
 update_general_status()
To:     Jia-Ju Bai <baijiaju1990@gmail.com>, <jaegeuk@kernel.org>
CC:     <linux-f2fs-devel@lists.sourceforge.net>,
        <linux-kernel@vger.kernel.org>
References: <f577be2f-fc2f-9ef8-2c6c-9c247123b1ad@gmail.com>
From:   Chao Yu <yuchao0@huawei.com>
Message-ID: <2d66cd56-eccf-9086-c5db-118acce717a6@huawei.com>
Date:   Fri, 26 Jul 2019 11:19:41 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <f577be2f-fc2f-9ef8-2c6c-9c247123b1ad@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Jiaju,

Thanks for the report, I checked the code, and found it doesn't need to check
SM_I(sbi) pointer, this is because in fill_super() and put_super(), we will call
f2fs_destroy_stats() in prior to f2fs_destroy_segment_manager(), so if current
sbi can still be visited in global stat list, SM_I(sbi) should be released yet.
So anyway, let's remove unneeded check in line 70/78. :)

Thanks,

On 2019/7/25 17:49, Jia-Ju Bai wrote:
> In update_general_status(), there are two if statements to
> check whether SM_I(sbi) is NULL:
> LINE 70:     if (SM_I(sbi) && SM_I(sbi)->fcc_info)
> LINE 78:     if (SM_I(sbi) && SM_I(sbi)->dcc_info)
> 
> When SM_I(sbi) is NULL, it is used at some places, such as:
> LINE 88: reserved_segments(sbi)
>                    return SM_I(sbi)->reserved_segments;
> LINE 89: overprovision_segments(sbi)
>                    return SM_I(sbi)->ovp_segments;
> LINE 112: MAIN_SEGS(sbi)
>                      (SM_I(sbi)->main_segments)
> 
> Thus, possible null-pointer dereferences may occur.
> 
> These bugs are found by a static analysis tool STCheck written by us.
> 
> I do not know how to correctly fix these bugs, so I only report them.
> 
> 
> Best wishes,
> Jia-Ju Bai
> .
>