Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp11641741ybi; Thu, 25 Jul 2019 20:56:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqxa4zH3m4nNmLIbklbVJlIR0tDvbirvVCmRYhaFZhdmOZteQiDA9g8nSVpEh5b2Bf+7S80c X-Received: by 2002:a17:902:5a2:: with SMTP id f31mr92556638plf.72.1564113416915; Thu, 25 Jul 2019 20:56:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564113416; cv=none; d=google.com; s=arc-20160816; b=AWSbgObIMBj/OQd3HY/VpTX8K7gGYupCSLhyhya1kBbsXM16XSraADzNCVHGhRmQIY kB60g4QICpiI6yLO6NlYfYQsjGTujKALVkcarrlxNTZzf9wHxOPXp+3zACg08cNvmVH4 gSbShYIhejLtUbR7OFCwbq6x6ccu0dlnB3bXFGuCi+Y0llgUyg2eFJptzS+tlH3B+LS8 q5ZGr/4WEFLjIxdw+/Mh2+EOBoTSEvzssLFDL0DT+YWUdCsIHZGjg5OMUer8LvTbMRGl 6eh2C5Vjn6g9audgnsW2kbc2P79x+jD3nG7ksHPvsPC1q8cjQ+mzgGVUwANAoP/1+znD hdQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=EICrneh/VO6p1kq0HUo8iuif11N4YX/X7w+z9U1GIfs=; b=U9GBj8AbtDAv8fR3N7UYWwByvIZwzLLpKBqWoesByUfv+X6ka7ZmEYSB60od+vHIYG yiQAECPixk9Hgr6lVP3rIeChUHqgcj6V5U7ELo1eDncbJLDxgJi4Ujl+Nra5fwaAGfty yB2oXivKVoH0cffPNnQV5K58G6APmHnOkBiKM0WRO962vC0ZWFeNauIF9SskU/HjZpSq SfDzRhvu6OAOq++8UkfTXdV7/0HYvQh1z3sZrBChAgkaADyWWFnRVrE7v0z/ztHtxCYd KQQHGYHcG74CIvUILeT4IMFhT01AUJpma3DPTa+wCWcQTZSkC9iRfGWcFyD4Lrp6XSYd uZXw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s62si16233698pjc.75.2019.07.25.20.56.29; Thu, 25 Jul 2019 20:56:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725978AbfGZDzd (ORCPT + 99 others); Thu, 25 Jul 2019 23:55:33 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:2764 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725842AbfGZDzc (ORCPT ); Thu, 25 Jul 2019 23:55:32 -0400 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 9BD8BF112BB1844FE3BE; Fri, 26 Jul 2019 11:55:30 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.211) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 26 Jul 2019 11:55:26 +0800 Subject: Re: [PATCH] fs: f2fs: Remove unnecessary checks of SM_I(sbi) in update_general_status() To: Jia-Ju Bai , CC: , References: <20190726034512.32478-1-baijiaju1990@gmail.com> From: Chao Yu Message-ID: <039c2c03-51eb-0666-bfac-696fb678a733@huawei.com> Date: Fri, 26 Jul 2019 11:55:26 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190726034512.32478-1-baijiaju1990@gmail.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/7/26 11:45, Jia-Ju Bai wrote: > In fill_super() and put_super(), f2fs_destroy_stats() is called > in prior to f2fs_destroy_segment_manager(), so if current > sbi can still be visited in global stat list, SM_I(sbi) should be > released yet. > For this reason, SM_I(sbi) does not need to be checked in > update_general_status(). > Thank Chao Yu for advice. > > Signed-off-by: Jia-Ju Bai Reviewed-by: Chao Yu Thanks,