Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1564121417-29375-1-git-send-email-wanpengli@tencent.com>
In-Reply-To: <1564121417-29375-1-git-send-email-wanpengli@tencent.com>
From:   Wanpeng Li <kernellwp@gmail.com>
Date:   Fri, 26 Jul 2019 14:16:11 +0800
Message-ID: <CANRm+CzTJ6dCv=NSHLGV-uWdaES2F0T7PXgu0LXXEsBCJ8mxEA@mail.gmail.com>
Subject: Re: [PATCH] KVM: X86: Use IPI shorthands in kvm guest when support
To:     LKML <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Sean Christopherson <sean.j.christopherson@intel.com>,
        Nadav Amit <namit@vmware.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 26 Jul 2019 at 14:10, Wanpeng Li <kernellwp@gmail.com> wrote:
>
> From: Wanpeng Li <wanpengli@tencent.com>
>
> IPI shorthand is supported now by linux apic/x2apic driver, switch to
> IPI shorthand for all excluding self and all including self destination
> shorthand in kvm guest, to avoid splitting the target mask into serveral
> PV IPI hypercalls.
>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Radim Kr=C4=8Dm=C3=A1=C5=99 <rkrcmar@redhat.com>
> Cc: Sean Christopherson <sean.j.christopherson@intel.com>
> Cc: Nadav Amit <namit@vmware.com>
> Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
> ---
> Note: rebase against tip tree's x86/apic branch
>
>  arch/x86/kernel/kvm.c | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
> index b7f34fe..87b73b8 100644
> --- a/arch/x86/kernel/kvm.c
> +++ b/arch/x86/kernel/kvm.c
> @@ -34,7 +34,9 @@
>  #include <asm/hypervisor.h>
>  #include <asm/tlb.h>
>
> +static struct apic orig_apic;
>  static int kvmapf =3D 1;
> +DECLARE_STATIC_KEY_FALSE(apic_use_ipi_shorthand);
>
>  static int __init parse_no_kvmapf(char *arg)
>  {
> @@ -507,12 +509,18 @@ static void kvm_send_ipi_mask_allbutself(const stru=
ct cpumask *mask, int vector)
>
>  static void kvm_send_ipi_allbutself(int vector)
>  {
> -       kvm_send_ipi_mask_allbutself(cpu_online_mask, vector);
> +       if (static_branch_likely(&apic_use_ipi_shorthand))
> +               orig_apic.send_IPI_allbutself(vector);
> +       else
> +               kvm_send_ipi_mask_allbutself(cpu_online_mask, vector);
>  }
>
>  static void kvm_send_ipi_all(int vector)
>  {
> -       __send_ipi_mask(cpu_online_mask, vector);
> +       if (static_branch_likely(&apic_use_ipi_shorthand))
> +               orig_apic.send_IPI_allbutself(vector);

Make a mistake here, just resend the patch.

> +       else
> +               __send_ipi_mask(cpu_online_mask, vector);
>  }
>
>  /*
> @@ -520,6 +528,8 @@ static void kvm_send_ipi_all(int vector)
>   */
>  static void kvm_setup_pv_ipi(void)
>  {
> +       orig_apic =3D *apic;
> +
>         apic->send_IPI_mask =3D kvm_send_ipi_mask;
>         apic->send_IPI_mask_allbutself =3D kvm_send_ipi_mask_allbutself;
>         apic->send_IPI_allbutself =3D kvm_send_ipi_allbutself;
> --
> 2.7.4
>