DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=VbIxbY8H+OfiFa2TBp2Ny++3b5aP4zIeCyKr+Spyo1AOTELJx18yqZV0PsQs1Li87e30ZzN6auxhzGdH8wSDHzKu1WYcwIr9QH51te80G5eOHgW5JexyQt9psNsltBhAVwSv93E7i/fw1nPhJR3X61/UgOrhHc+zS+uK2msPlbQ=
Message-ID: <58cb370e0512070744w6a820f72h853783c851b580c4@mail.gmail.com>
Date: Wed, 7 Dec 2005 16:44:39 +0100
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: [RFC]add ACPI hooks for IDE suspend/resume
Cc: Shaohua Li <shaohua.li@intel.com>, linux-ide <linux-ide@vger.kernel.org>,
       lkml <linux-kernel@vger.kernel.org>, pavel <pavel@ucw.cz>,
       Len Brown <len.brown@intel.com>, akpm <akpm@osdl.org>
In-Reply-To: <20051207145811.GA17119@srcf.ucam.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
Content-Disposition: inline
References: <1133849404.3026.10.camel@sli10-mobl.sh.intel.com>
	 <20051206222001.GA14171@srcf.ucam.org>
	 <58cb370e0512070017u606ee22fse207b9a859856dd4@mail.gmail.com>
	 <20051207131454.GA16558@srcf.ucam.org>
	 <58cb370e0512070619k17022317v8e871dc3f9cafb9@mail.gmail.com>
	 <20051207143337.GA16938@srcf.ucam.org>
	 <58cb370e0512070645o78569e82y63483a9ae5511f52@mail.gmail.com>
	 <20051207145811.GA17119@srcf.ucam.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1073
Lines: 22

On 12/7/05, Matthew Garrett <mjg59@srcf.ucam.org> wrote:
> On Wed, Dec 07, 2005 at 03:45:19PM +0100, Bartlomiej Zolnierkiewicz wrote:
>
> > OK, I understand it now - when using 'ide-generic' host driver for IDE
> > PCI device, resume fails (for obvious reason - IDE PCI device is not
> > re-configured) and this patch fixes it through using ACPI methods.
>
> Unfortunately not - you get the same failure with piix (am I right in
> thinking that piix doesn't have any suspend/resume methods beyond the
> generic PCI ones? I'm afraid I don't have enough knowledge of the IDE
> layer to know if there's some other magic that calls an ide-specific
> resume function in it...)

PCI device will get re-configured indirectly by ide_complete_power_step()
which is calling hwif->ide_dma_check() (piix_config_drive_xfer_rate).

Bartlomiej
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/