Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: TempError (protection.outlook.com: error in processing during
 lookup of arm.com: DNS Timeout)
From:   "Lowry Li (Arm Technology China)" <Lowry.Li@arm.com>
To:     Liviu Dudau <Liviu.Dudau@arm.com>,
        "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>,
        "maarten.lankhorst@linux.intel.com" 
        <maarten.lankhorst@linux.intel.com>,
        "seanpaul@chromium.org" <seanpaul@chromium.org>,
        "airlied@linux.ie" <airlied@linux.ie>,
        Brian Starkey <Brian.Starkey@arm.com>
CC:     "Julien Yin (Arm Technology China)" <Julien.Yin@arm.com>,
        "Jonathan Chai (Arm Technology China)" <Jonathan.Chai@arm.com>,
        Ayan Halder <Ayan.Halder@arm.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        nd <nd@arm.com>
Subject: [PATCH] drm/komeda: Adds more check in mode_valid
Thread-Topic: [PATCH] drm/komeda: Adds more check in mode_valid
Thread-Index: AQHVQ4j/fedIk6fUkkilpyBPPcwKlQ==
Date:   Fri, 26 Jul 2019 08:06:16 +0000
Message-ID: <1564128364-23055-1-git-send-email-lowry.li@arm.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
Authentication-Results-Original: spf=none (sender IP is )
 smtp.mailfrom=Lowry.Li@arm.com; 
x-ms-exchange-messagesentrepresentingtype: 1
x-mailer: git-send-email 1.9.1
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-Correlation-Id: c5464837-af6a-4867-a032-08d711a02990
X-MS-Office365-Filtering-HT: Tenant
X-Microsoft-Antispam-Untrusted: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020);SRVR:VI1PR08MB2941;
X-MS-TrafficTypeDiagnostic: VI1PR08MB2941:|AM5PR0801MB1844:
X-Microsoft-Antispam-PRVS: <AM5PR0801MB18447784BCE814F3AC9687C19FC00@AM5PR0801MB1844.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
x-ms-oob-tlc-oobclassifiers: OLM:2449;OLM:2449;
x-forefront-prvs: 01106E96F6
X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(346002)(376002)(366004)(396003)(39860400002)(136003)(199004)(189003)(50226002)(5660300002)(14454004)(486006)(476003)(54906003)(110136005)(256004)(2616005)(305945005)(6636002)(81166006)(14444005)(81156014)(186003)(68736007)(26005)(478600001)(2501003)(6436002)(71190400001)(52116002)(71200400001)(6486002)(66066001)(4326008)(36756003)(25786009)(53936002)(2906002)(316002)(6512007)(99286004)(3846002)(8936002)(102836004)(7736002)(55236004)(6116002)(2201001)(386003)(6506007)(86362001)(66946007)(66556008)(64756008)(66446008)(66476007)(8676002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR08MB2941;H:VI1PR08MB5488.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: arm.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Message-Info-Original: lswQ9Kg3RaILZGa9HKn06dhjVl0rXyobOsRSKiqTUGr4Lhsl6fTyVJTNE8Jmwh0tDX1Xl1KHKC7yEaE8XGq19fZ+DqLV3h/VlBt0uK2V0FxCf8IpjsUlhm9vdsFwIrtVse5jTGZdd7lTQrM45HQ1W0QUGJRYkzHFYgFan6UzkSG9GCfs+3ZZot+HXhPcYnZjxr5xnBdnPTZtqf3BELxNguPFe0JSayes9YX+gAe7OOMWULmu4aomHqEnaE4R1IHAy44+9a+H9/LXaYiJwyrrB59oNOxHs0Q91WRzBQ5Oxap/6HNIFgjA/0tN/d88uDZU1N2Cm3CUkFYadwdzNVbmwWxXLKHUOB6tjJJSWyppt5TdzFeQJrzlG7YwjsEFQCOSW/QsjGBNKx5JcTvr8Fm2S3UJwBuahBYPxiVjCRZTzW4=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2941
Original-Authentication-Results: spf=none (sender IP is )
 smtp.mailfrom=Lowry.Li@arm.com; 
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT061.eop-EUR03.prod.protection.outlook.com
X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(39860400002)(376002)(346002)(396003)(136003)(2980300002)(199004)(189003)(316002)(8746002)(102836004)(305945005)(8676002)(8936002)(486006)(81156014)(14454004)(386003)(2201001)(50466002)(6506007)(6636002)(478600001)(2616005)(26826003)(476003)(6116002)(6486002)(14444005)(336012)(63370400001)(50226002)(4326008)(5660300002)(54906003)(23756003)(186003)(110136005)(26005)(2906002)(356004)(66066001)(22756006)(70586007)(7736002)(25786009)(70206006)(47776003)(81166006)(2501003)(36756003)(36906005)(63350400001)(126002)(86362001)(6512007)(3846002)(76130400001)(99286004);DIR:OUT;SFP:1101;SCL:1;SRVR:AM5PR0801MB1844;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:TempError;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;A:1;MX:1;
X-MS-Office365-Filtering-Correlation-Id-Prvs: a1576bdc-ab5f-4370-c210-08d711a021f4
X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(710020)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:AM5PR0801MB1844;
NoDisclaimer: True
X-Forefront-PRVS: 01106E96F6
X-Microsoft-Antispam-Message-Info: B3LD+6ThlDiEWRRD/ly9Hpv4z+UMpwA4PYQpD4NBvwlwSV8MBDsYwGh9pibbDTgHj3EODHJbJvR3iKrD329JhV5LS6MClEOKJU6n9IhGPMDqKQu3F3y5WIoBf9Nry5BangNG2XomaNvisUyJpxB0AXPa460X1udcuHHeTCnF16O46ZwCuJzsZlD1FxtiEEk9P7TX6VckuTm6pwenEEZ/0W0+wEC6oozBMC3Yq+e6B5Gm9vPhxPhYivQdVq8yq+UzAze6eCP1lFnnsWHc/b/RXIYOHrNaCJVmoBvUoYWDTo2hCn14OjF/IlHea8vT9ic8uwDtPSvSJodiQFbGSLDkxSffDyYuEXx9YVs81AVnqsvYFnNx3oascQys3OwvH8peV4p6H/hgNiGTkodU6wLGuFrByY4alX+npgtSBdlum6Q=
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2019 08:06:28.4677
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c5464837-af6a-4867-a032-08d711a02990
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1844
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This patch adds the checks for vrefresh, crtc_hdisplay and crtc_vdisplay.

Signed-off-by: Lowry Li (Arm Technology China) <lowry.li@arm.com>
---
 drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 28 ++++++++++++++++++++=
+++-
 1 file changed, 27 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c b/drivers/gpu=
/drm/arm/display/komeda/komeda_crtc.c
index 2fed1f6..017f6b6 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c
@@ -403,11 +403,37 @@ unsigned long komeda_crtc_get_aclk(struct komeda_crtc=
_state *kcrtc_st)
 	struct komeda_dev *mdev =3D crtc->dev->dev_private;
 	struct komeda_crtc *kcrtc =3D to_kcrtc(crtc);
 	struct komeda_pipeline *master =3D kcrtc->master;
-	unsigned long min_pxlclk, min_aclk;
+	struct komeda_compiz *compiz =3D master->compiz;
+	unsigned long min_pxlclk, min_aclk, delta, full_frame;
+	int hdisplay =3D m->hdisplay;
=20
 	if (m->flags & DRM_MODE_FLAG_INTERLACE)
 		return MODE_NO_INTERLACE;
=20
+	full_frame =3D m->htotal * m->vtotal;
+	delta =3D abs(m->clock * 1000 - m->vrefresh * full_frame);
+	if (m->vrefresh && (delta > full_frame)) {
+		DRM_DEBUG_ATOMIC("mode clock check error!\n");
+		return MODE_CLOCK_RANGE;
+	}
+
+	if (kcrtc->side_by_side)
+		hdisplay /=3D 2;
+
+	if (!in_range(&compiz->hsize, hdisplay)) {
+		DRM_DEBUG_ATOMIC("hdisplay[%u] is out of range[%u, %u]!\n",
+				 hdisplay, compiz->hsize.start,
+				 compiz->hsize.end);
+		return MODE_BAD_HVALUE;
+	}
+
+	if (!in_range(&compiz->vsize, m->vdisplay)) {
+		DRM_DEBUG_ATOMIC("vdisplay[%u] is out of range[%u, %u]!\n",
+				 m->vdisplay, compiz->vsize.start,
+				 compiz->vsize.end);
+		return MODE_BAD_VVALUE;
+	}
+
 	min_pxlclk =3D m->clock * 1000;
 	if (master->dual_link)
 		min_pxlclk /=3D 2;
--=20
1.9.1