Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp11902068ybi; Fri, 26 Jul 2019 01:30:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqz2UGXcKuyWEoNqkZ6Cwys4hpYo9vNS6Q2SAbPHoE4zTT/dqpxgdpMAkdH0oWU19cEBxSlZ X-Received: by 2002:a17:90a:cb81:: with SMTP id a1mr94485602pju.81.1564129828789; Fri, 26 Jul 2019 01:30:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564129828; cv=none; d=google.com; s=arc-20160816; b=pX13DbxZM6b7NA6asdpeZ59cBnQQ45ez4uXU1/WIHeDYu7euPfySCydeaQtpqsgoHN zny28vv75aCdM+ab5I/hq+rsYufXk3awhliHE+vmpW5iXGdRUjUhUii05+aNpqb4epP6 CYeWXxcpYod2anrI4iP74vrd1TfSZTnacPO5ipAuAVU5wl8K+0vKuFR6+Ix6W8leMKFF UreDnlD3CF2VV3EAOGgesHscQZRJYgAdy83RzM0WU7iXwAcWmetzUsKGjU7y/AtJhM9D ElvTqrgk0lxhJTKT6EJBukJKelHJzsCEs3RSdUuirHa9m0UX/0Af3iT0LxhvOqW+cFlV kl8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=XfmY2mmzeRZPawQbT2nkQZgR2wNKecAaJiVCHKRD1mI=; b=zeykpC6IlAif96zKQ8MD6MZSwxAUxudsKo8uz9MbIjqUKkpsTwFHE0CGtvt4XvS81W XRRChriZhVdMNxxq3YHK9CM1w4ot2gf0UPSbGNgWu3+TOlHADUTjp4Dx0NKtYB5UHDh3 ///6K9lZ8Lsjj35glowGppnI4Z47HhpU51diMAHeYv4G9ow3Hyotlsd5PVy1r7M7tnSc pTX5S+SWeXT+2tTEn8XIydDl/jJVEf//XM2EnrP7aySQCEyPRD9ilYSR6PwL6Nm0xXdl kUijGPOxoNYlQ9zRER6/l11peRrILoKuYIe7Ud/wRFlos+eUAB/WF+EkujZqdDcHDrdP 6MBg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l6si20040021pgg.489.2019.07.26.01.30.13; Fri, 26 Jul 2019 01:30:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726203AbfGZI3f (ORCPT + 99 others); Fri, 26 Jul 2019 04:29:35 -0400 Received: from foss.arm.com ([217.140.110.172]:39470 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725815AbfGZI3f (ORCPT ); Fri, 26 Jul 2019 04:29:35 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 69DAF344; Fri, 26 Jul 2019 01:29:34 -0700 (PDT) Received: from e107985-lin.arm.com (e107985-lin.cambridge.arm.com [10.1.194.38]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 402243F71A; Fri, 26 Jul 2019 01:29:33 -0700 (PDT) From: Dietmar Eggemann To: Peter Zijlstra , Ingo Molnar , Juri Lelli Cc: Luca Abeni , Daniel Bristot de Oliveira , Valentin Schneider , Qais Yousef , linux-kernel@vger.kernel.org Subject: [PATCH 0/5] sched/deadline: Fix double accounting in push_dl_task() & some cleanups Date: Fri, 26 Jul 2019 09:27:51 +0100 Message-Id: <20190726082756.5525-1-dietmar.eggemann@arm.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org While running a simple DL workload (1 DL (12000, 100000, 100000) task per CPU) on Arm64 & x86 systems I noticed that some of the SCHED_WARN_ON() in the rq/running bandwidth (bw) functions trigger. Patch 1/5 contains a proposal to fix this. Patch 2-5/5 contain various smaller cleanups I discovered while debugging the actual issue. Dietmar Eggemann (5): sched/deadline: Fix double accounting of rq/running bw in push_dl_task() sched/deadline: Remove unused int flags from __dequeue_task_dl() sched/deadline: Use __sub_running_bw() throughout dl_change_utilization() sched/deadline: Cleanup on_dl_rq() handling sched/deadline: Use return value of SCHED_WARN_ON() in bw accounting kernel/sched/deadline.c | 28 ++++++++++------------------ 1 file changed, 10 insertions(+), 18 deletions(-) -- 2.17.1