Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190725063644.5982-1-gomonovych@gmail.com> <CAJKOXPd1sL_GqajZN6YAz+frapt2wCCW9WPvF8eYGsZ9iOdxsg@mail.gmail.com>
In-Reply-To: <CAJKOXPd1sL_GqajZN6YAz+frapt2wCCW9WPvF8eYGsZ9iOdxsg@mail.gmail.com>
From:   "Gomonovych, Vasyl" <gomonovych@gmail.com>
Date:   Fri, 26 Jul 2019 10:37:49 +0200
Message-ID: <CAHYXAnKKi6Uf2i0_Q8xGHU5DV63hw0Sa5YEPB12xBz0BWRN86Q@mail.gmail.com>
Subject: Re: [PATCH] extcon: max77693: Add extra IRQF_ONESHOT
To:     Krzysztof Kozlowski <krzk@kernel.org>
Cc:     Chanwoo Choi <cw00.choi@samsung.com>,
        =?UTF-8?B?QmFydMWCb21pZWogxbtvxYJuaWVya2lld2ljeg==?= 
        <b.zolnierkie@samsung.com>, myungjoo.ham@samsung.com,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Sorry, my bad, I have missed disabling place, and positive feedback
for max in other thread and push me to send it.

On Thu, Jul 25, 2019 at 9:23 AM Krzysztof Kozlowski <krzk@kernel.org> wrote=
:
>
> On Thu, 25 Jul 2019 at 08:37, Vasyl Gomonovych <gomonovych@gmail.com> wro=
te:
> >
> > Do not fire irq again until thread done
> > This issue was found by code inspection
> > Coccicheck irqf_oneshot.cocci
>
> Rationale does not look convincing. Do you fix real problem or just
> automatic fix from coccinelle? If the latter, then it looks wrong.
> This is virtual IRQ so no need for oneshot. The hardware IRQ has
> oneshot set. Otherwise please provide slightly more specific rationale
> for this commit.
>
> Best regards,
> Krzysztof
>
>
> >
> > Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
> > ---
> >  drivers/extcon/extcon-max77693.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-m=
ax77693.c
> > index 32fc5a66ffa9..68e42cd87e98 100644
> > --- a/drivers/extcon/extcon-max77693.c
> > +++ b/drivers/extcon/extcon-max77693.c
> > @@ -1142,7 +1142,7 @@ static int max77693_muic_probe(struct platform_de=
vice *pdev)
> >
> >                 ret =3D devm_request_threaded_irq(&pdev->dev, virq, NUL=
L,
> >                                 max77693_muic_irq_handler,
> > -                               IRQF_NO_SUSPEND,
> > +                               IRQF_NO_SUSPEND | IRQF_ONESHOT,
> >                                 muic_irq->name, info);
> >                 if (ret) {
> >                         dev_err(&pdev->dev,
> > --
> > 2.17.1
> >


--=20
=D0=94=D0=BE=D0=B1=D1=80=D0=BE=D1=97 =D0=B2=D0=B0=D0=BC =D0=BF=D0=BE=D1=80=
=D0=B8 =D0=B4=D0=BD=D1=8F.