Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] irqchip/gic-v3-its: Free unused vpt_page when alloc vpe
 table fail
To:     Marc Zyngier <marc.zyngier@arm.com>
References: <1564105905-15410-1-git-send-email-zhangshaokun@hisilicon.com>
 <20190726101844.79cb10b5@why>
CC:     <linux-kernel@vger.kernel.org>,
        Nianyao Tang <tangnianyao@huawei.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>
From:   Zhangshaokun <zhangshaokun@hisilicon.com>
Message-ID: <d33b8161-3ed0-07d6-af8a-d7fcca47f300@hisilicon.com>
Date:   Fri, 26 Jul 2019 17:24:13 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <20190726101844.79cb10b5@why>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Marc,

On 2019/7/26 17:18, Marc Zyngier wrote:
> On Fri, 26 Jul 2019 09:51:45 +0800
> Shaokun Zhang <zhangshaokun@hisilicon.com> wrote:
> 
>> From: Nianyao Tang <tangnianyao@huawei.com>
>>
>> In its_vpe_init, when its_alloc_vpe_table fails, we should free
>> vpt_page allocated just before, instead of vpe->vpt_page.
>> Let's fix it.
>>
>> Cc: Thomas Gleixner <tglx@linutronix.de> 
>> Cc: Jason Cooper <jason@lakedaemon.net>
>> Cc: Marc Zyngier <marc.zyngier@arm.com>
>> Signed-off-by: Nianyao Tang <tangnianyao@huawei.com>
>> ---
>>  drivers/irqchip/irq-gic-v3-its.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
>> index 730fbe0..1b5c367 100644
>> --- a/drivers/irqchip/irq-gic-v3-its.c
>> +++ b/drivers/irqchip/irq-gic-v3-its.c
>> @@ -3010,7 +3010,7 @@ static int its_vpe_init(struct its_vpe *vpe)
>>  
>>  	if (!its_alloc_vpe_table(vpe_id)) {
>>  		its_vpe_id_free(vpe_id);
>> -		its_free_pending_table(vpe->vpt_page);
>> +		its_free_pending_table(vpt_page);
>>  		return -ENOMEM;
>>  	}
>>  
> 
> Oops, well caught. Please repost this patch with your own SoB added
> though, as you're posting the patch on behalf of someone else.
> 

Thanks your reminder and I will do it in v2 version.

Shaokun

> Thanks,
> 
> 	M.
>