Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Luis de Oliveira <Luis.Oliveira@synopsys.com>
To:     Sakari Ailus <sakari.ailus@iki.fi>,
        Luis de Oliveira <Luis.Oliveira@synopsys.com>
CC:     "mchehab@kernel.org" <mchehab@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "Jonathan.Cameron@huawei.com" <Jonathan.Cameron@huawei.com>,
        "robh@kernel.org" <robh@kernel.org>,
        "nicolas.ferre@microchip.com" <nicolas.ferre@microchip.com>,
        "paulmck@linux.ibm.com" <paulmck@linux.ibm.com>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "kishon@ti.com" <kishon@ti.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Joao.Pinto@synopsys.com" <Joao.Pinto@synopsys.com>
Subject: RE: [v4 1/6] dt-bindings: media: Document bindings for DW MIPI CSI-2
 Host
Thread-Topic: [v4 1/6] dt-bindings: media: Document bindings for DW MIPI CSI-2
 Host
Thread-Index: AQHVIIrZEAgDFXEPAEq65DEFTPH6j6axNjgAgA/JhCCAAcZqAIABB4hwgBg47YCAAOY2kA==
Date:   Fri, 26 Jul 2019 09:50:12 +0000
Message-ID: <BY5PR12MB3699CA09F7CDB0827434F786CBC00@BY5PR12MB3699.namprd12.prod.outlook.com>
References: <1560280855-18085-1-git-send-email-luis.oliveira@synopsys.com>
 <1560280855-18085-2-git-send-email-luis.oliveira@synopsys.com>
 <20190628141326.swgl3kg4fj5pmlqx@valkosipuli.retiisi.org.uk>
 <MN2PR12MB37109D7AADCE4823CB458CB9CBF60@MN2PR12MB3710.namprd12.prod.outlook.com>
 <20190709182500.3x544axnrgy72aje@valkosipuli.retiisi.org.uk>
 <MN2PR12MB371026A6547B449EEC0439B1CBF00@MN2PR12MB3710.namprd12.prod.outlook.com>
 <20190725200211.GK1263@valkosipuli.retiisi.org.uk>
In-Reply-To: <20190725200211.GK1263@valkosipuli.retiisi.org.uk>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: synopsys.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 1135e944-4f7e-41c9-991e-08d711aea795
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2019 09:50:12.6667
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: c33c9f88-1eb7-4099-9700-16013fd9e8aa
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: lolivei@synopsys.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4163
X-OriginatorOrg: synopsys.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Sakari,

Thank you for the review, my answers inline.

> From: Sakari Ailus <sakari.ailus@iki.fi>
> Date: Thu, Jul 25, 2019 at 21:02:11
>
> Hi Luis,
>=20
> On Wed, Jul 10, 2019 at 10:20:55AM +0000, Luis de Oliveira wrote:
> > Hi Sakari,
> >=20
> > From: Sakari Ailus <sakari.ailus@iki.fi>
> > Date: Tue, Jul 09, 2019 at 19:25:00
> >=20
> > > Hi Luis,
> > >=20
> > > On Mon, Jul 08, 2019 at 03:21:50PM +0000, Luis de Oliveira wrote:
> > > > Hi Sakari,
> > > >=20
> > > > Thank you for your feedback.
> > > > I have my comments inline.
> > > >=20
> > > > From: Sakari Ailus <sakari.ailus@iki.fi>
> > > > Date: Fri, Jun 28, 2019 at 15:13:26
> > > >=20
> > > > > Hi Luis,
> > > > >=20
> > > > > Thank you for the patchset.
> > > > >=20
> > > > > On Tue, Jun 11, 2019 at 09:20:50PM +0200, Luis Oliveira wrote:
> > > > > > From: Luis Oliveira <lolivei@synopsys.com>
> > > > > >=20
> > > > > > Add bindings for Synopsys DesignWare MIPI CSI-2 host.
> > > > > >=20
> > > > > > Signed-off-by: Luis Oliveira <lolivei@synopsys.com>
> > > > > > ---
> > > > > > Changelog
> > > > > > v3-v4
> > > > > > - remove "plat" from the block name @rob @laurent
> > > > > > - remove "phy-names" when single-entry @rob
> > > > > > - remove "snps,output-type" -> went to the driver config @laure=
nt
> > > > > >=20
> > > > > >  .../devicetree/bindings/media/snps,dw-csi.txt      | 41 ++++++=
++++++++++++++++
> > > > > >  1 file changed, 41 insertions(+)
> > > > > >  create mode 100644 Documentation/devicetree/bindings/media/snp=
s,dw-csi.txt
> > > > > >=20
> > > > > > diff --git a/Documentation/devicetree/bindings/media/snps,dw-cs=
i.txt b/Documentation/devicetree/bindings/media/snps,dw-csi.txt
> > > > > > new file mode 100644
> > > > > > index 0000000..613b7f9
> > > > > > --- /dev/null
> > > > > > +++ b/Documentation/devicetree/bindings/media/snps,dw-csi.txt
> > > > > > @@ -0,0 +1,41 @@
> > > > > > +Synopsys DesignWare CSI-2 Host controller
> > > > > > +
> > > > > > +Description
> > > > > > +-----------
> > > > > > +
> > > > > > +This HW block is used to receive image coming from an MIPI CSI=
-2 compatible
> > > > > > +camera.
> > > > > > +
> > > > > > +Required properties:
> > > > > > +- compatible		: shall be "snps,dw-csi"
> > > > > > +- reg			: physical base address and size of the device memory
> > > > > > +			  mapped registers;
> > > > > > +- interrupts		: DW CSI-2 Host interrupts
> > > > > > +- phys			: List of one PHY specifier (as defined in
> > > > > > +			  Documentation/devicetree/bindings/phy/phy-bindings.txt).
> > > > > > +			  This PHY is a MIPI DPHY working in RX mode.
> > > > > > +- resets		: Reference to a reset controller (optional)
> > > > > > +
> > > > > > +The per-board settings:
> > > > > > + - port sub-node describing a single endpoint connected to the=
 camera as
> > > > > > +   described in video-interfaces.txt[1].
> > > > >=20
> > > > > Which endpoint properties in video-interfaces.txt are relevant fo=
r the
> > > > > hardware? Which values may they have?
> > > > >=20
> > > >=20
> > > > Currently I'm using only two properties "data-lanes" and "bus-width=
", but=20
> > > > I have plans to add blanking info also.
> > > > I will add more info.
> > >=20
> > > Isn't blanking defined by what the transmitter seneds? Or do you have
> > > hardware limitations on the receiver side?
> > >=20
> >=20
> > When we use this IP in prototyping we configure blanking at the receive=
r=20
> > side.
> > Some cameras don't have blanking configuration capabilities so we=20
> > configure it on the RX side.
>=20
> I haven't come across a CSI-2 connected camera without some kind of
> blanking configuration capabilities. Even if there was one, you couldn't
> configure blanking from the receiver side.
>=20
> Please document that the data-lanes property is required, and which value=
s
> are possible.
>=20

Ok, I will add the data-lanes property to the Documentation.

> >=20
> > > I've only heard of one such case before, and it was a very old parall=
el
> > > receiver.
> > >=20
> > > If you have a CSI-2 receiver, bus-width isn't relevant --- it's for p=
aralle
> > > interfaces only. Please add data-lanes to required endpoint propertie=
s.
> > >=20
> >=20
> > I used bus-width property in the Synopsys IPI (Image Pixel Interface)=20
> > that enables direct video stream access.
> > This interface is an output that can be 16-bit or 48-bit, that's why I=
=20
> > used bus-width property.
>=20
> Does this device write the image data to system memory, or is it another
> device? If there's another one, then you should probably have another por=
t
> to describe that connection.
>=20

Yes, it is another. I can add that connection port also.=20


> --=20
> Kind regards,
>=20
> Sakari Ailus

Thank you,

Luis