Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp12081360ybi; Fri, 26 Jul 2019 04:29:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqw4icH2Dx2gDtHjm4szesLBCQ3eQcN07sECXYYsz2NyKIlFf0XGW2u7plFl7EGAOj6eRoHS X-Received: by 2002:a63:89c2:: with SMTP id v185mr89908128pgd.241.1564140586332; Fri, 26 Jul 2019 04:29:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564140586; cv=none; d=google.com; s=arc-20160816; b=LVxbFUQ57WTbP7fj/httnPbsPTsxFBB+eMStN49aQCCVkQm1alocPIWS9DnNwuUtf4 FE1jaC33zZelUlYWNBqRWrHrLZzgVbJkIFOvih0GF6CQGJteea6wIOCNs7pjc7Gn3BNV Y36xvhGy/0GjGiULEQLsvpg6iVW41kE+oB0d2MjRmuiEexvgBuoJGdnojbj2Eljke3pa 78U/8DmOUUUM9JfjSM2xRKc/921VZTYdomPUYdRD841RkR4bxJ0Pff8h5f2jmmxyKuY8 Pxy2na3VRqaTFm9xAhnNMg6RghSO+HGTi0puNK5ppPtIasesFSM77p6ZaroRY8J2lGNC urXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=K7MgO7LDfJLI1re2AmLs6fSClTgO04pZ2Z1SN3XHnLo=; b=CQLhl6W43ubUR59+kh7dYMaKCQrofrTru2tVlCSQo6BgGD/2yYNKPm8LJF4lf6zY0t S6DQVTrL6/ddA0GB+4k9pQF4rM2y09wCGLFpHei6En2p5zVwUA6hxjgTC9sNRnB0f4ws GHADDMWVcOiI0d4XWM665G6lNSEemGUB7Tssgmu2XHKS4aJfKSWtMLcWFsLHYSSilvi/ PRwNQ0Dh1yREfP1XjadH/Btum7QNg6DkVwkdTEhwrvH0HpikYcFNUH5qcrajuBiMb8X6 O7HYvCdbcKC87vyuimGlJpPVR/Bbp/drSXgEeDtR3ZVoYTT2XnaMQGBLATCd2ad7GVAl VcUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="L/TZ3vb3"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a32si17068260pje.7.2019.07.26.04.29.31; Fri, 26 Jul 2019 04:29:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="L/TZ3vb3"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727039AbfGZL2E (ORCPT + 99 others); Fri, 26 Jul 2019 07:28:04 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:35467 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726191AbfGZL2E (ORCPT ); Fri, 26 Jul 2019 07:28:04 -0400 Received: by mail-lj1-f195.google.com with SMTP id x25so51209851ljh.2 for ; Fri, 26 Jul 2019 04:28:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=K7MgO7LDfJLI1re2AmLs6fSClTgO04pZ2Z1SN3XHnLo=; b=L/TZ3vb3T22EK1HJo+QpkSQL7fhtmr9agOpQ8pWUpl20813rj+CmWCzmfwqt2D54to DWNS4kJSBjnHDUgf+X9oCYLxE1orEFH+x89VNk7jykOjUABheMYPrvsCnQNaVFE8SZN3 3mIK54oD4QUmhWcOZOTtN9UrJT1zKoZ9HGzKb0Yrxq1RtjXRr6tjOY9B7hljvZbC13OS reks/ePwtDW5kj50ROfXjekOPnxhGDdp1a0fTE9/FMdR/hVF2EFOeZtoVTaA71eVQ0k5 mobVZ6zgAuegz3xyvBto6aiJKauJC+/adkzyU7FrLXgarhBd3YqqpBfJgEE4a8Ay7TK9 1qTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=K7MgO7LDfJLI1re2AmLs6fSClTgO04pZ2Z1SN3XHnLo=; b=Y1QitiFETMiv2FLqVXZqfcbwe1IyrQ/yvLAoAs9ML5XBX9FZAEkG/lQlZKUSaFLhNg 12zTEQz8zv0zYGzlA2mowzC1IsRf72UjoLU/5wrWmCR94M9pKuKfZDSthtSnfRC1Yn5p 8wRUCJO5O6fg9cOoRZXmcVe/v0U2QQyFku7YIF5l+HswmgI6vJmN0e6UrDdyEo75puQc ITYmwoAHXygcbQquXM5EUuUH3s6sI6M6UqVRW6bhQroesJQgpvxrl3mwG/GcaroeCyd0 P9M7lKGvQgD9u3MG+AT1gFnqtJwJdGUTr9vyHsh0OVnTBMu59gPyYkZCVw34Ypk9VHfm 4IZg== X-Gm-Message-State: APjAAAXbhtkfLA6AIvWg4DATcHYXRM+psaTokCs7doIjX0t3eqg6aCVb CUXR4WpfQrCnmGihoRczYFjgl4LXdukl6Q== X-Received: by 2002:a2e:8e90:: with SMTP id z16mr1684039ljk.4.1564140481817; Fri, 26 Jul 2019 04:28:01 -0700 (PDT) Received: from localhost (c-243c70d5.07-21-73746f28.bbcust.telenor.se. [213.112.60.36]) by smtp.gmail.com with ESMTPSA id v86sm9926234lje.74.2019.07.26.04.28.00 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 26 Jul 2019 04:28:00 -0700 (PDT) From: Anders Roxell To: robdclark@gmail.com, sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Anders Roxell Subject: [PATCH 3/3] drm: msm: a3xx: Mark expected switch fall-through Date: Fri, 26 Jul 2019 13:27:55 +0200 Message-Id: <20190726112755.19511-1-anders.roxell@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When fall-through warnings was enabled by default the following warning was starting to show up: ../drivers/gpu/drm/msm/adreno/adreno_gpu.c: In function ‘adreno_submit’: ../drivers/gpu/drm/msm/adreno/adreno_gpu.c:429:7: warning: this statement may fall through [-Wimplicit-fallthrough=] if (priv->lastctx == ctx) ^ ../drivers/gpu/drm/msm/adreno/adreno_gpu.c:431:3: note: here case MSM_SUBMIT_CMD_BUF: ^~~~ Rework so that the compiler doesn't warn about fall-through. Fixes: d93512ef0f0e ("Makefile: Globally enable fall-through warning") Signed-off-by: Anders Roxell --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c index 9acbbc0f3232..8fea014f0dea 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -428,6 +428,7 @@ void adreno_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit, /* ignore if there has not been a ctx switch: */ if (priv->lastctx == ctx) break; + /* Fall through */ case MSM_SUBMIT_CMD_BUF: OUT_PKT3(ring, adreno_is_a430(adreno_gpu) ? CP_INDIRECT_BUFFER_PFE : CP_INDIRECT_BUFFER_PFD, 2); -- 2.20.1