Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp121647ybi; Fri, 26 Jul 2019 07:06:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqyUPtMqc97c5ivN0OnzAC552CGnrS5t7lTAvSGjhuo+0Xq9IDrmvw+fioPkOh4l/N34UGNR X-Received: by 2002:a17:902:112c:: with SMTP id d41mr86202969pla.33.1564149983088; Fri, 26 Jul 2019 07:06:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564149983; cv=none; d=google.com; s=arc-20160816; b=SR870nTKWKwFm7JemT9UGwNLEYV23rcfC7LKxP8Gq1ULtT3Uo697yyFOcUaU/ffUGD KPEN6iIEtvStnzk7UZ9CIo2v8I7ik3uobHMixmtNbgUrCjEQpBKuIuWNa5h0E0+stveN ZwSyje/CvK4L0IehZre99weR/27pCC5uokXyn+L0RR1fUQKvQr0er4F+18sOCmzsLnS/ 6qVCQPHetQspGXv/g/+EHwv6Gq3uQwXscZR6rhW5pyVoWbqrfVatZ2BD6uwoamaC6/pb fsH4c9rT7hXWINoaUCz95HIDD1aTRecQRrq+zpISR9vMYe0Iw8NRPX4tVC4oBWZGcbZB jSpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=ts0Fu5vq7YuAqlvYZY/+hk+paF1OVXmGa/2xQvOplr0=; b=Bjbp6AkiKjWi5pchjpzQqWRRbKVaFqI6wFVlSFibjQLEfI95W9KAW7YidZy5ab8qx/ EWTmIfvEjBBJ35EtsXyIVZLL81ioQrXKNJzoxt3aOpWp7CinNvfm7AA3IJUrkXSvZhZ3 Jf0mBBljgHWAn2cQHHUEWzBnynVjbkANDu53sqanwV3xDW9X69+1N7fGZW09ltRYzC/k 1ETU+Pcl9h66YCnKY0V7msRkZ19y1/2LQ6E4CS3DyXIBJCYFJpYrfrEPmersb9EvawOt EGBiQolv6A9J0QC4k7bgNkf5nYd8eo++8wxNH5uaQu2JJCHxUPEiK0WShaZnAs5cdOZ9 Mb2A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p44si19849216pjp.0.2019.07.26.07.06.07; Fri, 26 Jul 2019 07:06:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727405AbfGZOFF (ORCPT + 99 others); Fri, 26 Jul 2019 10:05:05 -0400 Received: from mga04.intel.com ([192.55.52.120]:42665 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726434AbfGZOFF (ORCPT ); Fri, 26 Jul 2019 10:05:05 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jul 2019 07:05:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,311,1559545200"; d="scan'208";a="322048440" Received: from msmall-mobl.amr.corp.intel.com (HELO [10.251.154.62]) ([10.251.154.62]) by orsmga004.jf.intel.com with ESMTP; 26 Jul 2019 07:05:03 -0700 Subject: Re: [alsa-devel] [RFC PATCH 09/40] soundwire: cadence_master: fix usage of CONFIG_UPDATE To: Guennadi Liakhovetski Cc: alsa-devel@alsa-project.org, tiwai@suse.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, vkoul@kernel.org, broonie@kernel.org, srinivas.kandagatla@linaro.org, jank@cadence.com, slawomir.blauciak@intel.com, Sanyog Kale References: <20190725234032.21152-1-pierre-louis.bossart@linux.intel.com> <20190725234032.21152-10-pierre-louis.bossart@linux.intel.com> <20190725222302.GB16003@ubuntu> From: Pierre-Louis Bossart Message-ID: Date: Fri, 26 Jul 2019 09:05:03 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190725222302.GB16003@ubuntu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> @@ -943,7 +953,10 @@ int sdw_cdns_init(struct sdw_cdns *cdns) >> >> cdns_writel(cdns, CDNS_MCP_CONFIG, val); >> >> - return 0; >> + /* commit changes */ >> + ret = cdns_update_config(cdns); >> + >> + return ret; > > + return cdns_update_config(cdns); yes, will fix. thanks!