Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp215378ybi; Fri, 26 Jul 2019 08:35:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqzKF+WSsOIH+3wXnkC9/oy15FPEwRkjqIhOndvZF2RMV3LwW121IDU+JGUpIRBVyaOD4ZMJ X-Received: by 2002:a65:684c:: with SMTP id q12mr48820237pgt.405.1564155329464; Fri, 26 Jul 2019 08:35:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564155329; cv=none; d=google.com; s=arc-20160816; b=eQAPdaBPIj+Z++vcZ0gIFUvcexPZ66wjZtNcSjftUUS+4wEg8UX6pNoCefrBh0Axc5 172AcqdGrW6y3zmMZ5bfeq4DoodwAVUxECLOV1JduBxl1exF96yhUH030dt4ekQciwL0 Os80UZI58SJTscqK3RBB78rnCzcz27iJRjty8aQcxpXkL8C5E720xM8etyJC2buRRHCq P49iDO18+3c9JC2CrITFs4YVrwyepkZOA7Mvtn6dXDLJ6/EyZblc0mixwez6fBxZZ4HI 0FbXXJvxzcrdoLkBowY4eVqsEWxir9n5huCln5L6dpn/3AwWeju4tlk+wNVZ9qOp4dww o7gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=C44uVYiqTSuxS1eeBZdOA4C/XmDf5s8HS0nFVdYh7kY=; b=whXnNCf0rOpx0fYwBfywjh+KSjpqbdWfTbZDhe9cygzq+aYCpbx/tIY5Aw1XrXaBdb FgMmOULjlnZX56CJiIQBha5AJ01Eb7FOKpRnmCHmpdoFzBWCm3JE0MfMWAUY8dxdsqj5 OWfN7ycoQSi7uo8lmsJgoxAWM1IJNidYLiV+iNPCs8PIODFWO9icfkmwO4s0uYsoK9r3 cgefTnZMlIhaKv03Pldve57MpzqYHPO0jb+f6VofbxygApp2hU/wKpRUVD/FKkqpBUcv 3805cEPPpwjBfB7OSDdWkiXOVWOAljIbHq24MTq/nTMl5odrIWM+jwfSgBlW7DooXpRY FWbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RUXfDANO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q23si21133713pfc.179.2019.07.26.08.35.14; Fri, 26 Jul 2019 08:35:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RUXfDANO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389535AbfGZPcn (ORCPT + 99 others); Fri, 26 Jul 2019 11:32:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:47924 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387859AbfGZPcl (ORCPT ); Fri, 26 Jul 2019 11:32:41 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5CD0B218D4; Fri, 26 Jul 2019 15:32:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564155160; bh=ilr3yYVnfkadw0BIMkVASEXZzFIXHCS7okPRCA9hKv8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RUXfDANOkmcytADa0VJb46cFhKerjXltrkW3EkSSNDWaKWJT4Vg4wMIezkxGbNLka fK9EXUG/YnX+gB7bfHiyzqQe4ygwo+q2vS0x3ux0bUiTZmDUccB7qrMYAMjUB0oxhD y21dZ52kYkWHqGVNSD3Gv5UbM702xY61bTH4cRFg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Eric Dumazet , Christoph Paasch , "David S. Miller" Subject: [PATCH 4.19 22/50] tcp: Reset bytes_acked and bytes_received when disconnecting Date: Fri, 26 Jul 2019 17:24:57 +0200 Message-Id: <20190726152302.854207423@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190726152300.760439618@linuxfoundation.org> References: <20190726152300.760439618@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christoph Paasch [ Upstream commit e858faf556d4e14c750ba1e8852783c6f9520a0e ] If an app is playing tricks to reuse a socket via tcp_disconnect(), bytes_acked/received needs to be reset to 0. Otherwise tcp_info will report the sum of the current and the old connection.. Cc: Eric Dumazet Fixes: 0df48c26d841 ("tcp: add tcpi_bytes_acked to tcp_info") Fixes: bdd1f9edacb5 ("tcp: add tcpi_bytes_received to tcp_info") Signed-off-by: Christoph Paasch Signed-off-by: Eric Dumazet Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/ipv4/tcp.c | 2 ++ 1 file changed, 2 insertions(+) --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@ -2594,6 +2594,8 @@ int tcp_disconnect(struct sock *sk, int tcp_saved_syn_free(tp); tp->compressed_ack = 0; tp->bytes_sent = 0; + tp->bytes_acked = 0; + tp->bytes_received = 0; tp->bytes_retrans = 0; tp->dsack_dups = 0; tp->reord_seen = 0;