Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp215669ybi; Fri, 26 Jul 2019 08:35:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqzjDamFMQY69cPxQ/usEIdcsAy+B5saO3rida4T4XPgRncNJnvJdqCeAaTxWWDng3Al5Ncf X-Received: by 2002:aa7:915a:: with SMTP id 26mr22800607pfi.247.1564155346283; Fri, 26 Jul 2019 08:35:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564155346; cv=none; d=google.com; s=arc-20160816; b=s/NWc51h2hyMY1tmm8r/lqHGhRfjx0LK+zyUZYmSWJkvdCXoOcpO5ez+ZGSlZltDum TO9R0Ni+ImA0XLFtQKvZacOH+BwEM623gmNOdBRZtgf/PA4cetcwQnslsYmCLFKkSqXO XZijKzlOV5/zw9bXvJjnpWyJuz7rHAJ6k+WLfReMqjNsqGcHxdT6wHekP9JkBjVFYP8I CRj16LDeblYzI5rObndccypGwdqRwLBIOJygWSPQPWcT+sizYjLwQ8WQn5Mx4Z2BzIbu PlyZxs7EYjM90HG7EMP34ArYymRIICDNhsYhxm1peNd8xnNfpEfxHcd/7RhynSFyYVaH 3d4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Ow56n2L3Kq8MOSxUVplHLGSydT2zd0Yf8R6Rv7RUMFw=; b=GwcQ+YrjOz1838OcdRkjZuxCl7QdcB3lGnGZOLhglHKloAD6DErpqdJMcZpJe54Gzq YBVyq1XkirA3aWSnkJ4avhFVBN4gwVP6TJKn0DqMwgyV0Q5BJH+ZBIczuK79j1ndy/1M BUK81R4T9jr0tuUYeo58QSHdiYxO5yIszb73v/DC+4L9LCKuLN36ML56anPED/enriBM dQwAjh0ZZWHdxKiE1XbfvM+FAG7pje21ug6uLf+zo1ZR45fTBzR5cANWTxktKDlFiKxW lB26FNdMdWUVjL6m+k4PpyV6NcXhNfkkZ89QdD08IpFNVceVLIjKC2aX3Eq+1+BMKB5F u5bQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YtBQbE+s; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u20si19080060pgg.565.2019.07.26.08.35.31; Fri, 26 Jul 2019 08:35:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YtBQbE+s; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389134AbfGZPc7 (ORCPT + 99 others); Fri, 26 Jul 2019 11:32:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:48248 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728305AbfGZPc6 (ORCPT ); Fri, 26 Jul 2019 11:32:58 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3B0F120644; Fri, 26 Jul 2019 15:32:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564155177; bh=isWgQL8oAvhDesX3jX8Kg4zXgZ+BM6SzrDwebKcjy+M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YtBQbE+s7n74aqnhDUdxxBJnXqK9GsSBxLMRkGKNsYCcmDymXndNU5FBbpSp6kb7t CWqL/ERMFQ/wNsMXx/tdC0amYRAQpfU57tkp53HALmn6Bjw4X5vIX8+uIGrwO+qYmw GYlnjonBhs8Z3ynl4LMOFle1xTEkqRLGjvkQuVJ0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Haiyang Zhang , "David S. Miller" Subject: [PATCH 4.19 03/50] hv_netvsc: Fix extra rcu_read_unlock in netvsc_recv_callback() Date: Fri, 26 Jul 2019 17:24:38 +0200 Message-Id: <20190726152301.083757733@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190726152300.760439618@linuxfoundation.org> References: <20190726152300.760439618@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Haiyang Zhang [ Upstream commit be4363bdf0ce9530f15aa0a03d1060304d116b15 ] There is an extra rcu_read_unlock left in netvsc_recv_callback(), after a previous patch that removes RCU from this function. This patch removes the extra RCU unlock. Fixes: 345ac08990b8 ("hv_netvsc: pass netvsc_device to receive callback") Signed-off-by: Haiyang Zhang Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/hyperv/netvsc_drv.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/net/hyperv/netvsc_drv.c +++ b/drivers/net/hyperv/netvsc_drv.c @@ -847,7 +847,6 @@ int netvsc_recv_callback(struct net_devi csum_info, vlan, data, len); if (unlikely(!skb)) { ++net_device_ctx->eth_stats.rx_no_memory; - rcu_read_unlock(); return NVSP_STAT_FAIL; }