Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751763AbVLGTFP (ORCPT ); Wed, 7 Dec 2005 14:05:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751765AbVLGTFO (ORCPT ); Wed, 7 Dec 2005 14:05:14 -0500 Received: from caramon.arm.linux.org.uk ([212.18.232.186]:59148 "EHLO caramon.arm.linux.org.uk") by vger.kernel.org with ESMTP id S1751763AbVLGTFN (ORCPT ); Wed, 7 Dec 2005 14:05:13 -0500 Date: Wed, 7 Dec 2005 19:05:05 +0000 From: Russell King To: "Randy.Dunlap" Cc: Dmitry Torokhov , Jean Delvare , LKML , Greg KH Subject: Re: [PATCH] Minor change to platform_device_register_simple prototype Message-ID: <20051207190505.GJ6793@flint.arm.linux.org.uk> Mail-Followup-To: "Randy.Dunlap" , Dmitry Torokhov , Jean Delvare , LKML , Greg KH References: <20051205212337.74103b96.khali@linux-fr.org> <20051205202707.GH15201@flint.arm.linux.org.uk> <200512070105.40169.dtor_core@ameritech.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 974 Lines: 24 On Wed, Dec 07, 2005 at 10:39:36AM -0800, Randy.Dunlap wrote: > On Wed, 7 Dec 2005, Dmitry Torokhov wrote: > > > Btw, what is the policy on placing EXPORT_SYMBOL(...). Should they all > > go together (at the top or teh bottom) or after each symbol > > definition? Right now platform.c mixes 2 styles... > > Not all grouped together (option 1 above), but > yes, after each symbol definition (option 2 above)... > is the current preference AFAIK. And of course I didn't want to add extra noise by shuffling them around needlessly, especially if we're going to be removing some of them at some point in the future. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/