Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp401312ybi; Fri, 26 Jul 2019 11:40:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqxQrbHewgKXq4NONg2G2w7brQqAYu4C9GFsSvyne7LfiifMkY8SGtVE1BVOPff8x06uo0hC X-Received: by 2002:a62:14c4:: with SMTP id 187mr23102969pfu.241.1564166433596; Fri, 26 Jul 2019 11:40:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564166433; cv=none; d=google.com; s=arc-20160816; b=m96+cRGawDXZ6Wcsll1q7/KqXcs313ERjoga4dP09kxr7MT0EuhCFvKynfE+RbEkOz u5ft97pMdVsCq0hsALJQU7eThGhvgUPq2vlZpItdgwQkCCvzD0R8WI1oC1oRFREUKnr7 E31LogWESTC7C6Evvq8YwemtSPA7kU90hwD5FxmEubn/F7aQ7f14BBsArLEgUH4120z5 t9g8YT6vXGHML0w6dg9kNZTQCJuASZ3xBF8mORxQOygXKP22ng+DaRqAi1rngydub3UO /tqWyM8acjwf8ioSWQ4R2jbdwbtExkBsqumxnjDF54ME/BIcn8VqEHRmVIePpyMzl65U EqWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=A7UlB0kVfdvumUnQeHuR7fNuKqFwm3woMpGrM61w0Ew=; b=pkaZ5XB739p+32WzougMmIKluUbmDKu2apfXT3lSSSygVche1MpVZtg/VtHxkQzdfg 0951pOQuonYK/vJNYJzCGJKjYUz8RWBunCK3jJljNlOBvRpu6B0h8TrkqUJHF/Ccv7PZ M0eB7iWZF4IUTAwKtwnjmltHOtrCGNkCA6wwStJbTqe8NiLZUEcFWa3Ce2NdSSRPmMWB aw0PyNPdXAdYdpT9X4QbRCGW1j82f2om/ZopMFI395eSUIosb2IWLyDNuS9R51+n+wak LOKqK6MRvP1Oto3ZPd0bUJfZV2hUo8j6Z7BOOVD6sNNXzIsdsGcUqvJc4fKYCXKf96Z9 IpOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OOqZRr6F; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a88si18444406pje.6.2019.07.26.11.40.18; Fri, 26 Jul 2019 11:40:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OOqZRr6F; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728593AbfGZP1p (ORCPT + 99 others); Fri, 26 Jul 2019 11:27:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:42026 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728578AbfGZP1n (ORCPT ); Fri, 26 Jul 2019 11:27:43 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6E010205F4; Fri, 26 Jul 2019 15:27:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564154862; bh=TOvUZ/V6H7pXioIIJXW/vE91et+Coe2BrdMyH+z6fVE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OOqZRr6FKFfPZnHWnGcxjQ9OGFvhJrZB7BhVd+qsSy7DuIM1pt9uZNErHbpczraEA lBAVOZMReozDA6Fs9WFfMgTM/krh4DX4bf++iJsDqLMa9+mS66bC86AYvC2arb1tyV zaC4K9AGB/UII6ttNKCfHd1f58ye4wfKAEPJ7L8k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Paul Cercueil , Linus Walleij , Paul Burton , Ralf Baechle , James Hogan , od@zcrc.me, linux-mips@vger.kernel.org Subject: [PATCH 5.2 52/66] MIPS: lb60: Fix pin mappings Date: Fri, 26 Jul 2019 17:24:51 +0200 Message-Id: <20190726152307.584006536@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190726152301.936055394@linuxfoundation.org> References: <20190726152301.936055394@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Paul Cercueil commit 1323c3b72a987de57141cabc44bf9cd83656bc70 upstream. The pin mappings introduced in commit 636f8ba67fb6 ("MIPS: JZ4740: Qi LB60: Add pinctrl configuration for several drivers") are completely wrong. The pinctrl driver name is incorrect, and the function and group fields are swapped. Fixes: 636f8ba67fb6 ("MIPS: JZ4740: Qi LB60: Add pinctrl configuration for several drivers") Cc: Signed-off-by: Paul Cercueil Reviewed-by: Linus Walleij Signed-off-by: Paul Burton Cc: Ralf Baechle Cc: James Hogan Cc: od@zcrc.me Cc: linux-mips@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- arch/mips/jz4740/board-qi_lb60.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) --- a/arch/mips/jz4740/board-qi_lb60.c +++ b/arch/mips/jz4740/board-qi_lb60.c @@ -466,27 +466,27 @@ static unsigned long pin_cfg_bias_disabl static struct pinctrl_map pin_map[] __initdata = { /* NAND pin configuration */ PIN_MAP_MUX_GROUP_DEFAULT("jz4740-nand", - "10010000.jz4740-pinctrl", "nand", "nand-cs1"), + "10010000.pin-controller", "nand-cs1", "nand"), /* fbdev pin configuration */ PIN_MAP_MUX_GROUP("jz4740-fb", PINCTRL_STATE_DEFAULT, - "10010000.jz4740-pinctrl", "lcd", "lcd-8bit"), + "10010000.pin-controller", "lcd-8bit", "lcd"), PIN_MAP_MUX_GROUP("jz4740-fb", PINCTRL_STATE_SLEEP, - "10010000.jz4740-pinctrl", "lcd", "lcd-no-pins"), + "10010000.pin-controller", "lcd-no-pins", "lcd"), /* MMC pin configuration */ PIN_MAP_MUX_GROUP_DEFAULT("jz4740-mmc.0", - "10010000.jz4740-pinctrl", "mmc", "mmc-1bit"), + "10010000.pin-controller", "mmc-1bit", "mmc"), PIN_MAP_MUX_GROUP_DEFAULT("jz4740-mmc.0", - "10010000.jz4740-pinctrl", "mmc", "mmc-4bit"), + "10010000.pin-controller", "mmc-4bit", "mmc"), PIN_MAP_CONFIGS_PIN_DEFAULT("jz4740-mmc.0", - "10010000.jz4740-pinctrl", "PD0", pin_cfg_bias_disable), + "10010000.pin-controller", "PD0", pin_cfg_bias_disable), PIN_MAP_CONFIGS_PIN_DEFAULT("jz4740-mmc.0", - "10010000.jz4740-pinctrl", "PD2", pin_cfg_bias_disable), + "10010000.pin-controller", "PD2", pin_cfg_bias_disable), /* PWM pin configuration */ PIN_MAP_MUX_GROUP_DEFAULT("jz4740-pwm", - "10010000.jz4740-pinctrl", "pwm4", "pwm4"), + "10010000.pin-controller", "pwm4", "pwm4"), };