Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp443549ybi; Fri, 26 Jul 2019 12:26:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqz/guiMnbQGS3z3kkTcqdA4vDyKdPHzyrTixDA54jTm7H9migSzj+AVgzXAlgaovx3CQpzF X-Received: by 2002:a63:f118:: with SMTP id f24mr95046628pgi.322.1564169210049; Fri, 26 Jul 2019 12:26:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564169210; cv=none; d=google.com; s=arc-20160816; b=h5D7trpwWHhpdeYD2b4b5Ab/fYsrhNra84gMqOWC6eCvazYhcdNuxO1xD6Q17rtYT0 fh0BuPkQdDVgdXyDUxikBAcNdwdhXYwgpQoi/vVwzB1KcXUxSzvZbFdRy/UvXtOmQxsZ CEPOAD6B1LTGXtEerQ4S92mF8bp7mGtCiFVOIUmMueuacPVBywsoFXLmIfhnFl2W8Jdk Go+0BVRLzv+E9HyAoXqBXIr0EG7yCwVNNTT5U6qvEcQD2dymw10DSDX/wKKCZSaJeqI7 hPaz9rblE+YRGz1SXu9j9KJm1F16y/5eSiIHpYPDCzlSJyOKY/laA4FxEz9YBi33n6ju l5tA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature; bh=+CW43oDjjf97uXnO1yFBC+kyjGo7bEowuJ7murd1juw=; b=Iwpb+GLrpV6eWD0Peg5ijDWhqrEAF2dNh6cowijMjpdaZDRMCx1uwPNmFRocELcghI tN3UlCPloFF9zqTFhTe34f61xeEmiMQ+V6uCmmo41lSpCZS7jL4m25PJMbDtu+CVxJzA DND0c3d6t4WxcpwwRX77Oif1Fj9QiSJNpfbAMx3yPwqULkTq3BNq5wi9ir+vcV5AZXJ8 mTpxVdUd9TxNs8SDTsZ/tsSKGtPGruPglN9xi39Ls1Jub89hiXgW3tgOvqjttzznY1+e zh7D+hncDKglOoWETe2BxRI1fxSmUxUBZrZlJSoLC1w3CYTEK0anat0TbWIOkkT16khj KoBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=etENTVA7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 29si7402844pgw.326.2019.07.26.12.26.35; Fri, 26 Jul 2019 12:26:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=etENTVA7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728863AbfGZQ3a (ORCPT + 99 others); Fri, 26 Jul 2019 12:29:30 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:43022 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728826AbfGZQ33 (ORCPT ); Fri, 26 Jul 2019 12:29:29 -0400 Received: by mail-lj1-f196.google.com with SMTP id y17so27479458ljk.10; Fri, 26 Jul 2019 09:29:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=+CW43oDjjf97uXnO1yFBC+kyjGo7bEowuJ7murd1juw=; b=etENTVA7DjvU2AiUuoCuuykKkMYl2+TSQPOT5X3qJ2eZJFHwPPg0VsEjVW85mww7Vo 8dweWbEnm97EKHJbmAQyycY83tIVmIr0uF2b+bZ4SgIPfeygo9kYob5bayq+fMf0MN18 u7ZTEVCKjZqtWYRhM5yH7hMftMbRB6JSJ+BRLgic48AlReU1gHBV2OsRoaea77ad41PE hQYBMynd8gncuWog2CXD09tp6FhhWDsOpCK7ILsUcTt684Bzasil8XiGIosjpGPSyqFJ 0uNfzXDT8PERLi0DHPN1eiLJVYUczXEAWKqt3EKJ4WmO1PKPVqeVLmn7S8qObocWoBjB JJMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=+CW43oDjjf97uXnO1yFBC+kyjGo7bEowuJ7murd1juw=; b=TQ910LPL/i8H/qYSAkk3A/63uNBZnINnGozZge/w/+hm/90rJPC1+J/9lzr1lIttBh opzZolmvFbiYv2FpWRymai/mG+VJwPiPv9l99WkwLEHq7znSLx0b/Wkn7kp35XPD7NcD c0eXN16SScPf5jzLAS2Lc6uZNNPhqIqIu3DuU1Ywi0N9PervHkN/pgnC0A+nbrD0k5Jh DwWai+w0s/F/oyqM1Yhrr1u4fbcXnN1UihKY22WbryQyGn0NA0BoHbesNAsKvhKmB+Zb /V9V/u61z8m4XPlYRjh9b5B5C29c4Bo1JlP+h/hLAgEFoDOq5Ol4OTQuOo/4CP83rLEe ZEkw== X-Gm-Message-State: APjAAAXLXXhLCUvohe4iTCmLSR9UrywJfE4F5AZfvmU/3lltqaOk60kX qtEJ4HGuWk7r5TlpzToSJMuyYfWlEHZ9bU3JLT8= X-Received: by 2002:a2e:5b5b:: with SMTP id p88mr14059332ljb.192.1564158567371; Fri, 26 Jul 2019 09:29:27 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a2e:94c:0:0:0:0:0 with HTTP; Fri, 26 Jul 2019 09:29:26 -0700 (PDT) In-Reply-To: <20190726100614.6924-1-colin.king@canonical.com> References: <20190726100614.6924-1-colin.king@canonical.com> From: Stanislav Yakovlev Date: Fri, 26 Jul 2019 20:29:26 +0400 Message-ID: Subject: Re: [PATCH] ipw2x00: remove redundant assignment to err To: Colin King Cc: Kalle Valo , "David S . Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/07/2019, Colin King wrote: > From: Colin Ian King > > Variable err is initialized to a value that is never read and it > is re-assigned later. The initialization is redundant and can > be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- > drivers/net/wireless/intel/ipw2x00/ipw2100.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Looks fine, thanks! Stanislav.