Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp447260ybi; Fri, 26 Jul 2019 12:31:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqzmMIfdnGV4IK9+pBXHT88cYpq59uW0ZbyM/FE/4DgQMdyj6D6a/I77R6+czbrGtq2ts4QO X-Received: by 2002:a63:6901:: with SMTP id e1mr62487481pgc.390.1564169469905; Fri, 26 Jul 2019 12:31:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564169469; cv=none; d=google.com; s=arc-20160816; b=0i/TYufPkxyZhbMhg6c6tK6kOwmZgBk1gSf4BeFlLvO1LsD27wsAc/P5FJoL64F2Mo 9tQmo5QN3Ge+ad34Pyayj+ayI5B7MsmT1l0Mo+AxfOTXKuSI+HRZMQauIawIA3w5Y4xX pG9NNlFlX2UlC2ZJXz9Xo/QvLkLjvs76S11NZPq0/hHZFKjjdQqcmjjLNLg45BXHNMo7 ZZs7A9n0IsKmAq1q0y9qUNyyX5WxyvI/d5OfOYhSRxlgi/6LDTYNg7sx+thuuzwb6wpz TEhk8KlD1BX4cO51loOMd66FuCypgSTO3nPTGc1bfAcBAITzswUi0AHRJdgE3MzhocDx /oZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=esO7QnCCyx9dzKTMgBFciVXyQ2aruZtdaUPoDfDZZgU=; b=F2cZtn4dQXV5tf/LWHikKWiDizfnrAxLG+vfu5Y2xyI9YYS6MPzUUDBsJnMHNsoEvd IdCym6Ip2Aop3GwGVah1GQjHaUcDDD8Tki2+ddM1rU60ER3/+7BhEsRYeP+SzjZtMhJJ BThuTYEdWNQiRuS0+EFc2yxmbS1MlsUKcKM7wSeFkgs/X2gwPYX9tdOzXJNU3uTi29Qf eGyjTImZCLW7VaYZ/jD3dTtsueUmot6cOxwdgiCWUi0sRmjRESPJXnp9SFYcuh5wTs67 oyUOMF3dkvzj/P+5AgO9nSJMKRydTHtK0I1BA1p1nYviIYRlOorF3FBnFs4DQCwr91n7 fJJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=BtXkSUiE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t4si17699266plb.188.2019.07.26.12.30.54; Fri, 26 Jul 2019 12:31:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=BtXkSUiE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727758AbfGZRLy (ORCPT + 99 others); Fri, 26 Jul 2019 13:11:54 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:10585 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727328AbfGZRLx (ORCPT ); Fri, 26 Jul 2019 13:11:53 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Fri, 26 Jul 2019 10:12:01 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Fri, 26 Jul 2019 10:11:53 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Fri, 26 Jul 2019 10:11:53 -0700 Received: from rcampbell-dev.nvidia.com (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 26 Jul 2019 17:11:48 +0000 Subject: Re: [PATCH v2 2/7] mm/hmm: a few more C style and comment clean ups To: Christoph Hellwig CC: , , , , , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jason Gunthorpe References: <20190726005650.2566-1-rcampbell@nvidia.com> <20190726005650.2566-3-rcampbell@nvidia.com> <20190726062320.GA22881@lst.de> X-Nvconfidentiality: public From: Ralph Campbell Message-ID: <6673dc71-f43e-849f-ca36-0b20805fc092@nvidia.com> Date: Fri, 26 Jul 2019 10:11:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190726062320.GA22881@lst.de> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1564161121; bh=esO7QnCCyx9dzKTMgBFciVXyQ2aruZtdaUPoDfDZZgU=; h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=BtXkSUiESCykynn98aAUZOYyg4yz7jKnWyWlQeuTkJgRs1pzxbnG+tdWelFiuNWFf lk2A6TLLDs6cQLe2Yo2AGejt/oTzYMtS1amgKmn2dm5v84UdJRMTYaGngk6xAfFfNb p99GEAtPQKu0WpF74vtOAbWCO1P3EV8HcGsPjmb/CtOUwIfsJf4d4RzpBS0UZFOFl5 mKy6fFTJpky1hLxVBJ8kIaj3ucax+hLNkEj3Rb1EYWFnVqCmhNJAyxMjR01QHESrZT ZRtQfwyfeh21KLwAKZ3N0lRnAXuC9Yp0RdEq+oNcbACTXWG+Ly+6gcvZF0sXLDUj4M vgXH0/SGBnYgA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/25/19 11:23 PM, Christoph Hellwig wrote: > Note: it seems like you've only CCed me on patches 2-7, but not on the > cover letter and patch 1. I'll try to find them later, but to make Ccs > useful they should normally cover the whole series. > > Otherwise this looks fine to me: > > Reviewed-by: Christoph Hellwig > Thanks for the review and sorry about the oversight on CCs.