Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp525692ybi; Fri, 26 Jul 2019 14:06:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqyWQ9okzE30yha+IAtDGMYhj/8Ocm7wteoGcFSF0OgIf6Pg4PBdHeCHPrIKifT0Yz8W9Bc3 X-Received: by 2002:a62:cf07:: with SMTP id b7mr24368704pfg.217.1564175166739; Fri, 26 Jul 2019 14:06:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564175166; cv=none; d=google.com; s=arc-20160816; b=Bh22WFnZoSNgbEQ2+WbNVZsZ1e0nf5U5bqjq2WO4+BqIRiCfQZz9Mqnb9zVn8z6Pbc cmuixuR0N+56wgmZLh8R8QxNlXpl4eHEYgi5Bq7zvIpbM9n2wSE5O908SNYoq56YpUTP AQUCYpAAL0dMgHq7cjxmlFubQnVv9Xo+jPEtNky14ECu80TVOr+N140NTiBGMqQKw19G 3u2FOB0bYs98W61vtM2UwUr8fBygKApNSRn4TBirqExu7GRKChVLYhbGwIhWeiNelg79 j9nAlZgUD9l+PQrGjzJMWHfyjkFzG4MQ/ie/h9At9tuI69zXPTyavPV9IAjDN/j1n9gW NCWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=+XBJBy8z2wZEHI93duA/brXOqyioAd+YzeFvd3PyF5g=; b=oEi/SsNWTuFxY35RIxvaZk6uvYe4j5qY3sq0AFqpLMeiJTLYsT+jsbg2FO31dBqhv4 Med+WAxnyi/moR1bd1q4UwPB2c1hwRNluSwQJ19GrJ5sAOYPo3gP0xZ6x8v7ACjZA7Wm M57c/iVJkTE25AhjD/DngE4UHtf8bao4t/BmaeRZFNpO/EwsfpSu61vRmcsfYLXrpfqr B86zCGTDBvQPxtbQaAZrnocEDKaS+1+Ss0yJeOxBOFgl78zJkiRJA+bpbIxqwE3irJ4f AqIRVx0mLrmC/nmCz9Zf+OFn6daRYOOHKb3TE/F3nSppD2BV3lO7NsZ4I8zEDfkIuxTH gYUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n6si23518588pgl.419.2019.07.26.14.05.50; Fri, 26 Jul 2019 14:06:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728186AbfGZVFK (ORCPT + 99 others); Fri, 26 Jul 2019 17:05:10 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:55054 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726102AbfGZVFK (ORCPT ); Fri, 26 Jul 2019 17:05:10 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 0A54B12665368; Fri, 26 Jul 2019 14:05:10 -0700 (PDT) Date: Fri, 26 Jul 2019 14:05:09 -0700 (PDT) Message-Id: <20190726.140509.821828313930772794.davem@davemloft.net> To: baijiaju1990@gmail.com Cc: jon.maloy@ericsson.com, ying.xue@windriver.com, netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: tipc: Fix a possible null-pointer dereference in tipc_publ_purge() From: David Miller In-Reply-To: <20190725092021.15855-1-baijiaju1990@gmail.com> References: <20190725092021.15855-1-baijiaju1990@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 26 Jul 2019 14:05:10 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jia-Ju Bai Date: Thu, 25 Jul 2019 17:20:21 +0800 > @@ -223,7 +223,8 @@ static void tipc_publ_purge(struct net *net, struct publication *publ, u32 addr) > publ->key); > } > > - kfree_rcu(p, rcu); > + if (p) > + kfree_rcu(p, rcu); Please fix your automated tools if that is what found this, because as others have nodes kfree_rcu() can take a NULL pointer argument just fine. Thank you.