Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 26 Jul 2019 23:30:52 +0200
User-Agent: K-9 Mail for Android
In-Reply-To: <CAHk-=wibXtQ9pjB9ctpy5jWJK93DL19Lj09Et6cYEQE+h7tPpg@mail.gmail.com>
References: <20190726093934.13557-1-christian@brauner.io> <20190726093934.13557-2-christian@brauner.io> <CAHk-=wibXtQ9pjB9ctpy5jWJK93DL19Lj09Et6cYEQE+h7tPpg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH v1 1/2] pidfd: add P_PIDFD to waitid()
To:     Linus Torvalds <torvalds@linux-foundation.org>
CC:     Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
        Oleg Nesterov <oleg@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        Kees Cook <keescook@chromium.org>,
        Joel Fernandes <joel@joelfernandes.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Tejun Heo <tj@kernel.org>, David Howells <dhowells@redhat.com>,
        Jann Horn <jannh@google.com>,
        Andrew Lutomirski <luto@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Aleksa Sarai <cyphar@cyphar.com>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Android Kernel Team <kernel-team@android.com>
From:   Christian Brauner <christian@brauner.io>
Message-ID: <8A437322-D16E-4D5F-ACFA-3B1DEAAC100A@brauner.io>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On July 26, 2019 11:26:45 PM GMT+02:00, Linus Torvalds <torvalds@linux-foun=
dation=2Eorg> wrote:
>On Fri, Jul 26, 2019 at 2:41 AM Christian Brauner
><christian@brauner=2Eio> wrote:
>>
>> -       if (type < PIDTYPE_MAX)
>> +       if (type < PIDTYPE_MAX && !pid)
>>                 pid =3D find_get_pid(upid);
>
>So now we have four cases in the switch statement, and two of them do
>*not* want that "find_get_pid()" call=2E
>
>Honestly, let's just move that whole thing into the switch statement
>for the two cases that do want it=2E Particulartly since I think the
>"upid =3D=3D 0" case for P_PGID will prefer it that way anyway=2E
>
>Let's not check 'type' in two different places in two completely
>different ways=2E
>
>Ok?
>
>             Linus

Ok, will resend with that changed=2E

Christian