Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 26 Jul 2019 17:00:02 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Andres Freund <andres@anarazel.de>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux Trace Devel <linux-trace-devel@vger.kernel.org>,
        Tzvetomir Stoyanov <tstoyanov@vmware.com>,
        Jiri Olsa <jolsa@redhat.com>, Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH] tools/lib/traceevent, tools/perf: Move struct
 tep_handler definition in a local header file
Message-ID: <20190726170002.13bbfbf5@gandalf.local.home>
In-Reply-To: <20190726205544.yffnsfsnji362jk7@alap3.anarazel.de>
References: <20181005122225.522155df@gandalf.local.home>
        <20190726035829.4xcw5k2exx4omlvg@alap3.anarazel.de>
        <20190726091200.0d1e1f01@gandalf.local.home>
        <20190726205544.yffnsfsnji362jk7@alap3.anarazel.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 26 Jul 2019 13:55:44 -0700
Andres Freund <andres@anarazel.de> wrote:

> How about my proposal to instead change the loops in
> trace-event-{python,perl}.c, the only callers of trace_find_next_event,
> to be something akin to
> 
> [idx_type_for_tep_get_event] event_count = tep_get_events_count(pevent);
> for ([idx_type_for_tep_get_event] idx = 0; idx < event_count; idx++)
> {
> 	struct tep_event *event = tep_get_events(...);
> 
> }
> 
> and just removing trace_find_next_event()? It's not a nice API imo, and
> seems unnecessary given that the events aren't a linked list anymore.

Yep, go for it :-)


> 
> 
> > Care to send a formal patch?  
> 
> Will do.

Thanks!

-- Steve