Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: IG08Feq1nlzISLcH+DY7KIqznRC10cnOfp7xJ5+1NzElQ6WeI0u5+zztkf4/Wjro7cCcktu7W7
 2dY9EvGknmnV1s+3EcA3s6p7U2b/D3IwOJGso1Q0qDx2jSnT7SyxEWo2BiQgQubZwhsH75zBt7
 6wo7er8h9QtEvW4w0+Izv1WoqswkY8ayKUVQacdCJrd0Jr1/N/xrJRScNy3tvssy5kTfzdoFUm
 JlSYe6kNj0oC+9mu9ncu/kPM7ikChzKTzAE3yfyye83XPe3dv1lp6PGijFJPnUJDzp6pUI00nW
 iUM=
From:   Anup Patel <Anup.Patel@wdc.com>
To:     Paul Walmsley <paul.walmsley@sifive.com>,
        Atish Patra <Atish.Patra@wdc.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Alan Kao <alankao@andestech.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Allison Randal <allison@lohutok.net>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Johan Hovold <johan@kernel.org>,
        "linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>,
        Palmer Dabbelt <palmer@sifive.com>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: RE: [PATCH 3/4] RISC-V: Support case insensitive ISA string parsing.
Thread-Topic: [PATCH 3/4] RISC-V: Support case insensitive ISA string parsing.
Thread-Index: AQHVQ+reRtipAV+pTkKW6PXuUKYNbKbdXtyAgAAaDYCAABM8AIAAMB9A
Date:   Sat, 27 Jul 2019 02:23:42 +0000
Message-ID: <MN2PR04MB6061790AFE4E0AAA838678028DC30@MN2PR04MB6061.namprd04.prod.outlook.com>
References: <20190726194638.8068-1-atish.patra@wdc.com>
 <20190726194638.8068-3-atish.patra@wdc.com>
 <alpine.DEB.2.21.9999.1907261346560.26670@viisi.sifive.com>
 <a8a6be2c-2dcb-fe58-2c32-e3baa357819c@wdc.com>
 <alpine.DEB.2.21.9999.1907261625220.26670@viisi.sifive.com>
In-Reply-To: <alpine.DEB.2.21.9999.1907261625220.26670@viisi.sifive.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: f897e0ed-eee7-4aa4-cad9-08d7123971ee
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2019 02:23:42.7456
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Anup.Patel@wdc.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB5741
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Paul Walmsley <paul.walmsley@sifive.com>
> Sent: Saturday, July 27, 2019 5:00 AM
> To: Atish Patra <Atish.Patra@wdc.com>
> Cc: linux-kernel@vger.kernel.org; Alan Kao <alankao@andestech.com>;
> Albert Ou <aou@eecs.berkeley.edu>; Allison Randal <allison@lohutok.net>;
> Anup Patel <Anup.Patel@wdc.com>; Daniel Lezcano
> <daniel.lezcano@linaro.org>; Greg Kroah-Hartman
> <gregkh@linuxfoundation.org>; Johan Hovold <johan@kernel.org>; linux-
> riscv@lists.infradead.org; Palmer Dabbelt <palmer@sifive.com>; Thomas
> Gleixner <tglx@linutronix.de>
> Subject: Re: [PATCH 3/4] RISC-V: Support case insensitive ISA string pars=
ing.
>=20
> On Fri, 26 Jul 2019, Atish Patra wrote:
>=20
> > On 7/26/19 1:47 PM, Paul Walmsley wrote:
> > > On Fri, 26 Jul 2019, Atish Patra wrote:
> > >
> > > > As per riscv specification, ISA naming strings are case
> > > > insensitive. However, currently only lower case strings are parsed
> > > > during cpu procfs.
> > > >
> > > > Support parsing of upper case letters as well.
> > > >
> > > > Signed-off-by: Atish Patra <atish.patra@wdc.com>
> > >
> > > Is there a use case that's driving this, or
> >
> > Currently, we use all lower case isa string in kvmtool. But somebody
> > can have uppercase letters in future as spec allows it.
> >
> >
> > can we just say, "use
> > > lowercase letters" and leave it at that?
> > >
> >
> > In that case, it will not comply with RISC-V spec. Is that okay ?
>=20
> I think that section of the specification is mostly concerned with someon=
e
> trying to define "f" as a different extension than "F", or something like=
 that.
> I'm not sure that it imposes any constraint that software must accept bot=
h
> upper and lower case ISA strings.
>=20
> What gives me pause here is that this winds up impacting DT schema
> validation:
>=20
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/D=
ocu
> mentation/devicetree/bindings/riscv/cpus.yaml#n41

If 'f' and 'F' mean same extension as-per RISC-V spec then software should =
also
interpret it that way hence this patch.

Regards,
Anup