Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp790335ybi; Fri, 26 Jul 2019 20:03:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqwy8GNwBSk1HkcsU8/+un2K8spjjFXv7wn5fx7o4dwHLca1uviPqiE0ug4F/OhCTra6YdLt X-Received: by 2002:a62:7990:: with SMTP id u138mr24511600pfc.191.1564196637538; Fri, 26 Jul 2019 20:03:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564196637; cv=none; d=google.com; s=arc-20160816; b=wvUmVQkyESK8IX1uKEzArTZJqJsZShCqxbAhgHckCKdYzWfNgdceXOEv+jzHUXZwty MLXCRY0tAJG10p8eyWExvxG0Q5XFOaoEZhGitYlseYoT7jRLUdi1/QMRtCFbPCWPE5Pt WjmRC/ObTvHRgRTGF3lVs4jGvze0vGJEGLkNvOx2nkia80otluTidClb7vJJJSPIExQn qMZBXAMoqsFDI7ABHjDuJMTLfZlxjmsr6L+lwhsHEvjT8ugDGt+CgDAIkaCh3ELZ3pZ0 pexHYrX4YaWmSwZNvZdLzED9mXnaESRSdylhPj0OLlnpK93varlK8EfBLFZa5QNxsauI 6jzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=tN/4dk4E58XistgDJ6zOTKtSRYqHTx/a1QOwwGKZMmk=; b=HUQO18RdGU+eS+MFEDBl6xRJr9pm03C/jUxXYKkciz30H4elXBjSuLBel/MOxvZUGb MEUyvmN/a7+VALm2IqiiWu5pd7bm5u6y/R0he/l9QYl6G2rfl9uRfuqdQnEfLTXINwWv BhgpFoBZWwK7+T2CfwxDEEt4piT9HcmzLe8z62bvH2KlSyUkkZp9quOaqq20E4dmAcbb cMa9UM3svM1zgDK4uHQajjMU/Hc9ckq48CiqvWH4b/C9ULnEKXspO47IyW2y0fD8/5su pa7F5M8MaOgF/W8sipI/qauPXvbd19yDMl0dafA0gQSemISKU3TqIXjJzdVPp9Haph4L 3iEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b="eUp19m/y"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x22si19750450pln.150.2019.07.26.20.03.42; Fri, 26 Jul 2019 20:03:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b="eUp19m/y"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727873AbfG0DCd (ORCPT + 99 others); Fri, 26 Jul 2019 23:02:33 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:41242 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726184AbfG0DCd (ORCPT ); Fri, 26 Jul 2019 23:02:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=tN/4dk4E58XistgDJ6zOTKtSRYqHTx/a1QOwwGKZMmk=; b=eUp19m/y/Qg1oORIbOZgd/lgOH dU1x4yAORlsvB70utYGcZLTwWnbrpNdkE7MYvHycUmKDhdJNay1C1zWz9TrPxN3INRKVF9XHSSupf aBX961lzv4uzmUhvzpmGFQZqpRpzlpaSNm7sKFvaywt+8zVZA/E+URoyEHPR5rlto02w=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hrCyV-0007ol-5S; Sat, 27 Jul 2019 05:02:23 +0200 Date: Sat, 27 Jul 2019 05:02:23 +0200 From: Andrew Lunn To: "Allan W. Nielsen" Cc: Horatiu Vultur , Nikolay Aleksandrov , roopa@cumulusnetworks.com, davem@davemloft.net, bridge@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: bridge: Allow bridge to joing multicast groups Message-ID: <20190727030223.GA29731@lunn.ch> References: <1564055044-27593-1-git-send-email-horatiu.vultur@microchip.com> <7e7a7015-6072-d884-b2ba-0a51177245ab@cumulusnetworks.com> <20190725142101.65tusauc6fzxb2yp@soft-dev3.microsemi.net> <20190726120214.c26oj5vks7g5ntwu@soft-dev3.microsemi.net> <20190726134613.GD18223@lunn.ch> <20190726195010.7x75rr74v7ph3m6m@lx-anielsen.microsemi.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190726195010.7x75rr74v7ph3m6m@lx-anielsen.microsemi.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > As you properly guessed, this model is quite different from what we are used to. Yes, it takes a while to get the idea that the hardware is just an accelerator for what the Linux stack can already do. And if the switch cannot do some feature, pass the frame to Linux so it can handle it. You need to keep in mind that there could be other ports in the bridge than switch ports, and those ports might be interested in the multicast traffic. Hence the CPU needs to see the traffic. But IGMP snooping can be used to optimise this. But you still need to be careful, eg. IPv6 Neighbour discovery has often been broken on mv88e6xxx because we have been too aggressive with filtering multicast. Andrew