Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [REGRESSION] 5.3-rc1: r8169: remove 1000/Half from supported
 modes
To:     Bernhard Held <berny156@gmx.de>, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>
References: <a291af45-310c-8b60-ae7e-392e73e3bad1@gmx.de>
 <0a48ecd7-7134-222d-833d-c1f65e055c02@gmail.com>
 <9af99856-2e5d-0e3a-34d3-0582da869919@gmx.de>
From:   Heiner Kallweit <hkallweit1@gmail.com>
Message-ID: <603ca390-eeb2-d50b-c2e6-9e22d92c535b@gmail.com>
Date:   Sat, 27 Jul 2019 12:27:22 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <9af99856-2e5d-0e3a-34d3-0582da869919@gmx.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 26.07.2019 22:45, Bernhard Held wrote:
> On 26.07.19 at 22:24, Heiner Kallweit wrote:
>> On 26.07.2019 22:16, Bernhard Held wrote:
>>> Hi Heiner,
>>>
>>> with commit a6851c613fd7 "r8169: remove 1000/Half from supported modes" my RTL8111B GB-link stops working. It thinks that it established a link, however nothing is actually transmitted. Setting the mode with `mii-tool -F 100baseTx-HD` establishes a successful connection.
>>>
>> Can you provide standard ethtool output w/ and w/o this patch? Also a full dmesg output
>> with the patch would be helpful.
>> Is "100baseTx-HD" a typo and you mean GBit? And any special reason why you set half duplex?
>>
> 
> The requested files are attached.
> 
Looks all normal. So it seems to be a HW issue with the integrated PHY (RTL8211B).
This PHY version is used also e.g. in RTL8168d. So better revert the original change.

> mii-tool doesn't offer GBit settings. I used HD only while playing around, both FD and HD are working.
> 
> Hope it helps!
> Bernhard
Heiner