Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 27 Jul 2019 19:15:54 +0200
From:   Jiri Olsa <jolsa@redhat.com>
To:     Vince Weaver <vincent.weaver@maine.edu>
Cc:     linux-kernel@vger.kernel.org,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Namhyung Kim <namhyung@kernel.org>
Subject: Re: [patch] perf.data documentation has wrong units for memory size
Message-ID: <20190727171554.GB31276@krava>
References: <alpine.DEB.2.21.1907251155500.22624@macbook-air>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.21.1907251155500.22624@macbook-air>
User-Agent: Mutt/1.12.0 (2019-05-25)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jul 25, 2019 at 11:57:43AM -0400, Vince Weaver wrote:
> 
> The perf.data-file-format documentation incorrectly says the 
> HEADER_TOTAL_MEM results are in bytes.  The results are in kilobytes
> (perf reads the value from /proc/meminfo)
> 
> Signed-off-by: Vince Weaver <vincent.weaver@maine.edu>

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

> 
> diff --git a/tools/perf/Documentation/perf.data-file-format.txt b/tools/perf/Documentation/perf.data-file-format.txt
> index 5f54feb19977..d030c87ed9f5 100644
> --- a/tools/perf/Documentation/perf.data-file-format.txt
> +++ b/tools/perf/Documentation/perf.data-file-format.txt
> @@ -126,7 +126,7 @@ vendor,family,model,stepping. For example: GenuineIntel,6,69,1
>  
>  	HEADER_TOTAL_MEM = 10,
>  
> -An uint64_t with the total memory in bytes.
> +An uint64_t with the total memory in kilobytes.
>  
>  	HEADER_CMDLINE = 11,
>