Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp1609387ybi; Sat, 27 Jul 2019 13:54:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqyUt8wyaxAXtgTuGl1TsHfm1+smT16PLT6XMqpn4GzLRQTm0hzHM7Vzz9uP9Xyf3/KTp7vZ X-Received: by 2002:a63:e62:: with SMTP id 34mr96077447pgo.331.1564260881352; Sat, 27 Jul 2019 13:54:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564260881; cv=none; d=google.com; s=arc-20160816; b=IXDbWr/e9M6h8oPkW8N1VNUwoa55eUIZ59R42cDAVZJsigbCCx/mIwc8KiY/Jjb5Tk G1JQqdv+Fmjgw3XJ/vWGqEZx9QBS/KzmbskOuRtuOfwqbO4zljHL/KgVfn5Fw4nou2wy So5Z/it7HAPEauXp2V0DRpvRPxJtpITbadrz1MoQe7V3tuKHP315OPBdDZB7mbJ1sjG+ aEdaOnknqd58c/WLP74yo2hdbOya34/okh8Jvwp6B0UAV/pL9VJmZyhJtoziNzs1V7kr bZN2+dQKMerDse5ZexEmemrWmA9eHn0HjKBvhq0/b7QlJFHO9237iyo5U/gfJhQC77hJ oW7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=hoRGaNtgrht7hssOLC1P0SNCjCxB389zhR8Af7OGLHo=; b=X3DCsgDmAHh06klgR8+fSd08lzKbc6pUMB82SHjtFI85RwXczIuOYJtDUOHnUMG6Nd Z5Az5Qp2u1GgdbnmdntjrL+NRnlxDBETji20FYkDLUiMpXV4Dur0cMQyzFcXJAU+m/ne o4CoMS03g4Z66ZJYh10+pFZt3CwvUxhLOdo/lw/fi2CxKY2I9mLWawpM0WU8qT0xrTkB NG77LuzKf6JEeLDGqg9fZA31/JaYvvNOmqutgqXPdXDk1AWRX3N+DT7jNdLUnHJFBtAT 4I5Yce0qp/CK8bZyk7z3ilxrMvKe0X73rgggiLiN99mprL+1Yg4UGxdbuQn9Ot3X0Lr9 d+fQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q32si22912626pgm.544.2019.07.27.13.54.24; Sat, 27 Jul 2019 13:54:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388227AbfG0UXQ (ORCPT + 99 others); Sat, 27 Jul 2019 16:23:16 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:39734 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387841AbfG0UXP (ORCPT ); Sat, 27 Jul 2019 16:23:15 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 20DB61533CD32; Sat, 27 Jul 2019 13:23:15 -0700 (PDT) Date: Sat, 27 Jul 2019 13:23:14 -0700 (PDT) Message-Id: <20190727.132314.1888016313569976606.davem@davemloft.net> To: mcroce@redhat.com Cc: antoine.tenart@bootlin.com, netdev@vger.kernel.org, maxime.chevallier@bootlin.com, mw@semihalf.com, stefanc@marvell.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] mvpp2: document HW checksum behaviour From: David Miller In-Reply-To: References: <20190725231546.23878-1-mcroce@redhat.com> <20190726125715.GB5031@kwain> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 27 Jul 2019 13:23:15 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Matteo Croce Date: Fri, 26 Jul 2019 16:35:59 +0200 > I see, there is a similar statement in mvpp2_port_probe(). > What about adding a static function which sets the flag, and add the > comment there instead of duplicating the comment? That sounds good to me.