Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030434AbVLGXGp (ORCPT ); Wed, 7 Dec 2005 18:06:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030441AbVLGXGp (ORCPT ); Wed, 7 Dec 2005 18:06:45 -0500 Received: from e2.ny.us.ibm.com ([32.97.182.142]:60867 "EHLO e2.ny.us.ibm.com") by vger.kernel.org with ESMTP id S1030434AbVLGXGo (ORCPT ); Wed, 7 Dec 2005 18:06:44 -0500 Message-ID: <43976AFD.7020707@watson.ibm.com> Date: Wed, 07 Dec 2005 23:06:37 +0000 From: Shailabh Nagar User-Agent: Debian Thunderbird 1.0.2 (X11/20051002) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Dave Hansen CC: linux-kernel , elsa-devel , LSE , ckrm-tech , Guillaume Thouvenin , Jay Lan , Jens Axboe , Suparna Bhattacharya Subject: Re: [ckrm-tech] [RFC][Patch 3/5] Per-task delay accounting: Sync block I/O delays References: <43975D45.3080801@watson.ibm.com> <439760CE.7050401@watson.ibm.com> <1133994835.30387.49.camel@localhost> In-Reply-To: <1133994835.30387.49.camel@localhost> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 722 Lines: 26 Dave Hansen wrote: > On Wed, 2005-12-07 at 22:23 +0000, Shailabh Nagar wrote: > >>+ if (-EIOCBQUEUED == ret) { >>+ __attribute__((unused)) struct timespec start, end; >>+ > > > Those "unused" things suck. They're really ugly. > > Doesn't making your delay functions into static inlines make the unused > warnings go away? They do indeed. Thanks ! It was a holdover from when the delay funcs were macros. Will fix everywhere. --Shailabh > > -- Dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/