Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030441AbVLGXIT (ORCPT ); Wed, 7 Dec 2005 18:08:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030442AbVLGXIT (ORCPT ); Wed, 7 Dec 2005 18:08:19 -0500 Received: from mail.kroah.org ([69.55.234.183]:61392 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S1030441AbVLGXIS (ORCPT ); Wed, 7 Dec 2005 18:08:18 -0500 Date: Wed, 7 Dec 2005 15:06:15 -0800 From: Greg KH To: dtor_core@ameritech.net Cc: Jean Delvare , LKML Subject: Re: [PATCH] Minor change to platform_device_register_simple prototype Message-ID: <20051207230615.GB742@kroah.com> References: <20051205212337.74103b96.khali@linux-fr.org> <20051205202707.GH15201@flint.arm.linux.org.uk> <200512070105.40169.dtor_core@ameritech.net> <20051207180842.GG6793@flint.arm.linux.org.uk> <20051207190352.GI6793@flint.arm.linux.org.uk> <20051207225126.GA648@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2156 Lines: 64 On Wed, Dec 07, 2005 at 05:59:24PM -0500, Dmitry Torokhov wrote: > On 12/7/05, Greg KH wrote: > > On Wed, Dec 07, 2005 at 05:18:40PM -0500, Dmitry Torokhov wrote: > > > On 12/7/05, Russell King wrote: > > > > > > > Unregistering is just a matter of calling platform_device_unregister(). > > > > An unregister call is a del + put in exactly the same way as it is > > > > throughout the rest of the driver model. > > > > > > > > > > Yes, and it works just fine everywhere except in initialization code > > > when you need to jump in the middle of _del + _put sequence. > > > > So, if you had _del, would it work easier for you? I just objected to > > it if it wasn't necessary. I didn't want to add functions that aren't > > used by anyone, but if is needed, I don't see a problem with it. > > > > Yes, the I can just write: > > ... > err = platform_driver_register(&i8042_driver); > if (err) > goto err_controller_cleanup; > > i8042_platform_device = platform_device_alloc("i8042", -1); > if (!i8042_platform_device) { > err = -ENOMEM; > goto err_unregister_driver; > } > > err = platform_device_add(i8042_platform_device); > if (err) > goto err_free_device; > ... > > if (!have_ports) { > err = -ENODEV; > goto err_delete_device; > } > > mod_timer(&i8042_timer, jiffies + I8042_POLL_PERIOD); > return 0; > > err_delete_device: > platform_device_del(i8042_platform_device); > err_free_device: > platform_device_put(i8042_platform_device); > err_unregister_driver: > platform_driver_unregister(&i8042_driver); > .... > > As you can see - single cleanup path.. Ok, that's fine with me. Russell, any objections? thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/