Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp2684530ybi; Sun, 28 Jul 2019 15:10:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqwKIKHx3mL4t5K+ZXFuLm9mUpczKSqmqKe1khAoqd67cGvtHOFSug4vRZVNKYQ5KfB5piED X-Received: by 2002:a65:6281:: with SMTP id f1mr95612093pgv.400.1564351828425; Sun, 28 Jul 2019 15:10:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564351828; cv=none; d=google.com; s=arc-20160816; b=f+PbBurclMry4D5k3Qp+4N7DAx0srS/f8qXTT/rzcp1fqwREzYB/jM0VahoN6+3R0b 4gaK9yE5o4SLQ1zc0lq+GH81fFAwKRR3D8g0K+2WXdi8QhDjs3ycDHOBdeDeNkOfkTRA FNPMRXFk+eoQ4Sok/TYBsreJjhZ8If0yiV1bntugZJnjp/tHotw9qpPte0g/JbGaAPoT Oz7vrR0Sf0A1oJxqMOp1n+SkkiLCIDTzjRVxnTuLzW97R9agCj0FDiGPOIRVG7CqvhNT BARgcqqI+sNhDO+NK+/vmLg8eOnVdRrWVJrAMoisKWVxyu/pma0bbjQTTEXaCFT2wRWE EbDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=FX1hpidhvVd2B1jpZNjhTE/QLOo8ZOGtRfMqnoho3GM=; b=bbBIVaup2+Hb9MaDhH5v4Y0yWRrogxQzlgMOTJla2zCI81ZK4eb+4g0alBbof7NOUU 49+WJiyA8Qmm/ahbS82vniefSBpDmk33Jl2GGrDYN6EBdTbVa3Bq0Ea0Nejwv28Efvg1 YdJLvvwjzkWV9Wtqz4IsjKumM1Hfd8q6b1RG4eaUBZQKFZ0NBl9hgyO+5HoWV/v/Ptk+ ZWt70SuMZV7ztoI4wS6QMPLwxiXOMuvcnG2/1mMyGOLy47tEAzsQIIesFTd3l8VHxmeM cs28ipieyAi+r/mbiTHstL8ic+bww5paLj25wZZOqvt4SvvUjr/fEMBIuiyE+P10TQ6y WqDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WSHsBcXZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c11si24091026pga.118.2019.07.28.15.10.13; Sun, 28 Jul 2019 15:10:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WSHsBcXZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726211AbfG1WJe (ORCPT + 99 others); Sun, 28 Jul 2019 18:09:34 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:37306 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726097AbfG1WJd (ORCPT ); Sun, 28 Jul 2019 18:09:33 -0400 Received: by mail-lj1-f196.google.com with SMTP id z28so2360806ljn.4 for ; Sun, 28 Jul 2019 15:09:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FX1hpidhvVd2B1jpZNjhTE/QLOo8ZOGtRfMqnoho3GM=; b=WSHsBcXZ7JERbbGCMkWI5YCfQg8C14MBHZJm3Hue5oF7J5DyqJl6tQpVbngQ8q52c8 2ScdHTPvRGepFlQLYPWxw2+AXctL99KLBkHSFQ8O4PukhjvxlRN35e1Mbo2a9eAsRy1L kJeMT5pviW3zV/uCvwdcsc4DwJCul8jcDjVvLZOXt+LUuxErTKp4EjWHWw8RditvsrEk Ql1emScyRfzwoGqoycMYh2gQ9ULJv2iQuCMF5g1ImxA1dcbqvRfi1uanPOPq3N2SLAHn ak5s40rLE1mfZYkTU+iKfp8r8S/5/BMctQsqsZ8htKP912yknb+5p451H5XxfSf1/42x 1cQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FX1hpidhvVd2B1jpZNjhTE/QLOo8ZOGtRfMqnoho3GM=; b=EmnrTTVNDV8fAJ1nq2W6QxLRZw2ND1k2WDY2Lp5IIBZIJY5843JJUqtXRajdebH8/z 7jCpDE7ZoAuYkJQCRfR0fufOURd35sOQuA3nMpNkj8JZ8d0XJpYL81WKTh/Fb7f7QEGA b4oo9tmbRBGg/5vXldXku3E/vAOxw25WSZtkPemkB1dk/QrEMh0rbg2NE0ZjYQ8KlRWu IXh0Ug7ky+rPzJUcfAnPqtl87Dl7R35m4FwdoIuFntFaqJM2b+eNdQ5/yeVi2lNKZvJX CkdWHoXv6WF+HnGTbSQMSB1SmyJ/ygge790mOMy8AfkCI5SkGC/ArXHeNGC2lX96EPEm DnpA== X-Gm-Message-State: APjAAAXxEt+z4QdA3ibqUD6MmBlQ5hLYHJYkgA/kXQQBZE7luMmeCu6C xIrj2UzHuHEX2h8v+9Se8xVXw2xifO9HepsjmHcVVg== X-Received: by 2002:a2e:2c14:: with SMTP id s20mr8043666ljs.54.1564351771778; Sun, 28 Jul 2019 15:09:31 -0700 (PDT) MIME-Version: 1.0 References: <20190606010249.3538-1-bjorn.andersson@linaro.org> <20190606010249.3538-3-bjorn.andersson@linaro.org> In-Reply-To: <20190606010249.3538-3-bjorn.andersson@linaro.org> From: Linus Walleij Date: Mon, 29 Jul 2019 00:09:20 +0200 Message-ID: Subject: Re: [PATCH v2 2/3] scsi: ufs: Allow resetting the UFS device To: Bjorn Andersson Cc: Rob Herring , Mark Rutland , Alim Akhtar , Avri Altman , Pedro Sousa , "James E.J. Bottomley" , "Martin K. Petersen" , Andy Gross , Evan Green , MSM , "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , linux-scsi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 6, 2019 at 3:02 AM Bjorn Andersson wrote: > Acquire the device-reset GPIO and toggle this to reset the UFS device > during initialization and host reset. > > Based on downstream support implemented by Subhash Jadavani > . > > Tested-by: John Stultz > Signed-off-by: Bjorn Andersson I agree with Rob that just "reset-gpios" looks better. Otherwise: Reviewed-by: Linus Walleij Yours, Linus Walleij